[jira] [Comment Edited] (HADOOP-13254) Create framework for configurable disk checkers

2016-07-15 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380211#comment-15380211
 ] 

Yufei Gu edited comment on HADOOP-13254 at 7/15/16 10:12 PM:
-

Thanks [~rkanter] for the committing. 


was (Author: yufeigu):
Thanks @robert for the committing. 

> Create framework for configurable disk checkers
> ---
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: util
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Fix For: 2.9.0
>
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, 
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch, 
> HADOOP-13254.006.patch, HADOOP-13254.007.patch, HADOOP-13254.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-13254) Create framework for configurable disk checkers

2016-07-15 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380037#comment-15380037
 ] 

Yufei Gu edited comment on HADOOP-13254 at 7/15/16 8:17 PM:


Thanks a lot for the review, [~rkanter] and [~rchiang]


was (Author: yufeigu):
Thanks a lot, [~rkanter]. 

> Create framework for configurable disk checkers
> ---
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: util
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, 
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch, 
> HADOOP-13254.006.patch, HADOOP-13254.007.patch, HADOOP-13254.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-13254) Create framework for configurable disk checkers

2016-07-11 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371473#comment-15371473
 ] 

Yufei Gu edited comment on HADOOP-13254 at 7/11/16 7:49 PM:


Thanks [~rchiang] for reiterating the design goal of {{DiskValidator}}. Agree 
to separate {{DiskValidator}} and {{DiskValidatorService}} interfaces. BTW, do 
we want to support users' own disk validator plugins in current design as 
[~rkanter] mentioned? I don't think it is a good idea to support that since 
they can do anything. 

I prefer to keep {{DiskValidator}} simple first. If we want a {{Service}}, we 
can create a {{Service}} to   invoke {{DiskValidator}} just like what 
{{LocalDirsHandlerService}} does.


was (Author: yufeigu):
Thanks [~rchiang] for reiterating the design goal of {{DiskValidator}}. Agree 
to separate {{DiskValidator}} and {{DiskValidatorService}} interfaces. BTW, do 
we want to support users' own disk validator plugins in current design as 
[~rkanter] mentioned? I don't think it is a good idea to support that since 
they can do anything. 

I prefer to keep {{DiskValidator}} simple first. If we want a {{Service}}, we 
can create a {{Service}} to   invoke {{DiskValidator}} just like 
{{LocalDirsHandlerService}}. 

> Create framework for configurable disk checkers
> ---
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: util
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, 
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch, 
> HADOOP-13254.006.patch, HADOOP-13254.007.patch, HADOOP-13254.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-13254) Create framework for configurable disk checkers

2016-07-11 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371473#comment-15371473
 ] 

Yufei Gu edited comment on HADOOP-13254 at 7/11/16 7:41 PM:


Thanks [~rchiang] for reiterating the design goal of {{DiskValidator}}. Agree 
to separate {{DiskValidator}} and {{DiskValidatorService}} interfaces. BTW, do 
we want to support users' own disk validator plugins in current design as 
[~rkanter] mentioned? I don't think it is a good idea to support that since 
they can do anything. 

I prefer to keep {{DiskValidator}} simple first. If we want a {{Service}}, we 
can create a {{Service}} to   invoke {{DiskValidator}} just like 
{{LocalDirsHandlerService}}. 


was (Author: yufeigu):
Thanks [~rchiang] for reiterating the design goal of {{DiskValidator}}. Agree 
to separate {{DiskValidator}} and {{DiskValidatorService}} interfaces. BTW, do 
we want to support users' own disk validator plugins in current design as 
[~rkanter] mentioned? I don't think it is a good idea to support that since 
they can do anything. 

> Create framework for configurable disk checkers
> ---
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: util
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, 
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch, 
> HADOOP-13254.006.patch, HADOOP-13254.007.patch, HADOOP-13254.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-13254) Create framework for configurable disk checkers

2016-07-11 Thread Yufei Gu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371179#comment-15371179
 ] 

Yufei Gu edited comment on HADOOP-13254 at 7/11/16 5:19 PM:


This is another option:
If any implementation of {{DiskValidator}} need threads, it should implement 
interface {{org.apache.hadoop.service.Service}}. The {{Servcie}} interface 
already provides well designed functions for a service like class. Why not 
reuse it and keep the {{DiskValidator}} interface simple. Or, make 
{{DiskValidator}} extend interface {{Service}}.


was (Author: yufeigu):
This is another option:
If any implementation of {{DiskValidator}} need threads, it should implement 
interface {{org.apache.hadoop.service.Service}}. The {{Servcie}} interface 
already provides well designed functions for a service like class. Why not 
reuse it and keep the {{DiskValidator}} interface simple. 

> Create framework for configurable disk checkers
> ---
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: util
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, 
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch, 
> HADOOP-13254.006.patch, HADOOP-13254.007.patch, HADOOP-13254.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-13254) Create framework for configurable disk checkers

2016-07-05 Thread Ray Chiang (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363111#comment-15363111
 ] 

Ray Chiang edited comment on HADOOP-13254 at 7/5/16 9:19 PM:
-

Changed summary to match code changes.  I'm assuming the configuration settings 
will go into YARN-5137.

More minor nits:
- I see that DiskValidatorFactory#getInstance(String) has @param and @throws, 
but DiskValidatorFactory#getInstance(Class) does not.  I know it's a bit 
redundant, but I see similar classes have the Javadoc for both methods.
- Make the InterfaceAudience settings more conservative for now (since 
DiskChecker is @InterfaceAudience.Private):
-- Keep DiskValidator as @InterfaceAudience.Private (i.e. Hadoop only) for now.
-- For DiskValidatorFactory, either remove @InterfaceStability.Evolving or 
change it to @InterfaceAudience.Unstable.


was (Author: rchiang):
Changed summary to match code changes.  I'm assuming the configuration settings 
will go into YARN-5137.

More minor nits:
- I see that DiskValidatorFactory#getInstance(String) has @param and @throws, 
but DiskValidatorFactory#getInstance(Class) does not.  I know it's a bit 
redundant, but I see similar classes have the Javadoc for both methods.
- Make the InterfaceAudience settings more conservative for now (since 
DiskChecker is @InterfaceAudience.Private):
-- Keep DiskValidator as @InterfaceAudience.Private (i.e. Hadoop only) for now.
-- For DiskValidatorFactory, remove @InterfaceStability.Evolving.

> Create framework for configurable disk checkers
> ---
>
> Key: HADOOP-13254
> URL: https://issues.apache.org/jira/browse/HADOOP-13254
> Project: Hadoop Common
>  Issue Type: Bug
>  Components: util
>Reporter: Yufei Gu
>Assignee: Yufei Gu
> Attachments: HADOOP-13254.001.patch, HADOOP-13254.002.patch, 
> HADOOP-13254.003.patch, HADOOP-13254.004.patch, HADOOP-13254.005.patch, 
> HADOOP-13254.006.patch, HADOOP-13254.007.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org