[ https://issues.apache.org/jira/browse/HADOOP-13546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447443#comment-15447443 ]
Xiaobing Zhou edited comment on HADOOP-13546 at 8/29/16 11:50 PM: ------------------------------------------------------------------ Thanks [~jingzhao] for the reviews. I posted patch v004 addressed all your comments. The unit tests are separated into io.retry and hadoop.ipc packages since tests for reusing connections need access to classes in ipc space. TestReuseRpcConnections extending TestRpcBase makes it easy to setup rpc server. was (Author: xiaobingo): Thanks [~jingzhao] for the reviews. I posted patch v004 addressed all your comments. The unit tests are separated into io.retry and hadoop.ipc packages since tests for reusing connections need access to classes in ipc space. > Override equals and hashCode to avoid connection leakage > -------------------------------------------------------- > > Key: HADOOP-13546 > URL: https://issues.apache.org/jira/browse/HADOOP-13546 > Project: Hadoop Common > Issue Type: Sub-task > Components: ipc > Affects Versions: 2.7.0 > Reporter: Xiaobing Zhou > Assignee: Xiaobing Zhou > Attachments: HADOOP-13546-HADOOP-13436.000.patch, > HADOOP-13546-HADOOP-13436.001.patch, HADOOP-13546-HADOOP-13436.002.patch, > HADOOP-13546-HADOOP-13436.003.patch, HADOOP-13546-HADOOP-13436.004.patch > > > Override #equals and #hashcode to ensure multiple instances are equivalent. > They eventually > share the same RPC connection given the other arguments of constructing > ConnectionId are > the same. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org