[jira] [Comment Edited] (HADOOP-14667) Flexible Visual Studio support

2018-03-19 Thread Brahma Reddy Battula (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405701#comment-16405701
 ] 

Brahma Reddy Battula edited comment on HADOOP-14667 at 3/20/18 3:02 AM:


{quote}I also tested VS2010 and also worked
{quote}
Getting the following error, do we need to update anything to work on VS2010..?
{noformat}
[DEBUG] Toolchains are ignored, 'executable' parameter is set to 
F:\t\hadoop-common-project\hadoop-common\..\..\dev-supp
ort\bin\win-vs-upgrade.cmd
[DEBUG] Executing command line: [cmd, /c, 
F:\t\hadoop-common-project\hadoop-common\..\..\dev-support\bin\win-vs-upgrade.
cmd, F:\t\hadoop-common-project\hadoop-common\src\main\winutils, 
F:\t\hadoop-common-project\hadoop-common\target]
INFO: Could not find files for the given pattern(s).
"devenv command was not found. Verify your compiler installation level."
{noformat}


was (Author: brahmareddy):
bq.I also tested VS2010 and also worked
Getting the following error, do we need to update anything to work on VS2010..? 
wnt' be incompatible..?

{noformat}
[DEBUG] Toolchains are ignored, 'executable' parameter is set to 
F:\t\hadoop-common-project\hadoop-common\..\..\dev-supp
ort\bin\win-vs-upgrade.cmd
[DEBUG] Executing command line: [cmd, /c, 
F:\t\hadoop-common-project\hadoop-common\..\..\dev-support\bin\win-vs-upgrade.
cmd, F:\t\hadoop-common-project\hadoop-common\src\main\winutils, 
F:\t\hadoop-common-project\hadoop-common\target]
INFO: Could not find files for the given pattern(s).
"devenv command was not found. Verify your compiler installation level."
{noformat}

> Flexible Visual Studio support
> --
>
> Key: HADOOP-14667
> URL: https://issues.apache.org/jira/browse/HADOOP-14667
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.0.0-beta1
> Environment: Windows
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: HADOOP-14667.00.patch, HADOOP-14667.01.patch, 
> HADOOP-14667.02.patch, HADOOP-14667.03.patch, HADOOP-14667.04.patch, 
> HADOOP-14667.05.patch
>
>
> Is it time to upgrade the Windows native project files to use something more 
> modern than Visual Studio 2010?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org



[jira] [Comment Edited] (HADOOP-14667) Flexible Visual Studio support

2017-07-31 Thread Allen Wittenauer (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-14667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107724#comment-16107724
 ] 

Allen Wittenauer edited comment on HADOOP-14667 at 7/31/17 6:33 PM:


bq. Does this mean the build will modify files that committers have to remember 
to unstage before commit? 

That's exactly what that means. devenv upgrades the solution (sln) and VS 
project (vxcproj) files for the new version by overwriting them. From what I 
can tell, it's usually just updating the XML schema version and setting some 
version flags.  (It's sort of ridiculous really, but whatever.) There's also 
the backup dirs and logs it creates. All of those changes stick out when doing 
a git diff or a git status.

But yeah, with a bit more work, I'm fairly confident I can get an "on the fly" 
upgrade-in-place.  Only requirement would be that vcvarsall be run one time 
prior to doing any maven work so that the paths are established.


was (Author: aw):
bq. Does this mean the build will modify files that committers have to remember 
to unstage before commit? 

That's exactly what that means. devenv upgrades the solution (sln) and VS 
project (vxcproj) files for the new version. From what I can tell, it's usually 
just updating the XML schema version and setting some version flags.  (It's 
sort of ridiculous really, but whatever.) There's also the backup dirs and logs 
it creates. All of those changes stick out when doing a git diff or a git 
status.

But yeah, with a bit more work, I'm fairly confident I can get an "on the fly" 
upgrade-in-place.  Only requirement would be that vcvarsall be run one time 
prior to doing any maven work so that the paths are established.

> Flexible Visual Studio support
> --
>
> Key: HADOOP-14667
> URL: https://issues.apache.org/jira/browse/HADOOP-14667
> Project: Hadoop Common
>  Issue Type: Improvement
>  Components: build
>Affects Versions: 3.0.0-beta1
> Environment: Windows
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
> Attachments: HADOOP-14667.00.patch, HADOOP-14667.01.patch, 
> HADOOP-14667.02.patch, HADOOP-14667.03.patch, HADOOP-14667.04.patch
>
>
> Is it time to upgrade the Windows native project files to use something more 
> modern than Visual Studio 2010?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org