[jira] [Comment Edited] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-07-24 Thread Erik Krogen (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892216#comment-16892216
 ] 

Erik Krogen edited comment on HADOOP-16459 at 7/24/19 10:07 PM:


I've put up a branch-2 patch as well. It has two additional modifications from 
the branch-3.0 patch:
* A lamba for {{GenericTestUtils.waitFor()}} is replaced with an anonymous 
subclass
* The {{RpcScheduler}} interface can no longer have default methods, since 
branch-2 uses Java 7. Unfortunately Java 7 has no way to emulate this behavior, 
so if users have a custom {{RpcScheduler}} implementation, it will break with 
this change. Our [compatibility 
policy|https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/InterfaceClassification.html]
 states that it is acceptable for us to make this breaking change in a minor 
version release since this interface is marked as {{LimitedPrivate}} / 
{{Evolving}}.

Edit: v000 patch for branch-2 was old and still had compilation issues. I just 
put up v001 with the correct version. My mistake.


was (Author: xkrogen):
I've put up a branch-2 patch as well. It has two additional modifications from 
the branch-3.0 patch:
* A lamba for {{GenericTestUtils.waitFor()}} is replaced with an anonymous 
subclass
* The {{RpcScheduler}} interface can no longer have default methods, since 
branch-2 uses Java 7. Unfortunately Java 7 has no way to emulate this behavior, 
so if users have a custom {{RpcScheduler}} implementation, it will break with 
this change. Our [compatibility 
policy|https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/InterfaceClassification.html]
 states that it is acceptable for us to make this breaking change in a minor 
version release since this interface is marked as {{LimitedPrivate}} / 
{{Evolving}}.

> Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the 
> RPC layer" to branch-2
> 
>
> Key: HADOOP-16459
> URL: https://issues.apache.org/jira/browse/HADOOP-16459
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Erik Krogen
>Assignee: Erik Krogen
>Priority: Major
> Attachments: HADOOP-16266-branch-2.000.patch, 
> HADOOP-16266-branch-2.001.patch, HADOOP-16266-branch-3.0.000.patch, 
> HADOOP-16266-branch-3.1.000.patch, HADOOP-16266-branch-3.2.000.patch
>
>
> We would like to target pulling HADOOP-16266, an important operability 
> enhancement and prerequisite for HDFS-14403, into branch-2.
> It's only present in trunk now so we also need to backport through the 3.x 
> lines.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Comment Edited] (HADOOP-16459) Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the RPC layer" to branch-2

2019-07-24 Thread Erik Krogen (JIRA) 


[ 
https://issues.apache.org/jira/browse/HADOOP-16459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892188#comment-16892188
 ] 

Erik Krogen edited comment on HADOOP-16459 at 7/24/19 9:18 PM:
---

Attached branch-3.0 patch. The merge difference was smaller than I expected; no 
logic changes were necessary. The signatures of some methods that appeared in 
the vicinity of changes were different, but not in a way that affected this 
patch.

One notable difference was that {{TestConsistentReadsObserver}} doesn't yet 
exist in branch-3.0, so the modifications to that test were excluded. If 
HDFS-14573 is finalized before this goes in, those changes should be brought 
back.


was (Author: xkrogen):
Attached branch-3.0 patch. The merge difference was smaller than I expected; no 
logic changes were necessary. The signatures of some methods that appeared in 
the vicinity of changes were different, but not in a way that affected this 
patch.

> Backport [HADOOP-16266] "Add more fine-grained processing time metrics to the 
> RPC layer" to branch-2
> 
>
> Key: HADOOP-16459
> URL: https://issues.apache.org/jira/browse/HADOOP-16459
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Erik Krogen
>Assignee: Erik Krogen
>Priority: Major
> Attachments: HADOOP-16266-branch-3.0.000.patch, 
> HADOOP-16266-branch-3.1.000.patch, HADOOP-16266-branch-3.2.000.patch
>
>
> We would like to target pulling HADOOP-16266, an important operability 
> enhancement and prerequisite for HDFS-14403, into branch-2.
> It's only present in trunk now so we also need to backport through the 3.x 
> lines.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org