[jira] [Comment Edited] (HADOOP-7363) TestRawLocalFileSystemContract is needed
[
https://issues.apache.org/jira/browse/HADOOP-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15428366#comment-15428366
]
Anu Engineer edited comment on HADOOP-7363 at 8/19/16 4:33 PM:
---
[~boky01] Thanks for taking time out to explain this to me. Now that I
understand why you are doing this, may I suggest that we re-write that try
catch as a function, something like isS3a(fs) and then the code would look like
if (!isS3a(fs)) {
// assume it is a raw file system
}
I feel that might add more clarity to code rather than just continuing in the
face of an exception, which would make the next developer reading code wonder
if that is a bug.
was (Author: anu):
[~boky01] Thanks for taking time out to explain this to me. Now that I
understand why you are doing this, may I suggest that we re-write that try
catch as a function, something like isS3a(fs) and then the code would look like
if (!isS3a(fs)) {
// assume it is a raw file system
}
I feel that might add more clarity to code rather than just continuing the face
of an exception, which would make the next developer reading code wonder if
that is a bug.
> TestRawLocalFileSystemContract is needed
>
>
> Key: HADOOP-7363
> URL: https://issues.apache.org/jira/browse/HADOOP-7363
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
>Affects Versions: 3.0.0-alpha2
>Reporter: Matt Foley
>Assignee: Andras Bokor
> Attachments: HADOOP-7363.01.patch, HADOOP-7363.02.patch,
> HADOOP-7363.03.patch, HADOOP-7363.04.patch, HADOOP-7363.05.patch
>
>
> FileSystemContractBaseTest is supposed to be run with each concrete
> FileSystem implementation to insure adherence to the "contract" for
> FileSystem behavior. However, currently only HDFS and S3 do so.
> RawLocalFileSystem, at least, needs to be added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-7363) TestRawLocalFileSystemContract is needed
[
https://issues.apache.org/jira/browse/HADOOP-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425447#comment-15425447
]
Anu Engineer edited comment on HADOOP-7363 at 8/17/16 9:49 PM:
---
[~boky01] Thanks for adding this test case. One small comment.
{{FileSystemContractBaseTest.java#Line 181}}: After the {{catch
(UnsupportedOperationException e)}}, we seem to continue. Did you want to abort
the test at that point ?
typo : scema =>schema
was (Author: anu):
[~boky01] Thanks for adding this test case. One small comment.
{{FileSystemContractBaseTest.java#Line 181}}: After the {{catch
(UnsupportedOperationException e)}}, we seem to continue. Did you want to abort
the test at that point ?
> TestRawLocalFileSystemContract is needed
>
>
> Key: HADOOP-7363
> URL: https://issues.apache.org/jira/browse/HADOOP-7363
> Project: Hadoop Common
> Issue Type: Test
> Components: fs
>Affects Versions: 3.0.0-alpha2
>Reporter: Matt Foley
>Assignee: Andras Bokor
> Attachments: HADOOP-7363.01.patch, HADOOP-7363.02.patch,
> HADOOP-7363.03.patch
>
>
> FileSystemContractBaseTest is supposed to be run with each concrete
> FileSystem implementation to insure adherence to the "contract" for
> FileSystem behavior. However, currently only HDFS and S3 do so.
> RawLocalFileSystem, at least, needs to be added.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HADOOP-7363) TestRawLocalFileSystemContract is needed
[ https://issues.apache.org/jira/browse/HADOOP-7363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387426#comment-15387426 ] Andras Bokor edited comment on HADOOP-7363 at 7/21/16 9:26 AM: --- My path does not apply since HADOOP-12709. I am attaching [^HADOOP-7363.02.patch] for rebase. was (Author: boky01): Attach [^HADOOP-7363.02.patch] for rebase. > TestRawLocalFileSystemContract is needed > > > Key: HADOOP-7363 > URL: https://issues.apache.org/jira/browse/HADOOP-7363 > Project: Hadoop Common > Issue Type: Test > Components: fs >Affects Versions: 3.0.0-alpha2 >Reporter: Matt Foley >Assignee: Andras Bokor > Attachments: HADOOP-7363.01.patch, HADOOP-7363.02.patch > > > FileSystemContractBaseTest is supposed to be run with each concrete > FileSystem implementation to insure adherence to the "contract" for > FileSystem behavior. However, currently only HDFS and S3 do so. > RawLocalFileSystem, at least, needs to be added. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
