[
https://issues.apache.org/jira/browse/HADOOP-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662371#comment-13662371
]
Matt Foley edited comment on HADOOP-9573 at 5/20/13 10:01 PM:
--
Exchanged comments with Giri:
bq. What happened to CheckStyle? It looks like it got commented out some time
ago, but why? Or was it entirely replaced by FindBugs?
[~gkesavan]: Nope, we never had checkstyle in test-patch working. Right from
the early days checkstyle function was always commented out,
so this time around I removed it instead of leaving it as a comment. It would
be very painful to implement checkstyle at this point in time,
as making sure hadoop code base is complaint with checkstyle won't be that easy.
was (Author: mattf):
Exchanged comments with Giri:
.bq What happened to CheckStyle? It looks like it got commented out some time
ago, but why? Or was it entirely replaced by FindBugs?
[~gkesavan]: Nope, we never had checkstyle in test-patch working. Right from
the early days checkstyle function was always commented out,
so this time around I removed it instead of leaving it as a comment. It would
be very painful to implement checkstyle at this point in time,
as making sure hadoop code base is complaint with checkstyle won't be that easy.
Fix test-patch script to work with the enhanced PreCommit-Admin script.
---
Key: HADOOP-9573
URL: https://issues.apache.org/jira/browse/HADOOP-9573
Project: Hadoop Common
Issue Type: Sub-task
Components: build
Affects Versions: 1.0.3
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
Attachments:
0001-Fix-test-patch-scrit-to-work-with-the-enhanced-PreCo.patch
test-patch script currently take the latest available patch for a given jira
and performs the test. This jira is to enhance test-patch script to take
attachment-id of a patch as an input and perform the tests using that
attachment-id
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
