[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-09-11 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129861#comment-14129861
 ] 

Hadoop QA commented on HADOOP-10101:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12619314/HADOOP-10101-004.patch
  against trunk revision 4be9517.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4698//console

This message is automatically generated.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-06-19 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14037677#comment-14037677
 ] 

Steve Loughran commented on HADOOP-10101:
-

It would have to be on trunk, guava is a troublespot all round. I'm almost 
tempted to see if we can repimplement the most common uses (checkArguments, 
visibleForTesting, and some of the collections) and pull it out. 

Some of the fixes for 7u55+ changes are only in more recent versions of Guava, 
so the update should follow a java 7 migrate in trunk

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-06-18 Thread Sangjin Lee (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036612#comment-14036612
 ] 

Sangjin Lee commented on HADOOP-10101:
--

+1 on going to guava 17 on the trunk. If we stuck with 15, it would be obsolete 
from the moment when hadoop 3 is released.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-06-18 Thread Alejandro Abdelnur (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036564#comment-14036564
 ] 

Alejandro Abdelnur commented on HADOOP-10101:
-

ok, gr8 we are sync on this going into trunk.

There is another JIRA going on to bump up trunk to jdk1.7.

I think that is related to this as well and we should revive the thread we had 
in dev@ a while ago to come up with a balance on how to move to newer 
components without making it too difficult for backporting things to stable 
releases which cannot move to those new components.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-06-18 Thread Haohui Mai (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036552#comment-14036552
 ] 

Haohui Mai commented on HADOOP-10101:
-

Correct me if I'm wrong, this patch should only be committed to trunk based on 
[~ste...@apache.org]'s comments.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-06-18 Thread Alejandro Abdelnur (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036427#comment-14036427
 ] 

Alejandro Abdelnur commented on HADOOP-10101:
-

[~wheat9], hIf we make this change, per prior discussion in this JIRA (se 
above), it will live only in trunk, correct?

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-06-18 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036317#comment-14036317
 ] 

Hadoop QA commented on HADOOP-10101:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12619314/HADOOP-10101-004.patch
  against trunk revision .

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4096//console

This message is automatically generated.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-06-18 Thread Haohui Mai (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036307#comment-14036307
 ] 

Haohui Mai commented on HADOOP-10101:
-

This patch needs to be rebased, and it is probably okay to move guava towards 
v17.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2014-03-10 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925653#comment-13925653
 ] 

Steve Loughran commented on HADOOP-10101:
-

Guava dependency injection pre v16 has been broken by Java 7u51; as/when google 
backport the fix to the 15.x branch we will need to upgrade -as downstream 
clients will need to do their own fix.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinayakumar B
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-26 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857116#comment-13857116
 ] 

Steve Loughran commented on HADOOP-10101:
-

# yes, this must be a 3.x patch. I'm only putting in low/no risk updates into 
branch-2.
# I would like to identify apps at risk! as otherwise they only know of the 
problem at ship time.
# I mentioned OSGi as you mentioned 'classpath magic'. We don't need more 
magic, and OSGi enabling branch 2 would be transparent to existing apps, while 
isolating new ones from change.
# Shading has its own flaws! including stopping ops teams from auditing and 
updating an installation from a security perspective.



> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-26 Thread Alejandro Abdelnur (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857085#comment-13857085
 ] 

Alejandro Abdelnur commented on HADOOP-10101:
-

You'll only know when you release with Guava 15 and users apps start breaking.

MR jobs can use classloading isolation, yes. But only on the task side and by 
default is OFF.

OSGi requires changes in existing apps.

My point is, and I think you agree, we cannot do this in 2.x timeframe.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-26 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13857077#comment-13857077
 ] 

Steve Loughran commented on HADOOP-10101:
-

-yes, but which apps are they? As I don't want us to be constrained fir 
theoretical reasons.
-MR jobs can already override classloaders
-there's some OSGi JIRAs, which won't break compatibility as they only declare 
what is exported. Once we have them in, downstream apps than want isolation can 
use OSGi classloaders with having to try to roll their own solutions


> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-26 Thread Alejandro Abdelnur (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856984#comment-13856984
 ] 

Alejandro Abdelnur commented on HADOOP-10101:
-

bq. #2, if somebody is using the same Guava classes that break HDFS.

bq. #3, we should figure this out somehow, either using classloader magic or 
shading to hide all 3rd party dep JARs from the user space. But this is a 3.x 
timeframe thing.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-26 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13856981#comment-13856981
 ] 

Steve Loughran commented on HADOOP-10101:
-

# marked the patch as targeting 3.0
# are there any specific applications which you know will break! or is this 
just a theoretical concern?
# I did write a section on dependency compatibility for the docs, precisely 
baca use they are visible. It comes down to "there are no guarantees"

Pint #3 doesn't mean that we should push this in to branch 2, just that we 
explicitly state that we don't make any guarantees about dependency 
compatibility -I'd we did we would never be able to upgrade anything

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-23 Thread Alejandro Abdelnur (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855972#comment-13855972
 ] 

Alejandro Abdelnur commented on HADOOP-10101:
-

Because 3rd party Hadoop dependencies leak to the client and apps, this is an 
incompatible change (Guava 15 removed some classes). This may affect 
applications that use those classes avail in older versions of Guava. 

IMO, we have to wait till Hadoop 3 for this change. Plus, we should add this to 
the compat guidelines.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-18 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851896#comment-13851896
 ] 

Hadoop QA commented on HADOOP-10101:


{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12619314/HADOOP-10101-004.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3368//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3368//console

This message is automatically generated.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-18 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851879#comment-13851879
 ] 

Hadoop QA commented on HADOOP-10101:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12617772/HADOOP-10101.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

  
org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3367//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3367//console

This message is automatically generated.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101-004.patch, 
> HADOOP-10101.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-08 Thread Vinay (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842852#comment-13842852
 ] 

Vinay commented on HADOOP-10101:


Hi [~ste...@apache.org], Could you take a look at changes...?
Thanks,

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
>Assignee: Vinay
> Attachments: HADOOP-10101-002.patch, HADOOP-10101.patch, 
> HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-06 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841432#comment-13841432
 ] 

Steve Loughran commented on HADOOP-10101:
-

I'm happy for you to take it up!

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
> Attachments: HADOOP-10101-002.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-12-06 Thread Vinay (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841134#comment-13841134
 ] 

Vinay commented on HADOOP-10101:


Any update on this Jira? 
If no objection, I would like to take-up and replace all deprecated with their 
successors..

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
> Attachments: HADOOP-10101-002.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-11-15 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823585#comment-13823585
 ] 

Steve Loughran commented on HADOOP-10101:
-

Deprecation warnings of
* com.google.common.collect.ComparisonChain
* com.google.common.base.Stopwatch

Replacing them with their successors would change more code but reduce the 
effort on the next guava update, when perhaps these files go away completely
{code}
291a292
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionUtil.java:[112,6]
>  [deprecation] compare(boolean,boolean) in 
> com.google.common.collect.ComparisonChain has been deprecated
293a295,296
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java:[156,21]
>  [deprecation] Stopwatch() in com.google.common.base.Stopwatch has been 
> deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java:[165,32]
>  [deprecation] elapsedMillis() in com.google.common.base.Stopwatch has been 
> deprecated
432a436,439
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java:[372,19]
>  [deprecation] Stopwatch() in com.google.common.base.Stopwatch has been 
> deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java:[377,22]
>  [deprecation] elapsedTime(java.util.concurrent.TimeUnit) in 
> com.google.common.base.Stopwatch has been deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java:[378,10]
>  [deprecation] elapsedTime(java.util.concurrent.TimeUnit) in 
> com.google.common.base.Stopwatch has been deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java:[380,28]
>  [deprecation] elapsedTime(java.util.concurrent.TimeUnit) in 
> com.google.common.base.Stopwatch has been deprecated
435a443,444
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java:[133,45]
>  [deprecation] Stopwatch() in com.google.common.base.Stopwatch has been 
> deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java:[437,30]
>  [deprecation] elapsedMillis() in com.google.common.base.Stopwatch has been 
> deprecated
437a447,448
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java:[330,19]
>  [deprecation] Stopwatch() in com.google.common.base.Stopwatch has been 
> deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/qjournal/server/TestJournalNode.java:[334,18]
>  [deprecation] elapsedMillis() in com.google.common.base.Stopwatch has been 
> deprecated
438a450,453
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java:[103,21]
>  [deprecation] Stopwatch() in com.google.common.base.Stopwatch has been 
> deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java:[106,22]
>  [deprecation] elapsedTime(java.util.concurrent.TimeUnit) in 
> com.google.common.base.Stopwatch has been deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java:[279,21]
>  [deprecation] Stopwatch() in com.google.common.base.Stopwatch has been 
> deprecated
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestMultiThreadedHflush.java:[284,44]
>  [deprecation] elapsedMillis() in com.google.common.base.Stopwatch has been 
> deprecated
447a463,466
> [WARNING] 
> /home/jenkins/jenkins-slave/workspace/PreCom

[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-11-15 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823570#comment-13823570
 ] 

Steve Loughran commented on HADOOP-10101:
-

Link to HDFS-5518: the test/review side of the HDFS patch

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
> Attachments: HADOOP-10101-002.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-11-14 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822857#comment-13822857
 ] 

Hadoop QA commented on HADOOP-10101:


{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12613889/HADOOP-10101-002.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

  {color:red}-1 javac{color}.  The applied patch generated 1565 javac 
compiler warnings (more than the trunk's current 1546 warnings).

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3287//testReport/
Javac warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3287//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3287//console

This message is automatically generated.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.2.0
>Reporter: Rakesh R
> Attachments: HADOOP-10101-002.patch, HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-11-14 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822687#comment-13822687
 ] 

Steve Loughran commented on HADOOP-10101:
-

problem HBase had that also arose in 
{{hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDataTransferKeepalive.java}}

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Rakesh R
> Attachments: HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-11-14 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822672#comment-13822672
 ] 

Steve Loughran commented on HADOOP-10101:
-

hdfs stops compiling with this patch
{code}
hadoop-trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java:[68,32]
 error: cannot find symbol
[ERROR] symbol:   class Ranges

{code}

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Rakesh R
> Attachments: HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-11-14 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822519#comment-13822519
 ] 

Steve Loughran commented on HADOOP-10101:
-

-though as the only place @Nullable is used in the entire Hadoop codebase is 
apparently {{TestMetricsSystemImpl}}, HADOOP-10067 will have fixed it.

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Rakesh R
> Attachments: HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (HADOOP-10101) Update guava dependency to the latest version 15.0

2013-11-14 Thread Steve Loughran (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822516#comment-13822516
 ] 

Steve Loughran commented on HADOOP-10101:
-

This update will remove the {{@Nullable}} attribute from jsr305, which may 
propagate through the code

> Update guava dependency to the latest version 15.0
> --
>
> Key: HADOOP-10101
> URL: https://issues.apache.org/jira/browse/HADOOP-10101
> Project: Hadoop Common
>  Issue Type: Improvement
>Reporter: Rakesh R
> Attachments: HADOOP-10101.patch
>
>
> The existing guava version is 11.0.2 which is quite old. This 



--
This message was sent by Atlassian JIRA
(v6.1#6144)