[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[ https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052459#comment-14052459 ] Hudson commented on HADOOP-10312: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1794 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1794/]) HADOOP-10312 changes.text updated in wrong place (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607631) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt > Shell.ExitCodeException to have more useful toString > > > Key: HADOOP-10312 > URL: https://issues.apache.org/jira/browse/HADOOP-10312 > Project: Hadoop Common > Issue Type: Bug > Components: util >Affects Versions: 2.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: 2.5.0 > > Attachments: HADOOP-10312-001.patch, HADOOP-10312-002.patch > > > Shell's ExitCodeException doesn't include the exit code in the toString > value, so isn't that useful in diagnosing container start failures in YARN -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[ https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052358#comment-14052358 ] Hudson commented on HADOOP-10312: - FAILURE: Integrated in Hadoop-Yarn-trunk #603 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/603/]) HADOOP-10312 changes.text updated in wrong place (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607631) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-10312 Shell.ExitCodeException to have more useful toString (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607591) * /hadoop/common/trunk * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java > Shell.ExitCodeException to have more useful toString > > > Key: HADOOP-10312 > URL: https://issues.apache.org/jira/browse/HADOOP-10312 > Project: Hadoop Common > Issue Type: Bug > Components: util >Affects Versions: 2.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: 2.5.0 > > Attachments: HADOOP-10312-001.patch, HADOOP-10312-002.patch > > > Shell's ExitCodeException doesn't include the exit code in the toString > value, so isn't that useful in diagnosing container start failures in YARN -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[ https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051563#comment-14051563 ] Hudson commented on HADOOP-10312: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1820 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1820/]) HADOOP-10312 changes.text updated in wrong place (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607631) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-10312 Shell.ExitCodeException to have more useful toString (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607591) * /hadoop/common/trunk * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java > Shell.ExitCodeException to have more useful toString > > > Key: HADOOP-10312 > URL: https://issues.apache.org/jira/browse/HADOOP-10312 > Project: Hadoop Common > Issue Type: Bug > Components: util >Affects Versions: 2.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: 2.5.0 > > Attachments: HADOOP-10312-001.patch, HADOOP-10312-002.patch > > > Shell's ExitCodeException doesn't include the exit code in the toString > value, so isn't that useful in diagnosing container start failures in YARN -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[ https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051468#comment-14051468 ] Hudson commented on HADOOP-10312: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1793 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1793/]) HADOOP-10312 Shell.ExitCodeException to have more useful toString (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607591) * /hadoop/common/trunk * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java > Shell.ExitCodeException to have more useful toString > > > Key: HADOOP-10312 > URL: https://issues.apache.org/jira/browse/HADOOP-10312 > Project: Hadoop Common > Issue Type: Bug > Components: util >Affects Versions: 2.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: 2.5.0 > > Attachments: HADOOP-10312-001.patch, HADOOP-10312-002.patch > > > Shell's ExitCodeException doesn't include the exit code in the toString > value, so isn't that useful in diagnosing container start failures in YARN -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[ https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051417#comment-14051417 ] Hudson commented on HADOOP-10312: - SUCCESS: Integrated in Hadoop-trunk-Commit #5820 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5820/]) HADOOP-10312 changes.text updated in wrong place (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607631) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt > Shell.ExitCodeException to have more useful toString > > > Key: HADOOP-10312 > URL: https://issues.apache.org/jira/browse/HADOOP-10312 > Project: Hadoop Common > Issue Type: Bug > Components: util >Affects Versions: 2.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: 2.5.0 > > Attachments: HADOOP-10312-001.patch, HADOOP-10312-002.patch > > > Shell's ExitCodeException doesn't include the exit code in the toString > value, so isn't that useful in diagnosing container start failures in YARN -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[ https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051349#comment-14051349 ] Hudson commented on HADOOP-10312: - SUCCESS: Integrated in Hadoop-trunk-Commit #5817 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5817/]) HADOOP-10312 Shell.ExitCodeException to have more useful toString (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1607591) * /hadoop/common/trunk * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Shell.java > Shell.ExitCodeException to have more useful toString > > > Key: HADOOP-10312 > URL: https://issues.apache.org/jira/browse/HADOOP-10312 > Project: Hadoop Common > Issue Type: Bug > Components: util >Affects Versions: 2.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Fix For: 2.5.0 > > Attachments: HADOOP-10312-001.patch, HADOOP-10312-002.patch > > > Shell's ExitCodeException doesn't include the exit code in the toString > value, so isn't that useful in diagnosing container start failures in YARN -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[
https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038265#comment-14038265
]
Hadoop QA commented on HADOOP-10312:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651557/HADOOP-10312-002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4116//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4116//console
This message is automatically generated.
> Shell.ExitCodeException to have more useful toString
>
>
> Key: HADOOP-10312
> URL: https://issues.apache.org/jira/browse/HADOOP-10312
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
>Affects Versions: 2.4.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-10312-001.patch, HADOOP-10312-002.patch
>
>
> Shell's ExitCodeException doesn't include the exit code in the toString
> value, so isn't that useful in diagnosing container start failures in YARN
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[ https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038097#comment-14038097 ] Chris Nauroth commented on HADOOP-10312: bq. -1 tests included. The patch doesn't appear to include any new or modified tests. This patch doesn't require a test, IMO. > Shell.ExitCodeException to have more useful toString > > > Key: HADOOP-10312 > URL: https://issues.apache.org/jira/browse/HADOOP-10312 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Steve Loughran >Assignee: Steve Loughran >Priority: Minor > Attachments: HADOOP-10312-001.patch > > > Shell's ExitCodeException doesn't include the exit code in the toString > value, so isn't that useful in diagnosing container start failures in YARN -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[
https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038096#comment-14038096
]
Hadoop QA commented on HADOOP-10312:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651542/HADOOP-10312-001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4110//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4110//console
This message is automatically generated.
> Shell.ExitCodeException to have more useful toString
>
>
> Key: HADOOP-10312
> URL: https://issues.apache.org/jira/browse/HADOOP-10312
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-10312-001.patch
>
>
> Shell's ExitCodeException doesn't include the exit code in the toString
> value, so isn't that useful in diagnosing container start failures in YARN
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[
https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038054#comment-14038054
]
Chris Nauroth commented on HADOOP-10312:
I'm in favor of making {{exitCode}} private. I looked back on HADOOP-2512,
which introduced this exception class. There doesn't appear to be any
historical reason that it needs to be package-private.
> Shell.ExitCodeException to have more useful toString
>
>
> Key: HADOOP-10312
> URL: https://issues.apache.org/jira/browse/HADOOP-10312
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Steve Loughran
>Assignee: Steve Loughran
>Priority: Minor
> Attachments: HADOOP-10312-001.patch
>
>
> Shell's ExitCodeException doesn't include the exit code in the toString
> value, so isn't that useful in diagnosing container start failures in YARN
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[ https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887921#comment-13887921 ] Chris Nauroth commented on HADOOP-10312: I've always wanted it to be easier to capture stdout/stderr from failed external commands too. It could be potentially spammy though, so maybe it would need to go behind debug log level somehow. If you want to keep the scope of this issue to just the exit code, please go ahead, and I'll file a separate issue related to capturing stdout/stderr. > Shell.ExitCodeException to have more useful toString > > > Key: HADOOP-10312 > URL: https://issues.apache.org/jira/browse/HADOOP-10312 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.4.0 >Reporter: Steve Loughran >Priority: Minor > > Shell's ExitCodeException doesn't include the exit code in the toString > value, so isn't that useful in diagnosing container start failures in YARN -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (HADOOP-10312) Shell.ExitCodeException to have more useful toString
[
https://issues.apache.org/jira/browse/HADOOP-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13886610#comment-13886610
]
Steve Loughran commented on HADOOP-10312:
-
Example
{code}
2014-01-30 14:20:12,042 [AMRM Callback Handler Thread] INFO HoyaAppMaster.yarn
(HoyaAppMaster.java:onContainersCompleted(839)) - Container Completion for
containerID=container_1391075472386_0004_01_32, state=COMPLETE,
exitStatus=1, diagnostics=Exception from container-launch:
org.apache.hadoop.util.Shell$ExitCodeException:
org.apache.hadoop.util.Shell$ExitCodeException:
at org.apache.hadoop.util.Shell.runCommand(Shell.java:505)
at org.apache.hadoop.util.Shell.run(Shell.java:418)
at
org.apache.hadoop.util.Shell$ShellCommandExecutor.execute(Shell.java:650)
at
org.apache.hadoop.yarn.server.nodemanager.DefaultContainerExecutor.launchContainer(DefaultContainerExecutor.java:195)
at
org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:283)
at
org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch.call(ContainerLaunch.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:744)
{code}
it failed, but it's not obvious why
> Shell.ExitCodeException to have more useful toString
>
>
> Key: HADOOP-10312
> URL: https://issues.apache.org/jira/browse/HADOOP-10312
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.4.0
>Reporter: Steve Loughran
>Priority: Minor
>
> Shell's ExitCodeException doesn't include the exit code in the toString
> value, so isn't that useful in diagnosing container start failures in YARN
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
