[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014611#comment-14014611 ] Hudson commented on HADOOP-10611: - FAILURE: Integrated in Hadoop-Yarn-trunk #569 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/569/]) HADOOP-10611. KMS, keyVersion name should not be assumed to be keyName@versionNumber. (tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1598775) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java * /hadoop/common/trunk/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSCacheKeyProvider.java * /hadoop/common/trunk/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Fix For: 3.0.0 Attachments: HADOOP-10611.patch Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014652#comment-14014652 ] Hudson commented on HADOOP-10611: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1760 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1760/]) HADOOP-10611. KMS, keyVersion name should not be assumed to be keyName@versionNumber. (tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1598775) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java * /hadoop/common/trunk/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSCacheKeyProvider.java * /hadoop/common/trunk/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Fix For: 3.0.0 Attachments: HADOOP-10611.patch Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014682#comment-14014682 ] Hudson commented on HADOOP-10611: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1787 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1787/]) HADOOP-10611. KMS, keyVersion name should not be assumed to be keyName@versionNumber. (tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1598775) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java * /hadoop/common/trunk/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSCacheKeyProvider.java * /hadoop/common/trunk/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Fix For: 3.0.0 Attachments: HADOOP-10611.patch Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014198#comment-14014198 ] Alejandro Abdelnur commented on HADOOP-10611: - Changed the scope of this JIRA to the KMS classes. KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[
https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014229#comment-14014229
]
Andrew Wang commented on HADOOP-10611:
--
I'd like if we tackled this for the common classes too for consistency. It'd be
nice to do something like make {{buildVersionName}} abstract and provide the
current impl as a static helper in e.g. {{KeyProviderUtils}} as Tucu proposed.
I'm not sure exactly what method signature these third-party key providers need
though. Is there a JIRA for this?
+1 for the KMS side stuff though, this part at least looks good.
KMS, keyVersion name should not be assumed to be keyName@versionNumber
--
Key: HADOOP-10611
URL: https://issues.apache.org/jira/browse/HADOOP-10611
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 3.0.0
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
Attachments: HADOOP-10611.patch
Some KMS classes are assuming the keyVersion is keyName@versionNumber.
The keyVersion should be handled as an opaque value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014235#comment-14014235 ] Alejandro Abdelnur commented on HADOOP-10611: - [~andrew.wang], how about tackling that in a diff JIRA? KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Attachments: HADOOP-10611.patch Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014240#comment-14014240 ] Andrew Wang commented on HADOOP-10611: -- Yea totally, I think we're good on this one as soon as Jenkins come back. If you can file a follow-on that'd be swell. KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Attachments: HADOOP-10611.patch Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[
https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014259#comment-14014259
]
Hadoop QA commented on HADOOP-10611:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647681/HADOOP-10611.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms:
org.apache.hadoop.crypto.key.kms.server.TestKMS
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3986//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3986//console
This message is automatically generated.
KMS, keyVersion name should not be assumed to be keyName@versionNumber
--
Key: HADOOP-10611
URL: https://issues.apache.org/jira/browse/HADOOP-10611
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 3.0.0
Reporter: Alejandro Abdelnur
Assignee: Alejandro Abdelnur
Attachments: HADOOP-10611.patch
Some KMS classes are assuming the keyVersion is keyName@versionNumber.
The keyVersion should be handled as an opaque value.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014340#comment-14014340 ] Alejandro Abdelnur commented on HADOOP-10611: - the failure is unrelated to this JIRA, is because a race condition in the testcase while modifying a hot-reloadable config file, opened HADOOP-10645 to fix it. KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Attachments: HADOOP-10611.patch Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014348#comment-14014348 ] Alejandro Abdelnur commented on HADOOP-10611: - Created HADOOP-10646 to move buildVersionName() to a util class. KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Fix For: 3.0.0 Attachments: HADOOP-10611.patch Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10611) KMS, keyVersion name should not be assumed to be keyName@versionNumber
[ https://issues.apache.org/jira/browse/HADOOP-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14014358#comment-14014358 ] Hudson commented on HADOOP-10611: - SUCCESS: Integrated in Hadoop-trunk-Commit #5636 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/5636/]) HADOOP-10611. KMS, keyVersion name should not be assumed to be keyName@versionNumber. (tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1598775) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/kms/KMSClientProvider.java * /hadoop/common/trunk/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSCacheKeyProvider.java * /hadoop/common/trunk/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java KMS, keyVersion name should not be assumed to be keyName@versionNumber -- Key: HADOOP-10611 URL: https://issues.apache.org/jira/browse/HADOOP-10611 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 3.0.0 Reporter: Alejandro Abdelnur Assignee: Alejandro Abdelnur Fix For: 3.0.0 Attachments: HADOOP-10611.patch Some KMS classes are assuming the keyVersion is keyName@versionNumber. The keyVersion should be handled as an opaque value. -- This message was sent by Atlassian JIRA (v6.2#6252)
