[jira] [Commented] (HADOOP-10633) use Time#monotonicNow to avoid system clock reset
[
https://issues.apache.org/jira/browse/HADOOP-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17307770#comment-17307770
]
Hadoop QA commented on HADOOP-10633:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Logfile || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue}{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m
4s{color} | {color:blue}{color} | {color:blue} The patch file was not named
according to hadoop's naming conventions. Please see
https://wiki.apache.org/hadoop/HowToContribute for instructions. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 9s{color}
| {color:red}{color} | {color:red} HADOOP-10633 does not apply to trunk. Rebase
required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HADOOP-10633 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12647069/HADOOP-10633.txt |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-HADOOP-Build/168/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
> use Time#monotonicNow to avoid system clock reset
> -
>
> Key: HADOOP-10633
> URL: https://issues.apache.org/jira/browse/HADOOP-10633
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io, security
>Affects Versions: 3.0.0-alpha1
>Reporter: Liang Xie
>Assignee: Liang Xie
>Priority: Major
> Labels: BB2015-05-TBR
> Attachments: HADOOP-10633.txt
>
>
> let's replace System#currentTimeMillis with Time#monotonicNow
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-10633) use Time#monotonicNow to avoid system clock reset
[ https://issues.apache.org/jira/browse/HADOOP-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741174#comment-14741174 ] Steve Loughran commented on HADOOP-10633: - Actually, it'd have to be -1 to using monotonic now for tokens. If I set the time on a machine back, I'd expect new tokens to have an expiry time relative to the new time; use monotonic time and they'd be valid for longer than you expect > use Time#monotonicNow to avoid system clock reset > - > > Key: HADOOP-10633 > URL: https://issues.apache.org/jira/browse/HADOOP-10633 > Project: Hadoop Common > Issue Type: Improvement > Components: io, security >Affects Versions: 3.0.0 >Reporter: Liang Xie >Assignee: Liang Xie > Labels: BB2015-05-TBR > Attachments: HADOOP-10633.txt > > > let's replace System#currentTimeMillis with Time#monotonicNow -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-10633) use Time#monotonicNow to avoid system clock reset
[
https://issues.apache.org/jira/browse/HADOOP-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741168#comment-14741168
]
Steve Loughran commented on HADOOP-10633:
-
Just reviewed this: I agreee with Andrew. {{AbstractService}} is only
recording the events for forwarding to others, so doesn't need to change, but
then: "probably" doesn't suffer. I don't know about the tokens.
Andrew: if you are happy with the NativeIO one —why not just check that bit in?
> use Time#monotonicNow to avoid system clock reset
> -
>
> Key: HADOOP-10633
> URL: https://issues.apache.org/jira/browse/HADOOP-10633
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io, security
>Affects Versions: 3.0.0
>Reporter: Liang Xie
>Assignee: Liang Xie
> Labels: BB2015-05-TBR
> Attachments: HADOOP-10633.txt
>
>
> let's replace System#currentTimeMillis with Time#monotonicNow
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-10633) use Time#monotonicNow to avoid system clock reset
[
https://issues.apache.org/jira/browse/HADOOP-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14741270#comment-14741270
]
Hadoop QA commented on HADOOP-10633:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | patch | 0m 1s | The patch file was not named
according to hadoop's naming conventions. Please see
https://wiki.apache.org/hadoop/HowToContribute for instructions. |
| {color:red}-1{color} | patch | 0m 1s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12647069/HADOOP-10633.txt |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 15a557f |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7645/console |
This message was automatically generated.
> use Time#monotonicNow to avoid system clock reset
> -
>
> Key: HADOOP-10633
> URL: https://issues.apache.org/jira/browse/HADOOP-10633
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io, security
>Affects Versions: 3.0.0
>Reporter: Liang Xie
>Assignee: Liang Xie
> Labels: BB2015-05-TBR
> Attachments: HADOOP-10633.txt
>
>
> let's replace System#currentTimeMillis with Time#monotonicNow
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-10633) use Time#monotonicNow to avoid system clock reset
[ https://issues.apache.org/jira/browse/HADOOP-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012924#comment-14012924 ] Andrew Wang commented on HADOOP-10633: -- Hey [~xieliang007], thanks for working on this. I think we need to be a careful with some of these swaps though: - NoCacheFilter, HTTP is supposed to have actual dates, not monotonic ones, I think it's so e.g. caching proxies know when to expire things. - AbstractService, I think startTime might be displayed somewhere, so I'd rather not change this either - ADTSM, tokens are passed around between services, so again I think need to be real dates NativeIO though looks like a valid swap, so maybe we just do that one? Thanks man. use Time#monotonicNow to avoid system clock reset - Key: HADOOP-10633 URL: https://issues.apache.org/jira/browse/HADOOP-10633 Project: Hadoop Common Issue Type: Improvement Components: io, security Affects Versions: 3.0.0 Reporter: Liang Xie Assignee: Liang Xie Attachments: HADOOP-10633.txt let's replace System#currentTimeMillis with Time#monotonicNow -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-10633) use Time#monotonicNow to avoid system clock reset
[
https://issues.apache.org/jira/browse/HADOOP-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14010866#comment-14010866
]
Hadoop QA commented on HADOOP-10633:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647069/HADOOP-10633.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3978//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3978//console
This message is automatically generated.
use Time#monotonicNow to avoid system clock reset
-
Key: HADOOP-10633
URL: https://issues.apache.org/jira/browse/HADOOP-10633
Project: Hadoop Common
Issue Type: Improvement
Components: io, security
Affects Versions: 3.0.0
Reporter: Liang Xie
Assignee: Liang Xie
Attachments: HADOOP-10633.txt
let's replace System#currentTimeMillis with Time#monotonicNow
--
This message was sent by Atlassian JIRA
(v6.2#6252)
