[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137260#comment-14137260 ] Hudson commented on HADOOP-11055: - FAILURE: Integrated in Hadoop-Hdfs-trunk #1874 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1874/]) HADOOP-11055. non-daemon pid files are missing (aw) (aw: rev ffdb7eb3b256c8e064948a962aa07e2e276889c5) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HADOOP-11055-01.patch, HADOOP-11055.patch > > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137233#comment-14137233 ] Hudson commented on HADOOP-11055: - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1899 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1899/]) HADOOP-11055. non-daemon pid files are missing (aw) (aw: rev ffdb7eb3b256c8e064948a962aa07e2e276889c5) * hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh * hadoop-common-project/hadoop-common/CHANGES.txt > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HADOOP-11055-01.patch, HADOOP-11055.patch > > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137082#comment-14137082 ] Hudson commented on HADOOP-11055: - SUCCESS: Integrated in Hadoop-Yarn-trunk #683 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/683/]) HADOOP-11055. non-daemon pid files are missing (aw) (aw: rev ffdb7eb3b256c8e064948a962aa07e2e276889c5) * hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh * hadoop-common-project/hadoop-common/CHANGES.txt > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HADOOP-11055-01.patch, HADOOP-11055.patch > > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[
https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136350#comment-14136350
]
Hadoop QA commented on HADOOP-11055:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12669202/HADOOP-11055-01.patch
against trunk revision 56119fe.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-common-project/hadoop-common:
org.apache.hadoop.security.token.delegation.web.TestWebDelegationToken
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4739//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4739//console
This message is automatically generated.
> non-daemon pid files are missing
>
>
> Key: HADOOP-11055
> URL: https://issues.apache.org/jira/browse/HADOOP-11055
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Fix For: 3.0.0
>
> Attachments: HADOOP-11055-01.patch, HADOOP-11055.patch
>
>
> Somewhere along the way, daemons run in default mode lost pid files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136172#comment-14136172 ] Owen O'Malley commented on HADOOP-11055: +1 looks good, Allen. > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-11055.patch > > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[
https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132165#comment-14132165
]
Hadoop QA commented on HADOOP-11055:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12668452/HADOOP-11055.patch
against trunk revision 54e5794.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4706//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4706//console
This message is automatically generated.
> non-daemon pid files are missing
>
>
> Key: HADOOP-11055
> URL: https://issues.apache.org/jira/browse/HADOOP-11055
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
>Reporter: Allen Wittenauer
>Assignee: Allen Wittenauer
>Priority: Blocker
> Attachments: HADOOP-11055.patch
>
>
> Somewhere along the way, daemons run in default mode lost pid files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132097#comment-14132097 ] Allen Wittenauer commented on HADOOP-11055: --- Playing around, the $$ inside the &'d process is wrong for the daemonization case during the pid write. So [~pocky], we were both wrong after some experimentation! :D > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-11055.patch > > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123276#comment-14123276 ] Allen Wittenauer commented on HADOOP-11055: --- Yup, you are absolutely correct. There's no point in keeping the pid write after the fork since it should write the exact same info anyway. > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Priority: Blocker > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123065#comment-14123065 ] John Smith commented on HADOOP-11055: - Isn't it safe to write the pid file inside the hadoop_start_daemon function since that is the process id of the pid file? > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Priority: Blocker > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119050#comment-14119050 ] Allen Wittenauer commented on HADOOP-11055: --- It's worth noting that _wrapper should keep its pid code since we are forking the java bit. This will replace that pid with the forked one. > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Priority: Blocker > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11055) non-daemon pid files are missing
[ https://issues.apache.org/jira/browse/HADOOP-11055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119047#comment-14119047 ] Allen Wittenauer commented on HADOOP-11055: --- OK, this appears to be fairly easy to solve. The big thing is that the pid file var needs to get sent to start_daemon so that it can write the pid file *before* launching java. The exec will replace the running process with the java, but the pid should not change. This, however, means breaking/updating the params that get sent to start_daemon. Since this is an unreleased version, not a big deal. > non-daemon pid files are missing > > > Key: HADOOP-11055 > URL: https://issues.apache.org/jira/browse/HADOOP-11055 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Allen Wittenauer >Priority: Blocker > > Somewhere along the way, daemons run in default mode lost pid files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
