[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381745#comment-14381745
]
Hudson commented on HADOOP-11524:
-
FAILURE: Integrated in Hadoop-Yarn-trunk #878 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/878/])
HADOOP-11524. hadoop_do_classpath_subcommand throws a shellcheck warning.
Contributed by Chris Nauroth. (cnauroth: rev
4528eb9fb2e1a99c985926eacb3450b806ea6b4f)
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-mapreduce-project/bin/mapred
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-yarn-project/hadoop-yarn/bin/yarn
* hadoop-common-project/hadoop-common/CHANGES.txt
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.0.0
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381734#comment-14381734
]
Hudson commented on HADOOP-11524:
-
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #144 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/144/])
HADOOP-11524. hadoop_do_classpath_subcommand throws a shellcheck warning.
Contributed by Chris Nauroth. (cnauroth: rev
4528eb9fb2e1a99c985926eacb3450b806ea6b4f)
* hadoop-mapreduce-project/bin/mapred
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-yarn-project/hadoop-yarn/bin/yarn
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.0.0
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381855#comment-14381855
]
Hudson commented on HADOOP-11524:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #144 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/144/])
HADOOP-11524. hadoop_do_classpath_subcommand throws a shellcheck warning.
Contributed by Chris Nauroth. (cnauroth: rev
4528eb9fb2e1a99c985926eacb3450b806ea6b4f)
* hadoop-mapreduce-project/bin/mapred
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-yarn-project/hadoop-yarn/bin/yarn
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.0.0
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381876#comment-14381876
]
Hudson commented on HADOOP-11524:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2094 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2094/])
HADOOP-11524. hadoop_do_classpath_subcommand throws a shellcheck warning.
Contributed by Chris Nauroth. (cnauroth: rev
4528eb9fb2e1a99c985926eacb3450b806ea6b4f)
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-yarn-project/hadoop-yarn/bin/yarn
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-mapreduce-project/bin/mapred
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.0.0
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381960#comment-14381960
]
Hudson commented on HADOOP-11524:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #135 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/135/])
HADOOP-11524. hadoop_do_classpath_subcommand throws a shellcheck warning.
Contributed by Chris Nauroth. (cnauroth: rev
4528eb9fb2e1a99c985926eacb3450b806ea6b4f)
* hadoop-mapreduce-project/bin/mapred
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-yarn-project/hadoop-yarn/bin/yarn
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.0.0
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381951#comment-14381951
]
Hudson commented on HADOOP-11524:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk #2076 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2076/])
HADOOP-11524. hadoop_do_classpath_subcommand throws a shellcheck warning.
Contributed by Chris Nauroth. (cnauroth: rev
4528eb9fb2e1a99c985926eacb3450b806ea6b4f)
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
* hadoop-yarn-project/hadoop-yarn/bin/yarn
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-mapreduce-project/bin/mapred
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.0.0
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14381404#comment-14381404
]
Hudson commented on HADOOP-11524:
-
FAILURE: Integrated in Hadoop-trunk-Commit #7437 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7437/])
HADOOP-11524. hadoop_do_classpath_subcommand throws a shellcheck warning.
Contributed by Chris Nauroth. (cnauroth: rev
4528eb9fb2e1a99c985926eacb3450b806ea6b4f)
* hadoop-yarn-project/hadoop-yarn/bin/yarn
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
* hadoop-mapreduce-project/bin/mapred
* hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
* hadoop-common-project/hadoop-common/src/main/bin/hadoop
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Fix For: 3.0.0
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378835#comment-14378835
]
Hadoop QA commented on HADOOP-11524:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12706969/HADOOP-11524.001.patch
against trunk revision a16bfff.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.balancer.TestBalancer
org.apache.hadoop.hdfs.server.namenode.TestFsck
org.apache.hadoop.tracing.TestTracing
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5988//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5988//console
This message is automatically generated.
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378671#comment-14378671
]
Allen Wittenauer commented on HADOOP-11524:
---
+1 lgtm. Probably a better API this way too.
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
Attachments: HADOOP-11524.001.patch
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297677#comment-14297677
]
Allen Wittenauer commented on HADOOP-11524:
---
Not a big deal. I should spend some time trying to figure out how to add
shellcheck to the test-patch bits.
hadoop_do_classpath_subcommand throws a shellcheck warning
--
Key: HADOOP-11524
URL: https://issues.apache.org/jira/browse/HADOOP-11524
Project: Hadoop Common
Issue Type: Improvement
Components: scripts
Affects Versions: 3.0.0
Reporter: Allen Wittenauer
Assignee: Chris Nauroth
Priority: Minor
{code}
CLASS=org.apache.hadoop.util.Classpath
^-- SC2034: CLASS appears unused. Verify it or export it.
{code}
We should probably use a local var here and return it or something, even
though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
