[jira] [Commented] (HADOOP-11526) Memory leak in Bzip2Decompressor
[
https://issues.apache.org/jira/browse/HADOOP-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14306488#comment-14306488
]
Hadoop QA commented on HADOOP-11526:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12696628/HADOOP-11526.002.patch
against trunk revision 43d5cae.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5589//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5589//console
This message is automatically generated.
Memory leak in Bzip2Decompressor
Key: HADOOP-11526
URL: https://issues.apache.org/jira/browse/HADOOP-11526
Project: Hadoop Common
Issue Type: Bug
Components: io, native
Affects Versions: 2.6.0
Reporter: Ian Rogers
Assignee: Anu Engineer
Attachments: HADOOP-11526.001.patch, HADOOP-11526.002.patch
The use of JNI's GetStringUTFChars should be paired with
ReleaseStringUTFChars or else the utf-8 char* created by Java's JNI
implementation is leaked. It isn't in Bzip2Decompressor.c:
https://apache.googlesource.com/hadoop-common/+/refs/heads/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/bzip2/Bzip2Decompressor.c#45
A less error-prone way of handling JNI resources like local references and
UTF strings is to use a smart pointer like the Apache licensed code in
Android's ScopedLocalRef and ScopedUtfChars:
https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedLocalRef.h
https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedUtfChars.h
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11526) Memory leak in Bzip2Decompressor
[
https://issues.apache.org/jira/browse/HADOOP-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304409#comment-14304409
]
Hadoop QA commented on HADOOP-11526:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12696315/HADOOP-11526.001.patch
against trunk revision b73e776.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5572//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5572//console
This message is automatically generated.
Memory leak in Bzip2Decompressor
Key: HADOOP-11526
URL: https://issues.apache.org/jira/browse/HADOOP-11526
Project: Hadoop Common
Issue Type: Bug
Components: io
Reporter: Ian Rogers
Assignee: Anu Engineer
Attachments: HADOOP-11526.001.patch
The use of JNI's GetStringUTFChars should be paired with
ReleaseStringUTFChars or else the utf-8 char* created by Java's JNI
implementation is leaked. It isn't in Bzip2Decompressor.c:
https://apache.googlesource.com/hadoop-common/+/refs/heads/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/bzip2/Bzip2Decompressor.c#45
A less error-prone way of handling JNI resources like local references and
UTF strings is to use a smart pointer like the Apache licensed code in
Android's ScopedLocalRef and ScopedUtfChars:
https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedLocalRef.h
https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedUtfChars.h
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11526) Memory leak in Bzip2Decompressor
[ https://issues.apache.org/jira/browse/HADOOP-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14304441#comment-14304441 ] Anu Engineer commented on HADOOP-11526: --- looks like this test failure is not related to code change: Code change avoids a memory leak in native code and should not effect this code path. This is probably a race condition in tests. Error Message Address already in use Stacktrace java.net.BindException: Address already in use at sun.nio.ch.Net.bind0(Native Method) at sun.nio.ch.Net.bind(Net.java:444) at sun.nio.ch.Net.bind(Net.java:436) at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:214) Memory leak in Bzip2Decompressor Key: HADOOP-11526 URL: https://issues.apache.org/jira/browse/HADOOP-11526 Project: Hadoop Common Issue Type: Bug Components: io Reporter: Ian Rogers Assignee: Anu Engineer Attachments: HADOOP-11526.001.patch The use of JNI's GetStringUTFChars should be paired with ReleaseStringUTFChars or else the utf-8 char* created by Java's JNI implementation is leaked. It isn't in Bzip2Decompressor.c: https://apache.googlesource.com/hadoop-common/+/refs/heads/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/bzip2/Bzip2Decompressor.c#45 A less error-prone way of handling JNI resources like local references and UTF strings is to use a smart pointer like the Apache licensed code in Android's ScopedLocalRef and ScopedUtfChars: https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedLocalRef.h https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedUtfChars.h -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11526) Memory leak in Bzip2Decompressor
[ https://issues.apache.org/jira/browse/HADOOP-11526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14298281#comment-14298281 ] Chris Nauroth commented on HADOOP-11526: Thank you for the bug report, Ian. Fortunately, this function is generally only called during one-time initialization in a Hadoop process, so that lessens the severity of the leak. We can still fix it though. Our native codebase is in C, so we'll have to stick with doing our own resource management instead of the smart pointers. Memory leak in Bzip2Decompressor Key: HADOOP-11526 URL: https://issues.apache.org/jira/browse/HADOOP-11526 Project: Hadoop Common Issue Type: Bug Components: io Reporter: Ian Rogers The use of JNI's GetStringUTFChars should be paired with ReleaseStringUTFChars or else the utf-8 char* created by Java's JNI implementation is leaked. It isn't in Bzip2Decompressor.c: https://apache.googlesource.com/hadoop-common/+/refs/heads/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/compress/bzip2/Bzip2Decompressor.c#45 A less error-prone way of handling JNI resources like local references and UTF strings is to use a smart pointer like the Apache licensed code in Android's ScopedLocalRef and ScopedUtfChars: https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedLocalRef.h https://android.googlesource.com/platform/libnativehelper/+/jb-mr1.1-dev-plus-aosp/include/nativehelper/ScopedUtfChars.h -- This message was sent by Atlassian JIRA (v6.3.4#6332)
