[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385338#comment-14385338
]
Hudson commented on HADOOP-11639:
-
SUCCESS: Integrated in Hadoop-Hdfs-trunk #2078 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2078/])
HADOOP-11639. Clean up Windows native code compilation warnings related to
Windows Secure Container Executor. Contributed by Remus Rusanu. (cnauroth: rev
3836ad6c0b3331cf60286d134157c13985908230)
* hadoop-common-project/hadoop-common/src/main/winutils/task.c
* hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
* hadoop-common-project/hadoop-common/src/main/winutils/client.c
* hadoop-common-project/hadoop-common/src/main/winutils/service.c
* hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
* hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/winutils/config.cpp
*
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/yarn/server/nodemanager/windows_secure_container_executor.c
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch, HADOOP-11639.03.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385308#comment-14385308
]
Hudson commented on HADOOP-11639:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2096 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2096/])
HADOOP-11639. Clean up Windows native code compilation warnings related to
Windows Secure Container Executor. Contributed by Remus Rusanu. (cnauroth: rev
3836ad6c0b3331cf60286d134157c13985908230)
*
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/yarn/server/nodemanager/windows_secure_container_executor.c
* hadoop-common-project/hadoop-common/src/main/winutils/task.c
* hadoop-common-project/hadoop-common/src/main/winutils/client.c
* hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
* hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
* hadoop-common-project/hadoop-common/src/main/winutils/service.c
* hadoop-common-project/hadoop-common/src/main/winutils/config.cpp
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch, HADOOP-11639.03.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385297#comment-14385297
]
Hudson commented on HADOOP-11639:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #146 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/146/])
HADOOP-11639. Clean up Windows native code compilation warnings related to
Windows Secure Container Executor. Contributed by Remus Rusanu. (cnauroth: rev
3836ad6c0b3331cf60286d134157c13985908230)
* hadoop-common-project/hadoop-common/src/main/winutils/task.c
* hadoop-common-project/hadoop-common/src/main/winutils/client.c
* hadoop-common-project/hadoop-common/src/main/winutils/config.cpp
* hadoop-common-project/hadoop-common/src/main/winutils/service.c
* hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
* hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
* hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/yarn/server/nodemanager/windows_secure_container_executor.c
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch, HADOOP-11639.03.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385278#comment-14385278
]
Hudson commented on HADOOP-11639:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #137 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/137/])
HADOOP-11639. Clean up Windows native code compilation warnings related to
Windows Secure Container Executor. Contributed by Remus Rusanu. (cnauroth: rev
3836ad6c0b3331cf60286d134157c13985908230)
* hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
* hadoop-common-project/hadoop-common/src/main/winutils/task.c
* hadoop-common-project/hadoop-common/src/main/winutils/service.c
* hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
* hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
*
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/yarn/server/nodemanager/windows_secure_container_executor.c
* hadoop-common-project/hadoop-common/src/main/winutils/client.c
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/winutils/config.cpp
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch, HADOOP-11639.03.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385232#comment-14385232
]
Hudson commented on HADOOP-11639:
-
FAILURE: Integrated in Hadoop-Yarn-trunk #880 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/880/])
HADOOP-11639. Clean up Windows native code compilation warnings related to
Windows Secure Container Executor. Contributed by Remus Rusanu. (cnauroth: rev
3836ad6c0b3331cf60286d134157c13985908230)
* hadoop-common-project/hadoop-common/src/main/winutils/client.c
* hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
* hadoop-common-project/hadoop-common/src/main/winutils/config.cpp
*
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/yarn/server/nodemanager/windows_secure_container_executor.c
* hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
* hadoop-common-project/hadoop-common/src/main/winutils/service.c
* hadoop-common-project/hadoop-common/src/main/winutils/task.c
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch, HADOOP-11639.03.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385224#comment-14385224
]
Hudson commented on HADOOP-11639:
-
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #146 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/146/])
HADOOP-11639. Clean up Windows native code compilation warnings related to
Windows Secure Container Executor. Contributed by Remus Rusanu. (cnauroth: rev
3836ad6c0b3331cf60286d134157c13985908230)
* hadoop-common-project/hadoop-common/src/main/winutils/service.c
* hadoop-common-project/hadoop-common/src/main/winutils/client.c
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/winutils/task.c
* hadoop-common-project/hadoop-common/src/main/winutils/config.cpp
* hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
* hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
*
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/yarn/server/nodemanager/windows_secure_container_executor.c
* hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch, HADOOP-11639.03.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384803#comment-14384803
]
Hudson commented on HADOOP-11639:
-
FAILURE: Integrated in Hadoop-trunk-Commit #7449 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7449/])
HADOOP-11639. Clean up Windows native code compilation warnings related to
Windows Secure Container Executor. Contributed by Remus Rusanu. (cnauroth: rev
3836ad6c0b3331cf60286d134157c13985908230)
* hadoop-common-project/hadoop-common/src/main/winutils/client.c
* hadoop-common-project/hadoop-common/src/main/winutils/task.c
* hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
* hadoop-common-project/hadoop-common/src/main/winutils/config.cpp
*
hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/yarn/server/nodemanager/windows_secure_container_executor.c
* hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
* hadoop-common-project/hadoop-common/src/main/winutils/service.c
* hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
* hadoop-common-project/hadoop-common/CHANGES.txt
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch, HADOOP-11639.03.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383639#comment-14383639
]
Hadoop QA commented on HADOOP-11639:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12707725/HADOOP-11639.03.patch
against trunk revision af618f2.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6011//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6011//console
This message is automatically generated.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch, HADOOP-11639.03.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372297#comment-14372297
]
Chris Nauroth commented on HADOOP-11639:
Hi [~rusanu]. It looks like we'll need to rebase this patch. Right now, I
can't apply the change in task.c. Otherwise, the patch looks good.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352818#comment-14352818
]
Remus Rusanu commented on HADOOP-11639:
---
I created HADOOP-11691 for the x86 build failure
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352811#comment-14352811
]
Remus Rusanu commented on HADOOP-11639:
---
[~chuanliu] After YARN-2190 trunk no longer compiles x86:
{code}
(Link target) ->
E:\HW\project\hadoop-common\hadoop-common-project\hadoop-common\target/winutils/hadoopwinutilsvc_s.obj
: fatal error LNK1112: module machine type 'x
64' conflicts with target machine type 'X86'
[E:\HW\project\hadoop-common\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
{code}
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352753#comment-14352753
]
Kiran Kumar M R commented on HADOOP-11639:
--
Patch committed from issue YARN-2190 has modified file task.c
[~rusanu] you may need to rebase your patch. Please check.
[~cnauroth] if there are no more comments, better to commit this patch.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345022#comment-14345022
]
Hadoop QA commented on HADOOP-11639:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12702157/HADOOP-11639.02.patch
against trunk revision 4228de9.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5832//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5832//console
This message is automatically generated.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344972#comment-14344972
]
Kiran Kumar M R commented on HADOOP-11639:
--
Verified latest patch. No warnings on both 32 and 64 bit builds.
+1
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344970#comment-14344970
]
Remus Rusanu commented on HADOOP-11639:
---
Thanks [~kirankumarmr], I tested 32 bit build with .02.patch and builds clean.
I used
{code}
- int count = 0;
- int crt = 0;
+ size_t count = 0;
+ size_t crt = 0;
{code}
to have the same type for crt and count.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch,
> HADOOP-11639.02.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344943#comment-14344943
]
Kiran Kumar M R commented on HADOOP-11639:
--
[~rusanu], I applied your patch and verified both 32-bit and 64-bit builds.
All warnings are resolved in 64-bit build.
Below warning is seen in 32-bit build
{code}
service.c(726): warning C4018: '<' : signed/unsigned mismatch
[D:\hadoop-git\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
{code}
Changing code as below solves it
{code}
DWORD AuthInit() {
DWORD dwError = ERROR_SUCCESS;
size_t count = 0;
- int crt = 0;
+ unsigned int crt = 0;
size_t len = 0;
{code}
After the above change, there are no warnings in both builds.
You can consider adding above change in your patch.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344428#comment-14344428
]
Kiran Kumar M R commented on HADOOP-11639:
--
[~rusanu], your changes overwriting the above quoted changes is fine. I will
verify once on both 32-bit and 64-bit build by applying your patch.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343084#comment-14343084
]
Remus Rusanu commented on HADOOP-11639:
---
My patch overwrites some changes from [~kirankumarmr] for HADOOP-9922. this is
simply because originally I did all the changes on an old trunk. After the pull
I resolved the merge by taking my changes on the conflict. Specifically, in
HADOOP-9922:
{code}
hadoop-common-project/hadoop-common/src/main/winutils/service.c
@@ -206,7 +206,7 @@ DWORD ValidateConfigurationFile() {
- int crt = 0, crtSid = 0;
+ unsigned int crt = 0, crtSid = 0;
{code}
while on my patch is:
{code}
hadoop-common-project/hadoop-common/src/main/winutils/service.c
@@ -206,7 +206,7 @@ DWORD ValidateConfigurationFile() {
- unsigned int crt = 0, crtSid = 0;
+ DWORD crt = 0;
{code}
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343017#comment-14343017
]
Hadoop QA commented on HADOOP-11639:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12701839/HADOOP-11639.01.patch
against trunk revision ca1c00b.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5810//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5810//console
This message is automatically generated.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch, HADOOP-11639.01.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342979#comment-14342979
]
Remus Rusanu commented on HADOOP-11639:
---
Forgot to pull trunk...
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342972#comment-14342972
]
Hadoop QA commented on HADOOP-11639:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12701834/HADOOP-11639.00.patch
against trunk revision ca1c00b.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5809//console
This message is automatically generated.
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342967#comment-14342967
]
Remus Rusanu commented on HADOOP-11639:
---
BTW, I also fixed the pre YARN-2198 _wfopen warning
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342964#comment-14342964
]
Remus Rusanu commented on HADOOP-11639:
---
I still have some C4748 warnings not sure how to handle these:
{code}
"E:\HW\project\hadoop-common\hadoop-common-project\hadoop-common\src\main\native\native.vcxproj"
(default target) (2) ->
(Link target) ->
e:\hw\project\hadoop-common\hadoop-common-project\hadoop-common\src\main\winutils\libwinutils.c(533):
warning C4748: /GS can not protect parameters
and local variables from local buffer overrun because optimizations are
disabled in function [E:\HW\project\hadoop-common\hadoop-common-project\hadoop
-common\src\main\native\native.vcxproj]
e:\hw\project\hadoop-common\hadoop-common-project\hadoop-common\src\main\winutils\libwinutils.c(2360):
warning C4748: /GS can not protect parameters
and local variables from local buffer overrun because optimizations are
disabled in function [E:\HW\project\hadoop-common\hadoop-common-project\hadoo
p-common\src\main\native\native.vcxproj]
e:\hw\project\hadoop-common\hadoop-common-project\hadoop-common\src\main\winutils\libwinutils.c(2311):
warning C4748: /GS can not protect parameters
and local variables from local buffer overrun because optimizations are
disabled in function [E:\HW\project\hadoop-common\hadoop-common-project\hadoo
p-common\src\main\native\native.vcxproj]
e:\hw\project\hadoop-common\hadoop-common-project\hadoop-common\src\main\winutils\libwinutils.c(342):
warning C4748: /GS can not protect parameters
and local variables from local buffer overrun because optimizations are
disabled in function [E:\HW\project\hadoop-common\hadoop-common-project\hadoop
-common\src\main\native\native.vcxproj]
e:\hw\project\hadoop-common\hadoop-common-project\hadoop-common\src\main\winutils\client.c(46):
warning C4748: /GS can not protect parameters and lo
cal variables from local buffer overrun because optimizations are disabled in
function [E:\HW\project\hadoop-common\hadoop-common-project\hadoop-commo
n\src\main\native\native.vcxproj]
e:\hw\project\hadoop-common\hadoop-common-project\hadoop-common\src\main\winutils\libwinutils.c(815):
warning C4748: /GS can not protect parameters
and local variables from local buffer overrun because optimizations are
disabled in function [E:\HW\project\hadoop-common\hadoop-common-project\hadoop
-common\src\main\native\native.vcxproj]
{code}
> Clean up Windows native code compilation warnings related to Windows Secure
> Container Executor.
> ---
>
> Key: HADOOP-11639
> URL: https://issues.apache.org/jira/browse/HADOOP-11639
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
>Affects Versions: 2.6.0
>Reporter: Chris Nauroth
>Assignee: Remus Rusanu
> Attachments: HADOOP-11639.00.patch
>
>
> YARN-2198 introduced additional code in Hadoop Common to support the
> NodeManager {{WindowsSecureContainerExecutor}}. The patch introduced new
> compilation warnings that we need to investigate and resolve.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11639) Clean up Windows native code compilation warnings related to Windows Secure Container Executor.
[
https://issues.apache.org/jira/browse/HADOOP-11639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14339254#comment-14339254
]
Chris Nauroth commented on HADOOP-11639:
FYI [~rusanu], since you had worked on YARN-2198. Here is the list of warnings
I see for a 64-bit compilation:
{code}
service.c(282): warning C4018: '<' : signed/unsigned mismatch
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(217): warning C4101: 'isSidDefaulted' : unreferenced local variable
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(327): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(385): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(440): warning C4047: 'function' : 'LPARAM' differs in levels of
indirection from 'void *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(440): warning C4024: 'CompareStringEx' : different types for formal
and actual parameter 9
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(503): warning C4026: function declared with formal parameter list
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(718): warning C4133: 'function' : incompatible types - from 'int *'
to 'size_t *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(740): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1117): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1117): warning C4020: 'AddNodeManagerAndUserACEsToObject' : too
many actual parameters
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1170): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1171): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1172): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1173): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1174): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1279): warning C4047: '=' : 'LONG_PTR' differs in levels of
indirection from 'HANDLE'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
service.c(1305): warning C4101: 'hr' : unreferenced local variable
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(172): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(240): warning C4029: declared formal parameter list different from
definition
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(285): warning C4133: 'function' : incompatible types - from 'LPSTR *'
to 'LPWSTR *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(312): warning C4133: 'function' : incompatible types - from 'int *' to
'size_t *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(339): warning C4018: '<' : signed/unsigned mismatch
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(445): warning C4133: 'function' : incompatible types - from 'LPSTR *'
to 'LPWSTR *'
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(631): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(699): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(726): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\winutils\winutils.vcxproj]
task.c(740): warning C4090: 'function' : different 'const' qualifiers
[C:\hdc\hadoop-common-project\hadoop-common\src\main\
