[jira] [Commented] (HADOOP-11704) ProxyUsers expects ipaddress due to MachineList but callers send in remote host
[ https://issues.apache.org/jira/browse/HADOOP-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14505413#comment-14505413 ] Arun Suresh commented on HADOOP-11704: -- +1 Thanks for the fix [~adhoot] Will be committing this shortly.. ProxyUsers expects ipaddress due to MachineList but callers send in remote host Key: HADOOP-11704 URL: https://issues.apache.org/jira/browse/HADOOP-11704 Project: Hadoop Common Issue Type: Bug Reporter: Anubhav Dhoot Assignee: Anubhav Dhoot Attachments: HADOOP-11704.001.patch, HADOOP-11704.002.patch DelegationTokenAuthenticationHandler and DelegationTokenAuthenticationFilter are using ServletRequest#getRemoteHost which can send an address if possible. It should use getRemoteAddr instead -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11704) ProxyUsers expects ipaddress due to MachineList but callers send in remote host
[
https://issues.apache.org/jira/browse/HADOOP-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14504684#comment-14504684
]
Hadoop QA commented on HADOOP-11704:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12726826/HADOOP-11704.002.patch
against trunk revision d52de61.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6137//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/6137//console
This message is automatically generated.
ProxyUsers expects ipaddress due to MachineList but callers send in remote
host
Key: HADOOP-11704
URL: https://issues.apache.org/jira/browse/HADOOP-11704
Project: Hadoop Common
Issue Type: Bug
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
Attachments: HADOOP-11704.001.patch, HADOOP-11704.002.patch
DelegationTokenAuthenticationHandler and DelegationTokenAuthenticationFilter
are using ServletRequest#getRemoteHost which can send an address if possible.
It should use getRemoteAddr instead
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11704) ProxyUsers expects ipaddress due to MachineList but callers send in remote host
[ https://issues.apache.org/jira/browse/HADOOP-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359963#comment-14359963 ] Anubhav Dhoot commented on HADOOP-11704: I think the logic is sound, as it normalize the configured ipaddress/hostname/cidr to ipaddress and then expects ipaddress to be passed in. Otherwise supporting both hostname and ipaddress to be passed in can be challenging. I can add a warning if the input is not an ipaddress to catch existing bugs like this. ProxyUsers expects ipaddress due to MachineList but callers send in remote host Key: HADOOP-11704 URL: https://issues.apache.org/jira/browse/HADOOP-11704 Project: Hadoop Common Issue Type: Bug Reporter: Anubhav Dhoot Assignee: Anubhav Dhoot Attachments: HADOOP-11704.001.patch DelegationTokenAuthenticationHandler and DelegationTokenAuthenticationFilter are using ServletRequest#getRemoteHost which can send an address if possible. It should use getRemoteAddr instead -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11704) ProxyUsers expects ipaddress due to MachineList but callers send in remote host
[ https://issues.apache.org/jira/browse/HADOOP-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359234#comment-14359234 ] Anubhav Dhoot commented on HADOOP-11704: Hi [~asuresh] the way MachineList support hostnames is try to convert the passed in ip Address into a hostname and check if its a configured host, and if that fails convert all the configured hostnames into an ip address and check if it matches the passed in ip address. That means you can configure hostnames in the config but the caller still has to pass in an ip address. ProxyUsers expects ipaddress due to MachineList but callers send in remote host Key: HADOOP-11704 URL: https://issues.apache.org/jira/browse/HADOOP-11704 Project: Hadoop Common Issue Type: Bug Reporter: Anubhav Dhoot Assignee: Anubhav Dhoot Attachments: HADOOP-11704.001.patch DelegationTokenAuthenticationHandler and DelegationTokenAuthenticationFilter are using ServletRequest#getRemoteHost which can send an address if possible. It should use getRemoteAddr instead -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11704) ProxyUsers expects ipaddress due to MachineList but callers send in remote host
[
https://issues.apache.org/jira/browse/HADOOP-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359247#comment-14359247
]
Hadoop QA commented on HADOOP-11704:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704219/HADOOP-11704.001.patch
against trunk revision 6dae6d1.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5928//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5928//console
This message is automatically generated.
ProxyUsers expects ipaddress due to MachineList but callers send in remote
host
Key: HADOOP-11704
URL: https://issues.apache.org/jira/browse/HADOOP-11704
Project: Hadoop Common
Issue Type: Bug
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
Attachments: HADOOP-11704.001.patch
DelegationTokenAuthenticationHandler and DelegationTokenAuthenticationFilter
are using ServletRequest#getRemoteHost which can send an address if possible.
It should use getRemoteAddr instead
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11704) ProxyUsers expects ipaddress due to MachineList but callers send in remote host
[
https://issues.apache.org/jira/browse/HADOOP-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359244#comment-14359244
]
Arun Suresh commented on HADOOP-11704:
--
Aah.. got it.. thanx for the clarification.. Your patch will I guess solve the
problem, but you think maybe we should raise a JIRA to fix {{MachineList}} too
?
ProxyUsers expects ipaddress due to MachineList but callers send in remote
host
Key: HADOOP-11704
URL: https://issues.apache.org/jira/browse/HADOOP-11704
Project: Hadoop Common
Issue Type: Bug
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
Attachments: HADOOP-11704.001.patch
DelegationTokenAuthenticationHandler and DelegationTokenAuthenticationFilter
are using ServletRequest#getRemoteHost which can send an address if possible.
It should use getRemoteAddr instead
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11704) ProxyUsers expects ipaddress due to MachineList but callers send in remote host
[
https://issues.apache.org/jira/browse/HADOOP-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14359183#comment-14359183
]
Arun Suresh commented on HADOOP-11704:
--
Hey [~adhoot], doesnt {{MachineList}} handle both hostname as well as IP
addresses ? or am I missing something ?
ProxyUsers expects ipaddress due to MachineList but callers send in remote
host
Key: HADOOP-11704
URL: https://issues.apache.org/jira/browse/HADOOP-11704
Project: Hadoop Common
Issue Type: Bug
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
Attachments: HADOOP-11704.001.patch
DelegationTokenAuthenticationHandler and DelegationTokenAuthenticationFilter
are using ServletRequest#getRemoteHost which can send an address if possible.
It should use getRemoteAddr instead
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
