[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14544980#comment-14544980
]
Rakesh R commented on HADOOP-11713:
---
Thanks a lot [~cnauroth] for the helpful code review and commit the changes!
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Fix For: 2.8.0
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545386#comment-14545386
]
Hudson commented on HADOOP-11713:
-
SUCCESS: Integrated in Hadoop-Yarn-trunk #928 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/928/])
HADOOP-11713. ViewFileSystem should support snapshot methods. Contributed by
Rakesh R. (cnauroth: rev 09fe16f166392a99e1e54001a9112c6a4632dfc8)
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFs.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Fix For: 2.8.0
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545409#comment-14545409
]
Hudson commented on HADOOP-11713:
-
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #197 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/197/])
HADOOP-11713. ViewFileSystem should support snapshot methods. Contributed by
Rakesh R. (cnauroth: rev 09fe16f166392a99e1e54001a9112c6a4632dfc8)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFs.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Fix For: 2.8.0
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545709#comment-14545709
]
Hudson commented on HADOOP-11713:
-
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #196 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/196/])
HADOOP-11713. ViewFileSystem should support snapshot methods. Contributed by
Rakesh R. (cnauroth: rev 09fe16f166392a99e1e54001a9112c6a4632dfc8)
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFs.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Fix For: 2.8.0
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545726#comment-14545726
]
Hudson commented on HADOOP-11713:
-
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2144 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2144/])
HADOOP-11713. ViewFileSystem should support snapshot methods. Contributed by
Rakesh R. (cnauroth: rev 09fe16f166392a99e1e54001a9112c6a4632dfc8)
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFs.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Fix For: 2.8.0
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545566#comment-14545566
]
Hudson commented on HADOOP-11713:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk #2126 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2126/])
HADOOP-11713. ViewFileSystem should support snapshot methods. Contributed by
Rakesh R. (cnauroth: rev 09fe16f166392a99e1e54001a9112c6a4632dfc8)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Fix For: 2.8.0
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545596#comment-14545596
]
Hudson commented on HADOOP-11713:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #186 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/186/])
HADOOP-11713. ViewFileSystem should support snapshot methods. Contributed by
Rakesh R. (cnauroth: rev 09fe16f166392a99e1e54001a9112c6a4632dfc8)
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Fix For: 2.8.0
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14544536#comment-14544536
]
Hudson commented on HADOOP-11713:
-
FAILURE: Integrated in Hadoop-trunk-Commit #7834 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/7834/])
HADOOP-11713. ViewFileSystem should support snapshot methods. Contributed by
Rakesh R. (cnauroth: rev 09fe16f166392a99e1e54001a9112c6a4632dfc8)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFs.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/TestChRootedFileSystem.java
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFileSystemBaseTest.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/viewfs/ViewFsBaseTest.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ChRootedFs.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/ViewFileSystem.java
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Fix For: 2.8.0
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537648#comment-14537648
]
Hadoop QA commented on HADOOP-11713:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 33s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 4 new or modified test files. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 4s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 3s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 40s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 8s | Tests passed in
hadoop-common. |
| | | 59m 3s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731855/HADOOP-11713-002.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4536399 |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6584/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6584/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6584/console |
This message was automatically generated.
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538422#comment-14538422
]
Rakesh R commented on HADOOP-11713:
---
[~cnauroth] Latest patch addresses the review comments. Please have a look at
it when you get a chance, thanks!
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537606#comment-14537606
]
Rakesh R commented on HADOOP-11713:
---
Attached another patch fixing checkstyle warnings related to my patch. Also,
I've fixed one minor {{whitespace}} and one minor {{checkstyle}} warnings which
are not related to my patch. Since I touched the file I thought of fixing these
considering that the change is very minor and not affecting any functionality.
# whitespace: ChRootedFs.java:381: public void setVerifyChecksum(final boolean
verifyChecksum)
{code}
+ public void setVerifyChecksum(final boolean verifyChecksum)
{code}
# checkstyle: Line is longer than 80 characters (found 81).
{code}
-// Prefix validated at mount time and rest of path validated by mount
target.
+// Prefix validated at mount time and rest of path validated by mount
+// target.
{code}
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HADOOP-11713-001.patch, HADOOP-11713-002.patch,
HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537366#comment-14537366
]
Hadoop QA commented on HADOOP-11713:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 27s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 4 new or modified test files. |
| {color:green}+1{color} | javac | 7m 27s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 4s | The applied patch generated 4
new checkstyle issues (total was 134, now 138). |
| {color:red}-1{color} | whitespace | 0m 2s | The patch has 1 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 39s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 34s | Tests passed in
hadoop-common. |
| | | 60m 24s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731814/HADOOP-11713-001.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4536399 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6580/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6580/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6580/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6580/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6580/console |
This message was automatically generated.
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HADOOP-11713-001.patch, HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537328#comment-14537328
]
Rakesh R commented on HADOOP-11713:
---
Thanks a lot [~cnauroth] for the review comments and the detailed explanation.
Attached another patch addressing the comments.
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HADOOP-11713-001.patch, HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535250#comment-14535250
]
Chris Nauroth commented on HADOOP-11713:
Hi [~rakeshr]. Thank you for picking up this issue. Here are a few comments.
# You'll also need to change classes {{ChRootedFs}} and {{ChRootedFileSystem}}.
# Please add tests to {{ViewFsBaseTest}} and {{ViewFileSystemBaseTest}} to
check the behavior of the various {{throw readOnlyMountTable...}} lines.
# Please add tests to {{TestChRootedFs}} and {{TestChRootedFileSystem}} to
verify that the chroot jail translates the paths correctly for the new APIs.
HDFS-5594 and HADOOP-10845 are prior patches that demonstrate the basic recipe
for adding new viewfs methods. You could look at those if you'd like to get
some additional ideas about how to write these tests.
Thanks again!
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535845#comment-14535845
]
Hadoop QA commented on HADOOP-11713:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 36s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 36s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 5s | The applied patch generated 4
new checkstyle issues (total was 153, now 157). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 4 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 39s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 59s | Tests passed in
hadoop-common. |
| | | 60m 0s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12704421/HDFS-5641-001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / effcc5c |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6556/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6556/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6556/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6556/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6556/console |
This message was automatically generated.
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362476#comment-14362476
]
Rakesh R commented on HADOOP-11713:
---
Failure reason is, since this is depending on the AbstractFileSystem.java
{{snapshot}} apis in HDFS-5640 patch, we should re-visit this jira after
pushing HDFS-5640 implementation first.
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11713) ViewFileSystem should support snapshot methods.
[
https://issues.apache.org/jira/browse/HADOOP-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14362459#comment-14362459
]
Hadoop QA commented on HADOOP-11713:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12704421/HDFS-5641-001.patch
against trunk revision bc9cb3e.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5945//console
This message is automatically generated.
ViewFileSystem should support snapshot methods.
---
Key: HADOOP-11713
URL: https://issues.apache.org/jira/browse/HADOOP-11713
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Chris Nauroth
Assignee: Rakesh R
Attachments: HDFS-5641-001.patch
Currently, {{ViewFileSystem}} does not dispatch snapshot methods through the
mount table. All snapshot methods throw {{UnsupportedOperationException}},
even though the underlying mount points could be HDFS instances that support
snapshots. We need to update {{ViewFileSystem}} to implement the snapshot
methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
