[jira] [Commented] (HADOOP-11897) test-patch.sh plugins should abbreviate the path
[
https://issues.apache.org/jira/browse/HADOOP-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737411#comment-14737411
]
Allen Wittenauer commented on HADOOP-11897:
---
So basically, this is about the output in the actual linked to log files. For
the vast majority of patches, they stay within one module, so printing the
entire patch from base is sort of waste. It might be better to just list the
paths up to the point that they conflict.
For example, let's say you have a patch that touches two files:
{code}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/pom.xml
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager/pom.xml
{code}
and it introduces whitespace. Rather than list
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server every time, maybe just list
hadoop-yarn-server-sharedcachemanager/pom.xml and
hadoop-yarn-server-resourcemanager/pom.xml .
This is just a food-for-thought type of idea. It would almost certainly have to
be done as a post processing step in each plugin.
> test-patch.sh plugins should abbreviate the path
>
>
> Key: HADOOP-11897
> URL: https://issues.apache.org/jira/browse/HADOOP-11897
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test, yetus
>Affects Versions: HADOOP-12111
>Reporter: Allen Wittenauer
>Priority: Trivial
> Labels: newbie
>
> The current output of checkstyle, shellcheck, and whitespace results in very
> long file name paths. It might be useful to abbreviate them in some way,
> maybe removing the entire path and leaving just the filename or last
> directory+filename.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11897) test-patch.sh plugins should abbreviate the path
[
https://issues.apache.org/jira/browse/HADOOP-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731263#comment-14731263
]
Kengo Seki commented on HADOOP-11897:
-
This may be fixed in the latest yetus code, but I found a strange output.
{code}
$ git checkout -b HADOOP-12111 origin/HADOOP-12111 # or simply `git checkout
HADOOP-12111` if you've already fetched the remote branch
$ dev-support/test-patch.sh --basedir=/path/to/another/hadoop/repo
--project=hadoop
https://issues.apache.org/jira/secure/attachment/12731148/HADOOP-7266.001.patch
{code}
will produce the following result (I skipped all mvn running with Ctrl-C):
{code}
|| Subsystem || Report/Notes ||
| git revision | trunk / d16c4ee |
| Optional Tests | asflicense javac javadoc mvninstall unit findbugs checkstyle
|
| uname | Darwin mobile.local 14.5.0 Darwin Kernel Version 14.5.0: Wed Jul 29
02:26:53 PDT 2015; root:xnu-2782.40.9~1/RELEASE_X86_64 x86_64 |
| Build tool | maven |
| Personality | /Users/sekikn/work/hadoop/dev-support/personality/hadoop.sh |
| Default Java | 1.7.0_80 |
| mvninstall | /private/tmp/test-patch-hadoop/61296/branch-mvninstall-root.txt |
| javac | /private/tmp/test-patch-hadoop/61296/branch-javac-root.txt |
| javadoc |
/private/tmp/test-patch-hadoop/61296/branch-javadoc-hadoop-common-project_hadoop-common.txt
|
| javadoc |
/private/tmp/test-patch-hadoop/61296/branch-javadoc-hadoop-tools_hadoop-streaming.txt
|
| checkstyle |
/private/tmp/test-patch-hadoop/61296//private/tmp/test-patch-hadoop/61296/maven-branch-checkstyle-root.txt
|
| javac | /private/tmp/test-patch-hadoop/61296/patch-javac-root.txt |
| asflicense | /private/tmp/test-patch-hadoop/61296/patch-asflicense-root.txt |
| checkstyle |
/private/tmp/test-patch-hadoop/61296//private/tmp/test-patch-hadoop/61296/maven-patch-checkstyle-root.txt
|
| mvninstall |
/private/tmp/test-patch-hadoop/61296/patch-mvninstall-hadoop-common-project_hadoop-common.txt
|
| mvninstall |
/private/tmp/test-patch-hadoop/61296/patch-mvninstall-hadoop-tools_hadoop-streaming.txt
|
| javadoc |
/private/tmp/test-patch-hadoop/61296/patch-javadoc-hadoop-common-project_hadoop-common.txt
|
| javadoc |
/private/tmp/test-patch-hadoop/61296/patch-javadoc-hadoop-tools_hadoop-streaming.txt
|
| eclipse |
/private/tmp/test-patch-hadoop/61296/patch-eclipse-hadoop-common-project_hadoop-common.txt
|
| eclipse |
/private/tmp/test-patch-hadoop/61296/patch-eclipse-hadoop-tools_hadoop-streaming.txt
|
| findbugs |
/private/tmp/test-patch-hadoop/61296/patch-findbugs-hadoop-common-project_hadoop-common.txt
|
| findbugs |
/private/tmp/test-patch-hadoop/61296/patch-findbugs-hadoop-tools_hadoop-streaming.txt
|
{code}
The checkstyle path is very long, because the directory path is duplicated.
As far as i investigated, shellcheck and whitespace output the correct path.
> test-patch.sh plugins should abbreviate the path
>
>
> Key: HADOOP-11897
> URL: https://issues.apache.org/jira/browse/HADOOP-11897
> Project: Hadoop Common
> Issue Type: Test
> Components: test
>Reporter: Allen Wittenauer
>Priority: Trivial
> Labels: newbie
>
> The current output of checkstyle, shellcheck, and whitespace results in very
> long file name paths. It might be useful to abbreviate them in some way,
> maybe removing the entire path and leaving just the filename or last
> directory+filename.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-11897) test-patch.sh plugins should abbreviate the path
[ https://issues.apache.org/jira/browse/HADOOP-11897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730435#comment-14730435 ] Darrell Taylor commented on HADOOP-11897: - Could someone ([~aw]?) give me a few pointers to get started with this, i.e. commands to run to replicate the problem and I'll take a look. > test-patch.sh plugins should abbreviate the path > > > Key: HADOOP-11897 > URL: https://issues.apache.org/jira/browse/HADOOP-11897 > Project: Hadoop Common > Issue Type: Test > Components: test >Reporter: Allen Wittenauer >Priority: Trivial > Labels: newbie > > The current output of checkstyle, shellcheck, and whitespace results in very > long file name paths. It might be useful to abbreviate them in some way, > maybe removing the entire path and leaving just the filename or last > directory+filename. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
