[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548172#comment-14548172 ] Sean Busbey commented on HADOOP-11993: -- When adding this, it'd be easier to maintain if we included a comment that referenced an upstream issue for dependencies that are banned without a version range. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Priority: Minor > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280085#comment-15280085 ] Akira AJISAKA commented on HADOOP-11993: Thanks Tsuyoshi for the information. I filed a jira for upgrading asm (HADOOP-13133). > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Priority: Minor > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14971340#comment-14971340 ] Tsuyoshi Ozawa commented on HADOOP-11993: - As far as I know, following libraries should be upgraded to support JDK8: * Google Guice -> 4.0 * asm -> 5.0.4 (5.0.0 is first version to support JDK8, and 5.0.1 includes bug fixes about JDK7: Incorrect StackMapFrame calculations for large > 32k methods in Java 7.) * Jersey -> 1.19 or jumping to more recent version (e.g. 2.22.1) I also confirmed that these libraries are targeting JDK 1.6, so they are binary compatible with JDK 7. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Priority: Minor > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363880#comment-15363880 ] Tsuyoshi Ozawa commented on HADOOP-11993: - {quote} + org.ow2.asm:asm:5.0.0 {quote} BTW, I specified minimum version which JDK8 is supported. Hence, I specified 5.0.0 for asm. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Attachments: HADOOP-11993.001.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363896#comment-15363896 ] Hadoop QA commented on HADOOP-11993: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 14s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 8s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 11s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 6s{color} | {color:green} hadoop-project in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 8m 35s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12816374/HADOOP-11993.001.patch | | JIRA Issue | HADOOP-11993 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml | | uname | Linux d5bc49dca1fc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / d792a90 | | Default Java | 1.8.0_91 | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/9930/testReport/ | | modules | C: hadoop-project U: hadoop-project | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9930/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Attachments: HADOOP-11993.001.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364756#comment-15364756 ] Akira Ajisaka commented on HADOOP-11993: I ran {{mvn clean verify -DskipTests}} and it failed. {noformat} [INFO] --- maven-enforcer-plugin:1.4.1:enforce (depcheck) @ hadoop-common --- [WARNING] Rule 1: org.apache.maven.plugins.enforcer.BannedDependencies failed with message: Found Banned Dependency: com.sun.jersey:jersey-servlet:jar:1.19 Found Banned Dependency: com.sun.jersey:jersey-json:jar:1.19 Use 'mvn dependency:tree' to locate the source of the banned dependencies. {noformat} Would you fix the failure? In addition, would you fix the indent? > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Attachments: HADOOP-11993.001.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365735#comment-15365735 ] Tsuyoshi Ozawa commented on HADOOP-11993: - [~ajisakaa] sorry, I attached wrong patch. Uploading correct one. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Attachments: HADOOP-11993.001.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365752#comment-15365752 ] Hadoop QA commented on HADOOP-11993: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 44s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 8s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 10s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 8s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 6s{color} | {color:green} hadoop-project in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 9m 9s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12816585/HADOOP-11993.002.patch | | JIRA Issue | HADOOP-11993 | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml | | uname | Linux 5bfa20c6f39e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | trunk / a3f93be | | Default Java | 1.8.0_91 | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/9935/testReport/ | | modules | C: hadoop-project U: hadoop-project | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/9935/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Attachments: HADOOP-11993.001.patch, HADOOP-11993.002.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366395#comment-15366395 ] Akira Ajisaka commented on HADOOP-11993: +1, thanks Tsuyoshi. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Attachments: HADOOP-11993.001.patch, HADOOP-11993.002.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366725#comment-15366725 ] Tsuyoshi Ozawa commented on HADOOP-11993: - Checking this in. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Attachments: HADOOP-11993.001.patch, HADOOP-11993.002.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366730#comment-15366730 ] Tsuyoshi Ozawa commented on HADOOP-11993: - Committed this to trunk. Thanks [~ajisakaa] for review, thanks [~ste...@apache.org] for reporting, and thanks [~busbey] for the comment!. > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Fix For: 3.0.0-alpha1 > > Attachments: HADOOP-11993.001.patch, HADOOP-11993.002.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-11993) maven enforcer plugin to ban java 8 incompatible dependencies
[ https://issues.apache.org/jira/browse/HADOOP-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15366755#comment-15366755 ] Hudson commented on HADOOP-11993: - SUCCESS: Integrated in Hadoop-trunk-Commit #10061 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10061/]) HADOOP-11993. maven enforcer plugin to ban java 8 incompatible (ozawa: rev 0185de07676dc2f330d48453217222ad0d1cb3cf) * hadoop-project/pom.xml > maven enforcer plugin to ban java 8 incompatible dependencies > - > > Key: HADOOP-11993 > URL: https://issues.apache.org/jira/browse/HADOOP-11993 > Project: Hadoop Common > Issue Type: Sub-task >Affects Versions: 2.7.0 >Reporter: Steve Loughran >Assignee: Tsuyoshi Ozawa >Priority: Minor > Fix For: 3.0.0-alpha1 > > Attachments: HADOOP-11993.001.patch, HADOOP-11993.002.patch > > > It's possible to use maven-enforcer to ban dependencies; this can be used to > reject those known to be incompatible with Java 8 > [example|https://gist.github.com/HiJon89/65e34552c18e5ac9fd31] > If we set maven enforcer to do this checking, it can ensure that the 2.7+ > codebase isn't pulling in any incompatible binaries. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org