[jira] [Commented] (HADOOP-12098) Unnecessary dependencies in Hadoop Archives
[
https://issues.apache.org/jira/browse/HADOOP-12098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604059#comment-14604059
]
Hadoop QA commented on HADOOP-12098:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 44s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 30s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | tools/hadoop tests | 0m 50s | Tests passed in
hadoop-archives. |
| | | 35m 15s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742306/HADOOP-12098.02.patch |
| Optional Tests | javadoc javac unit |
| git revision | trunk / fe6c1bd |
| hadoop-archives test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7070/artifact/patchprocess/testrun_hadoop-archives.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7070/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7070/console |
This message was automatically generated.
> Unnecessary dependencies in Hadoop Archives
> ---
>
> Key: HADOOP-12098
> URL: https://issues.apache.org/jira/browse/HADOOP-12098
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: HADOOP-12098.001.patch, HADOOP-12098.02.patch
>
>
> hadoop-mapreduce-client-hs and hadoop-mapreduce-client-jobclient(test jar)
> dependencies are not required in Hadoop archives
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12098) Unnecessary dependencies in Hadoop Archives
[ https://issues.apache.org/jira/browse/HADOOP-12098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604050#comment-14604050 ] Varun Saxena commented on HADOOP-12098: --- Anyways, there is quite a bit of cross dependency in classes used so not going to touch these mapreduce modules. Removing dependencies from archives for now. > Unnecessary dependencies in Hadoop Archives > --- > > Key: HADOOP-12098 > URL: https://issues.apache.org/jira/browse/HADOOP-12098 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.7.0 >Reporter: Varun Saxena >Assignee: Varun Saxena >Priority: Minor > Attachments: HADOOP-12098.001.patch, HADOOP-12098.02.patch > > > hadoop-mapreduce-client-hs and hadoop-mapreduce-client-jobclient dependencies > are not required in Hadoop archives -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12098) Unnecessary dependencies in Hadoop Archives
[
https://issues.apache.org/jira/browse/HADOOP-12098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604021#comment-14604021
]
Varun Saxena commented on HADOOP-12098:
---
Tests fail due to runtime dependence on jobclient main jar. The test jar and hs
jars are still unnecessary.
The runtime dependence comes due to subclasses of {{ClientProtocolProvider}}
classes being loaded at runtime
{{ClientProtocolProvider}} exists in {{hadoop-mapreduce-core}}.
{{LocalClientProtocolProvider}} and associated classes such as
{{LocalJobRunner}} exist in {{hadoop-mapreduce-client-common}}
{{YarnClientProtocolProvider}} and associated classes such as {{YarnRunner}}
exist in {{hadoop-mapreduce-jobclient}}.
Any reason why these classes have been kept this way ? All can move to
{{hadoop-mapreduce-client-core}} IMHO. This creates unnecessary dependencies.
{{hadoop-mapreduce-client-jobclient}} seems to be having hardly any main
classes now. Is it even required as a separate submodule ?
> Unnecessary dependencies in Hadoop Archives
> ---
>
> Key: HADOOP-12098
> URL: https://issues.apache.org/jira/browse/HADOOP-12098
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: HADOOP-12098.001.patch
>
>
> hadoop-mapreduce-client-hs and hadoop-mapreduce-client-jobclient dependencies
> are not required in Hadoop archives
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12098) Unnecessary dependencies in Hadoop Archives
[
https://issues.apache.org/jira/browse/HADOOP-12098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14602507#comment-14602507
]
Hadoop QA commented on HADOOP-12098:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 39s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 53s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 1s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | tools/hadoop tests | 0m 30s | Tests failed in
hadoop-archives. |
| | | 36m 38s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.tools.TestHadoopArchives |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12742063/HADOOP-12098.001.patch
|
| Optional Tests | javadoc javac unit |
| git revision | trunk / 8ef07f7 |
| hadoop-archives test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7050/artifact/patchprocess/testrun_hadoop-archives.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7050/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7050/console |
This message was automatically generated.
> Unnecessary dependencies in Hadoop Archives
> ---
>
> Key: HADOOP-12098
> URL: https://issues.apache.org/jira/browse/HADOOP-12098
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Varun Saxena
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: HADOOP-12098.001.patch, HADOOP-12098.01.patch
>
>
> hadoop-mapreduce-client-hs and hadoop-mapreduce-client-jobclient dependencies
> are not required in Hadoop archives
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
