[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616988#comment-14616988 ] Brahma Reddy Battula commented on HADOOP-12201: --- Patch,LGTM +1 ( non-binding). > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-12201.001.patch, createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616991#comment-14616991 ] Colin Patrick McCabe commented on HADOOP-12201: --- Thanks, Brahma. createFileSystem generally happens only once and it seems to take a long time (about a second), so it seems like a great candidate for tracing. Globber#glob also can be time-consuming so there is value in tracing it. I've been looking at a lot of FsShell traces lately and this came out of that. > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-12201.001.patch, createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617788#comment-14617788 ] Yi Liu commented on HADOOP-12201: - +1, thanks Colin. > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-12201.001.patch, createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619310#comment-14619310 ] stack commented on HADOOP-12201: +1 I like the pretty picture [~cmccabe] > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-12201.001.patch, createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[
https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619483#comment-14619483
]
Hadoop QA commented on HADOOP-12201:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 16m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 1s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 42s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 7s | The applied patch generated 1
new checkstyle issues (total was 145, now 145). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 20s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 52s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 22m 21s | Tests passed in
hadoop-common. |
| | | 61m 32s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12744332/HADOOP-12201.001-reupload.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 2e3d83f |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7204/console |
This message was automatically generated.
> Add tracing to FileSystem#createFileSystem and Globber#glob
> ---
>
> Key: HADOOP-12201
> URL: https://issues.apache.org/jira/browse/HADOOP-12201
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.6.0
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch,
> createfilesystem.png
>
>
> Add tracing to FileSystem#createFileSystem and Globber#glob
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619806#comment-14619806 ] Colin Patrick McCabe commented on HADOOP-12201: --- Thanks, guys. checkstyle issue is something we can't do anything about: ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java:1: File length is 3,412 lines (max allowed is 2,000). Committed to 2.8. > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch, > createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619850#comment-14619850 ] Hudson commented on HADOOP-12201: - FAILURE: Integrated in Hadoop-trunk-Commit #8136 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8136/]) HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.8.0 > > Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch, > createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620310#comment-14620310 ] Hudson commented on HADOOP-12201: - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #251 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/251/]) HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.8.0 > > Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch, > createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620352#comment-14620352 ] Hudson commented on HADOOP-12201: - FAILURE: Integrated in Hadoop-Yarn-trunk #981 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/981/]) HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java * hadoop-common-project/hadoop-common/CHANGES.txt > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.8.0 > > Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch, > createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620577#comment-14620577 ] Hudson commented on HADOOP-12201: - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #239 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/239/]) HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.8.0 > > Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch, > createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620596#comment-14620596 ] Hudson commented on HADOOP-12201: - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2178 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2178/]) HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.8.0 > > Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch, > createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620679#comment-14620679 ] Hudson commented on HADOOP-12201: - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #249 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/249/]) HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.8.0 > > Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch, > createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12201) Add tracing to FileSystem#createFileSystem and Globber#glob
[ https://issues.apache.org/jira/browse/HADOOP-12201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14620702#comment-14620702 ] Hudson commented on HADOOP-12201: - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2197 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2197/]) HADOOP-12201. Add tracing to FileSystem#createFileSystem and Globber#glob (cmccabe) (cmccabe: rev b8832fcf1e2ae1e43d5e4523016731af40ab58d7) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Globber.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java > Add tracing to FileSystem#createFileSystem and Globber#glob > --- > > Key: HADOOP-12201 > URL: https://issues.apache.org/jira/browse/HADOOP-12201 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.6.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 2.8.0 > > Attachments: HADOOP-12201.001-reupload.patch, HADOOP-12201.001.patch, > createfilesystem.png > > > Add tracing to FileSystem#createFileSystem and Globber#glob -- This message was sent by Atlassian JIRA (v6.3.4#6332)
