[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695523#comment-14695523
]
Hudson commented on HADOOP-12295:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2232 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2232/])
HADOOP-12295. Improve NetworkTopology#InnerNode#remove logic. (yliu) (yliu: rev
53bef9c5b98dee87d4ffaf35415bc38e2f876ed8)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695484#comment-14695484
]
Hudson commented on HADOOP-12295:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #283 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/283/])
HADOOP-12295. Improve NetworkTopology#InnerNode#remove logic. (yliu) (yliu: rev
53bef9c5b98dee87d4ffaf35415bc38e2f876ed8)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695459#comment-14695459
]
Hudson commented on HADOOP-12295:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #275 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/275/])
HADOOP-12295. Improve NetworkTopology#InnerNode#remove logic. (yliu) (yliu: rev
53bef9c5b98dee87d4ffaf35415bc38e2f876ed8)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695392#comment-14695392
]
Hudson commented on HADOOP-12295:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk #2213 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2213/])
HADOOP-12295. Improve NetworkTopology#InnerNode#remove logic. (yliu) (yliu: rev
53bef9c5b98dee87d4ffaf35415bc38e2f876ed8)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695128#comment-14695128
]
Hudson commented on HADOOP-12295:
-
FAILURE: Integrated in Hadoop-Yarn-trunk #1016 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1016/])
HADOOP-12295. Improve NetworkTopology#InnerNode#remove logic. (yliu) (yliu: rev
53bef9c5b98dee87d4ffaf35415bc38e2f876ed8)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695121#comment-14695121
]
Hudson commented on HADOOP-12295:
-
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #286 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/286/])
HADOOP-12295. Improve NetworkTopology#InnerNode#remove logic. (yliu) (yliu: rev
53bef9c5b98dee87d4ffaf35415bc38e2f876ed8)
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694999#comment-14694999
]
Hudson commented on HADOOP-12295:
-
FAILURE: Integrated in Hadoop-trunk-Commit #8293 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8293/])
HADOOP-12295. Improve NetworkTopology#InnerNode#remove logic. (yliu) (yliu: rev
53bef9c5b98dee87d4ffaf35415bc38e2f876ed8)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/net/TestNetworkTopology.java
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694910#comment-14694910
]
Yi Liu commented on HADOOP-12295:
-
Thanks [~vinayrpet] for the review, committed to trunk and branch-2. I can
address the comment if Chris has, thanks.
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679655#comment-14679655
]
Vinayakumar B commented on HADOOP-12295:
+1, looks fine to me.
Hi [~chris.douglas], Do you want to check once?
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12295) Improve NetworkTopology#InnerNode#remove logic
[
https://issues.apache.org/jira/browse/HADOOP-12295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14652099#comment-14652099
]
Hadoop QA commented on HADOOP-12295:
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 18m 59s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 43s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 44s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 2m 26s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 21s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 21s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 22m 29s | Tests passed in
hadoop-common. |
| {color:green}+1{color} | hdfs tests | 162m 23s | Tests passed in hadoop-hdfs.
|
| | | 230m 26s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12748448/HADOOP-12295.001.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 90b5104 |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7400/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7400/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7400/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7400/console |
This message was automatically generated.
> Improve NetworkTopology#InnerNode#remove logic
> --
>
> Key: HADOOP-12295
> URL: https://issues.apache.org/jira/browse/HADOOP-12295
> Project: Hadoop Common
> Issue Type: Improvement
>Reporter: Yi Liu
>Assignee: Yi Liu
> Attachments: HADOOP-12295.001.patch
>
>
> In {{NetworkTopology#InnerNode#remove}}, We can use {{childrenMap}} to get
> the parent node, no need to loop the {{children}} list. Then it is more
> efficient since in most cases deleting parent node doesn't happen.
> Another nit in current code is:
> {code}
> String parent = n.getNetworkLocation();
> String currentPath = getPath(this);
> {code}
> can be in closure of {{\!isAncestor\(n\)}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
