[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695835#comment-14695835
]
Aaron T. Myers commented on HADOOP-12318:
-
Hey Steve, thanks a lot for taking a look at this patch, and I think your point
is a good one. Mind if we file a new JIRA to make this change? Seems like
that'd make the history a bit cleaner than reverting this patch and applying a
new one with the revision you're suggesting.
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695520#comment-14695520
]
Hudson commented on HADOOP-12318:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk #2232 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2232/])
HADOOP-12318. Expose underlying LDAP exceptions in SaslPlainServer. Contributed
by Mike Yoder. (atm: rev 820f864a26d90e9f4a3584577df581dcac20f9b6)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695481#comment-14695481
]
Hudson commented on HADOOP-12318:
-
FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #283 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/283/])
HADOOP-12318. Expose underlying LDAP exceptions in SaslPlainServer. Contributed
by Mike Yoder. (atm: rev 820f864a26d90e9f4a3584577df581dcac20f9b6)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695456#comment-14695456
]
Hudson commented on HADOOP-12318:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #275 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/275/])
HADOOP-12318. Expose underlying LDAP exceptions in SaslPlainServer. Contributed
by Mike Yoder. (atm: rev 820f864a26d90e9f4a3584577df581dcac20f9b6)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695389#comment-14695389
]
Hudson commented on HADOOP-12318:
-
FAILURE: Integrated in Hadoop-Hdfs-trunk #2213 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2213/])
HADOOP-12318. Expose underlying LDAP exceptions in SaslPlainServer. Contributed
by Mike Yoder. (atm: rev 820f864a26d90e9f4a3584577df581dcac20f9b6)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695125#comment-14695125
]
Hudson commented on HADOOP-12318:
-
FAILURE: Integrated in Hadoop-Yarn-trunk #1016 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/1016/])
HADOOP-12318. Expose underlying LDAP exceptions in SaslPlainServer. Contributed
by Mike Yoder. (atm: rev 820f864a26d90e9f4a3584577df581dcac20f9b6)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695118#comment-14695118
]
Hudson commented on HADOOP-12318:
-
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #286 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/286/])
HADOOP-12318. Expose underlying LDAP exceptions in SaslPlainServer. Contributed
by Mike Yoder. (atm: rev 820f864a26d90e9f4a3584577df581dcac20f9b6)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694614#comment-14694614
]
Steve Loughran commented on HADOOP-12318:
-
Looking @ the patch more, the patch itself isn't introducing the getmessage
bug, merely retaining it. Even so, this is the time to fix as its only going to
lead to messages like "auth failed cause: Null"
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694609#comment-14694609
]
Steve Loughran commented on HADOOP-12318:
-
-1. It's critical to use Exception.toString() and not .getMessage(), as some
exceptions (NPE) don't have messages.
please roll back and add one which reports exceptions fully.
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694340#comment-14694340
]
Hudson commented on HADOOP-12318:
-
FAILURE: Integrated in Hadoop-trunk-Commit #8289 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8289/])
HADOOP-12318. Expose underlying LDAP exceptions in SaslPlainServer. Contributed
by Mike Yoder. (atm: rev 820f864a26d90e9f4a3584577df581dcac20f9b6)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694278#comment-14694278
]
Aaron T. Myers commented on HADOOP-12318:
-
+1, the patch looks good to me. I don't think we need a test for this since
it's just adding a new cause for an exception. I ran both of the failed tests
and they passed locally for me, so I think the failures are unrelated.
I'm going to commit this momentarily.
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Affects Versions: 2.8.0
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694109#comment-14694109
]
Hadoop QA commented on HADOOP-12318:
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 22s | Findbugs (version ) appears to
be broken on trunk. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 40s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 44s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 39s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 22s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 51s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests | 22m 36s | Tests failed in
hadoop-common. |
| | | 60m 18s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.net.TestNetUtils |
| | hadoop.ha.TestZKFailoverController |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12750145/HADOOP-12318.000.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 1c12adb |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7454/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7454/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7454/console |
This message was automatically generated.
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Reporter: Mike Yoder
>Assignee: Mike Yoder
>Priority: Minor
> Attachments: HADOOP-12318.000.patch
>
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12318) Expose underlying LDAP exceptions in SaslPlainServer
[
https://issues.apache.org/jira/browse/HADOOP-12318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694030#comment-14694030
]
Larry McCay commented on HADOOP-12318:
--
That seems reasonable to me.
> Expose underlying LDAP exceptions in SaslPlainServer
>
>
> Key: HADOOP-12318
> URL: https://issues.apache.org/jira/browse/HADOOP-12318
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
>Reporter: Mike Yoder
>Priority: Minor
>
> In the code of class
> [SaslPlainServer|http://github.mtv.cloudera.com/CDH/hadoop/blob/cdh5-2.6.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/SaslPlainServer.java#L108],
> the underlying exception is not included in the {{SaslException}}, which
> leads to below error message in HiveServer2:
> {noformat}
> 2015-07-22 11:50:28,433 DEBUG
> org.apache.thrift.transport.TSaslServerTransport: failed to open server
> transport
> org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error
> validating LDAP user
> at
> org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
> at
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
> at
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
> at
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
> at
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Make COEs very hard to understand what the real error is.
> Can we change that line as:
> {code}
> } catch (Exception e) {
> throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
