[jira] [Commented] (HADOOP-12575) Build instruction for docker toolbox
[ https://issues.apache.org/jira/browse/HADOOP-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013152#comment-15013152 ] Tsuyoshi Ozawa commented on HADOOP-12575: - +1, checking this in. > Build instruction for docker toolbox > > > Key: HADOOP-12575 > URL: https://issues.apache.org/jira/browse/HADOOP-12575 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Reporter: Kai Sasaki >Assignee: Kai Sasaki >Priority: Trivial > Labels: docker, documentation > Attachments: HADOOP-12575.01.patch, HADOOP-12575.02.patch, > HADOOP-12575.03.patch > > > Currently docker on MacOSX is mainly used by docker toolbox and > docker-machine. These tools make boot2docker deprecated. > (https://docs.docker.com/engine/installation/mac/) > It might be better to append the instruction of docker toolbox and > docker-machine when using {{start-build-env.sh}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12575) Build instruction for docker toolbox
[ https://issues.apache.org/jira/browse/HADOOP-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013140#comment-15013140 ] Hadoop QA commented on HADOOP-12575: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s {color} | {color:blue} docker + precommit patch detected. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 38s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 0m 53s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:date2015-11-19 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12773205/HADOOP-12575.03.patch | | JIRA Issue | HADOOP-12575 | | Optional Tests | asflicense | | uname | Linux f5a31bae5997 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh | | git revision | trunk / 23a130a | | modules | C: . U: . | | Max memory used | 32MB | | Powered by | Apache Yetus http://yetus.apache.org | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/8095/console | This message was automatically generated. > Build instruction for docker toolbox > > > Key: HADOOP-12575 > URL: https://issues.apache.org/jira/browse/HADOOP-12575 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Reporter: Kai Sasaki >Assignee: Kai Sasaki >Priority: Trivial > Labels: docker, documentation > Attachments: HADOOP-12575.01.patch, HADOOP-12575.02.patch, > HADOOP-12575.03.patch > > > Currently docker on MacOSX is mainly used by docker toolbox and > docker-machine. These tools make boot2docker deprecated. > (https://docs.docker.com/engine/installation/mac/) > It might be better to append the instruction of docker toolbox and > docker-machine when using {{start-build-env.sh}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12575) Build instruction for docker toolbox
[ https://issues.apache.org/jira/browse/HADOOP-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013114#comment-15013114 ] Tsuyoshi Ozawa commented on HADOOP-12575: - [~lewuathe] thank you for quick updating! As [~mzuehlke] linked, change from boot2docker to docker-machine looks to be better. Could you remove the section about boot2docker and update the first sentence to {{You can use docker toolbox as described in http://docs.docker.com/mac/step_one/.}}? Also I found the indentation goes wrong after applying the patch. Could you fix it? {quote} On Mac: ... Also you can use docker toolbox as described in http://docs.docker.com/mac/step_one/. # <-- This line should be indended First make sure Virtualbox and docker toolbox are installed. $ docker-machine create --driver virtualbox \ ... {quote} > Build instruction for docker toolbox > > > Key: HADOOP-12575 > URL: https://issues.apache.org/jira/browse/HADOOP-12575 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Reporter: Kai Sasaki >Assignee: Kai Sasaki >Priority: Trivial > Labels: docker, documentation > Attachments: HADOOP-12575.01.patch, HADOOP-12575.02.patch > > > Currently docker on MacOSX is mainly used by docker toolbox and > docker-machine. These tools make boot2docker deprecated. > (https://docs.docker.com/engine/installation/mac/) > It might be better to append the instruction of docker toolbox and > docker-machine when using {{start-build-env.sh}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12575) Build instruction for docker toolbox
[ https://issues.apache.org/jira/browse/HADOOP-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013081#comment-15013081 ] Hadoop QA commented on HADOOP-12575: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 6s {color} | {color:blue} docker + precommit patch detected. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 1s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 0m 31s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:date2015-11-19 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12773197/HADOOP-12575.02.patch | | JIRA Issue | HADOOP-12575 | | Optional Tests | asflicense | | uname | Linux b8a5b6dc43ce 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh | | git revision | trunk / 23a130a | | modules | C: . U: . | | Max memory used | 31MB | | Powered by | Apache Yetus http://yetus.apache.org | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/8090/console | This message was automatically generated. > Build instruction for docker toolbox > > > Key: HADOOP-12575 > URL: https://issues.apache.org/jira/browse/HADOOP-12575 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Reporter: Kai Sasaki >Assignee: Kai Sasaki >Priority: Trivial > Labels: docker, documentation > Attachments: HADOOP-12575.01.patch, HADOOP-12575.02.patch > > > Currently docker on MacOSX is mainly used by docker toolbox and > docker-machine. These tools make boot2docker deprecated. > (https://docs.docker.com/engine/installation/mac/) > It might be better to append the instruction of docker toolbox and > docker-machine when using {{start-build-env.sh}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12575) Build instruction for docker toolbox
[ https://issues.apache.org/jira/browse/HADOOP-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012994#comment-15012994 ] Tsuyoshi Ozawa commented on HADOOP-12575: - [~lewuathe] thank you for taking this issue. Followings are my review comments - could you update the patch? 1. The configuration looks to be for a driver of softlayer. We can remove it. {code} +--softlayer-memory "4096" \ {code} 2. The docker machine name {{default}} can be conflicted. For a workaround, it's better to name {{hadoopdev}. 3. Why 4094? Typo of 4096? {code} +--virtualbox-memory "4094" default {code} > Build instruction for docker toolbox > > > Key: HADOOP-12575 > URL: https://issues.apache.org/jira/browse/HADOOP-12575 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Reporter: Kai Sasaki >Assignee: Kai Sasaki >Priority: Trivial > Labels: docker, documentation > Attachments: HADOOP-12575.01.patch > > > Currently docker on MacOSX is mainly used by docker toolbox and > docker-machine. These tools make boot2docker deprecated. > (https://docs.docker.com/engine/installation/mac/) > It might be better to append the instruction of docker toolbox and > docker-machine when using {{start-build-env.sh}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12575) Build instruction for docker toolbox
[ https://issues.apache.org/jira/browse/HADOOP-12575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008081#comment-15008081 ] Hadoop QA commented on HADOOP-12575: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 8s {color} | {color:blue} docker + precommit patch detected. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 0m 34s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:date2015-11-17 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12772660/HADOOP-12575.01.patch | | JIRA Issue | HADOOP-12575 | | Optional Tests | asflicense | | uname | Linux 1a9335826bd2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-4659377/precommit/personality/hadoop.sh | | git revision | trunk / 007c6ce | | modules | C: . U: . | | Max memory used | 31MB | | Powered by | Apache Yetus http://yetus.apache.org | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/8079/console | This message was automatically generated. > Build instruction for docker toolbox > > > Key: HADOOP-12575 > URL: https://issues.apache.org/jira/browse/HADOOP-12575 > Project: Hadoop Common > Issue Type: Improvement > Components: documentation >Reporter: Kai Sasaki >Assignee: Kai Sasaki >Priority: Trivial > Labels: docker, documentation > Attachments: HADOOP-12575.01.patch > > > Currently docker on MacOSX is mainly used by docker toolbox and > docker-machine. These tools make boot2docker deprecated. > (https://docs.docker.com/engine/installation/mac/) > It might be better to append the instruction of docker toolbox and > docker-machine when using {{start-build-env.sh}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)