[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282104#comment-15282104 ] Allen Wittenauer commented on HADOOP-12581: --- +1 committed to trunk > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 3.0.0-alpha1 > > Attachments: HADOOP-12581.001.patch, HADOOP-12581.002.patch, > HADOOP-12581.003.patch > > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[
https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15282086#comment-15282086
]
Hadoop QA commented on HADOOP-12581:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
21s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 28s
{color} | {color:green} trunk passed with JDK v1.8.0_91 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 51s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
24s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
34s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} trunk passed with JDK v1.8.0_91 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 28s
{color} | {color:green} the patch passed with JDK v1.8.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 28s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 56s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 56s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 24s
{color} | {color:red} hadoop-common-project/hadoop-common: The patch generated
1 new + 19 unchanged - 1 fixed = 20 total (was 20) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 55s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s
{color} | {color:green} the patch passed with JDK v1.8.0_91 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 7s {color} |
{color:red} hadoop-common in the patch failed with JDK v1.8.0_91. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m 54s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 2s {color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_91 Failed junit tests | hadoop.ha.TestZKFailoverController |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:cf2ee45 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12793576/HADOOP-12581.003.patch
|
| JIRA Issue | HADOOP-12581 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname |
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[
https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195759#comment-15195759
]
Hadoop QA commented on HADOOP-12581:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
43s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 54s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 49s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 59s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
38s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s
{color} | {color:green} trunk passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s
{color} | {color:green} trunk passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 0s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 0s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 48s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m 48s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 21s
{color} | {color:red} hadoop-common-project/hadoop-common: patch generated 1
new + 19 unchanged - 1 fixed = 20 total (was 20) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 57s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
13s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s
{color} | {color:green} the patch passed with JDK v1.8.0_74 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 9s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.8.0_74.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 30s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.7.0_95.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 59m 40s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12793576/HADOOP-12581.003.patch
|
| JIRA Issue | HADOOP-12581 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 750611bbe7c8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[
https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052830#comment-15052830
]
Alan Burlison commented on HADOOP-12581:
What about other BSD variants? would {{OS.contains("BSD")}} work for them all?
> ShellBasedIdMapping needs suport for Solaris
>
>
> Key: HADOOP-12581
> URL: https://issues.apache.org/jira/browse/HADOOP-12581
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
>Affects Versions: 2.7.1
> Environment: Solaris
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Fix For: 3.0.0
>
> Attachments: HADOOP-12581.001.patch
>
>
> ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs
> adding.
> From looking at the Linux support in ShellBasedIdMapping, the same sequences
> of shell commands should work for Solaris as well so all that's probably
> needed is to change the implementation of checkSupportedPlatform() to treat
> Linux and Solaris the same way, plus possibly some renaming of other methods
> to make it more obvious they are not Linux-only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[
https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052799#comment-15052799
]
Dmitry Sivachenko commented on HADOOP-12581:
The same patch will be valid for FreeBSD, can we please add also relevant
OS.startswith("FreeBSD") too?
> ShellBasedIdMapping needs suport for Solaris
>
>
> Key: HADOOP-12581
> URL: https://issues.apache.org/jira/browse/HADOOP-12581
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
>Affects Versions: 2.7.1
> Environment: Solaris
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Fix For: 3.0.0
>
> Attachments: HADOOP-12581.001.patch
>
>
> ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs
> adding.
> From looking at the Linux support in ShellBasedIdMapping, the same sequences
> of shell commands should work for Solaris as well so all that's probably
> needed is to change the implementation of checkSupportedPlatform() to treat
> Linux and Solaris the same way, plus possibly some renaming of other methods
> to make it more obvious they are not Linux-only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052970#comment-15052970 ] Alan Burlison commented on HADOOP-12581: Ah, OK, I wasn't clear what you were saying :-) I'll make that change & update the patch. > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 3.0.0 > > Attachments: HADOOP-12581.001.patch > > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052941#comment-15052941 ] Alan Burlison commented on HADOOP-12581: According to https://netbeans.org/bugzilla/show_bug.cgi?id=145462 "OpenBSD" is returned for OpenBSD, not "FreeBSD". > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 3.0.0 > > Attachments: HADOOP-12581.001.patch > > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052958#comment-15052958 ] Alan Burlison commented on HADOOP-12581: See also https://commons.apache.org/proper/commons-lang/apidocs/src-html/org/apache/commons/lang3/SystemUtils.html#line.1179 > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 3.0.0 > > Attachments: HADOOP-12581.001.patch > > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[
https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052962#comment-15052962
]
Dmitry Sivachenko commented on HADOOP-12581:
I meant getent usage should be the same for *BSD and your proposal
OS.contains("BSD") should work for them all.
> ShellBasedIdMapping needs suport for Solaris
>
>
> Key: HADOOP-12581
> URL: https://issues.apache.org/jira/browse/HADOOP-12581
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
>Affects Versions: 2.7.1
> Environment: Solaris
>Reporter: Alan Burlison
>Assignee: Alan Burlison
> Fix For: 3.0.0
>
> Attachments: HADOOP-12581.001.patch
>
>
> ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs
> adding.
> From looking at the Linux support in ShellBasedIdMapping, the same sequences
> of shell commands should work for Solaris as well so all that's probably
> needed is to change the implementation of checkSupportedPlatform() to treat
> Linux and Solaris the same way, plus possibly some renaming of other methods
> to make it more obvious they are not Linux-only.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[
https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053724#comment-15053724
]
Hadoop QA commented on HADOOP-12581:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
20s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 4s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 34s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 8s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
59s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 7s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
43s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 6s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m 6s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 41s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m 41s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s
{color} | {color:red} Patch generated 1 new checkstyle issues in
hadoop-common-project/hadoop-common (total was 34, now 34). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 9s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 1s {color} |
{color:red} hadoop-common in the patch failed with JDK v1.8.0_66. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m 29s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.7.0_91.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 77m 9s {color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests | hadoop.metrics2.impl.TestGangliaMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12777165/HADOOP-12581.002.patch
|
| JIRA Issue | HADOOP-12581 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[
https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15053042#comment-15053042
]
Hadoop QA commented on HADOOP-12581:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
59s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 15s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 53s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 3s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
51s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 3s
{color} | {color:green} trunk passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
40s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 5s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 5s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 54s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 54s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s
{color} | {color:red} Patch generated 3 new checkstyle issues in
hadoop-common-project/hadoop-common (total was 34, now 36). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 2s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
58s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s
{color} | {color:green} the patch passed with JDK v1.7.0_91 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 24s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.8.0_66.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 20s
{color} | {color:green} hadoop-common in the patch passed with JDK v1.7.0_91.
{color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 70m 52s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:0ca8df7 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12777046/HADOOP-12581.001.patch
|
| JIRA Issue | HADOOP-12581 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux b0259cf2beb7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052836#comment-15052836 ] Dmitry Sivachenko commented on HADOOP-12581: According to man-pages, it should be the same for NetBSD and OpenBSD (and DragonflyBSD) > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > Fix For: 3.0.0 > > Attachments: HADOOP-12581.001.patch > > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011389#comment-15011389 ] Wei-Chiu Chuang commented on HADOOP-12581: -- What about ShellBasedUnixGroupMapping? ShellBasedUnixGroupMapping reads id command which is implemented in GNU coreutils. I suppose Solaris has different id command semantics? > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011486#comment-15011486 ] Alan Burlison commented on HADOOP-12581: There's this thing called POSIX that says how the things called UNIX are supposed to behave. It's so old it even predates CoreUtils ;-) http://pubs.opengroup.org/onlinepubs/9699919799/utilities/id.html The commands used by ShellBasedIdMapping are id, awk, cut and getent. The first 3 are all POSIX, and are used by ShellBasedIdMapping in a POSIX-compliant way. getent isn't POSIX but it originated in Solaris - the engineering discussion started 18 March 1991 and the first draft manpage was on 21 March, which only supported /etc/passwd and /etc/group. getent was subsequently copied by Linux so I think it's safe to assume the Linux version is compatible with the Solaris one :-) > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011503#comment-15011503 ] Wei-Chiu Chuang commented on HADOOP-12581: -- Thanks for the quick clarification :) I only asked this because I did notice the id command behaves slightly differently* on Mac than Linux (well, Mac is not POSIX-compliant anyway). So there are corner cases unspecified that differ between systems. * If a user has multiple groups and some of the groups numerical id can not be resolved to group names, Linux's id returns error code 1, while Mac's id returns error code 0 (See HADOOP-12468 https://issues.apache.org/jira/browse/HADOOP-12468) > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15011553#comment-15011553 ] Alan Burlison commented on HADOOP-12581: Hmm, interesting. On Solaris if the group name can't be resolved then the numeric id is output and 0 is returned as normal. We also have a /usr/xpg4/bin/id command, which is strictly POSIX-conformant, but I don't think the differences matter for this particular usage - they are to do with the behaviour of -a and supplemental groups. > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-12581) ShellBasedIdMapping needs suport for Solaris
[ https://issues.apache.org/jira/browse/HADOOP-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010945#comment-15010945 ] Dmitry Sivachenko commented on HADOOP-12581: That also sounds true for FreeBSD. I'll link this task from FreeBSD support ticket. > ShellBasedIdMapping needs suport for Solaris > > > Key: HADOOP-12581 > URL: https://issues.apache.org/jira/browse/HADOOP-12581 > Project: Hadoop Common > Issue Type: Sub-task > Components: security >Affects Versions: 2.7.1 > Environment: Solaris >Reporter: Alan Burlison >Assignee: Alan Burlison > > ShellBasedIdMapping only supports Linux and OSX, support for Solaris needs > adding. > From looking at the Linux support in ShellBasedIdMapping, the same sequences > of shell commands should work for Solaris as well so all that's probably > needed is to change the implementation of checkSupportedPlatform() to treat > Linux and Solaris the same way, plus possibly some renaming of other methods > to make it more obvious they are not Linux-only. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
