[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345571#comment-15345571
]
Sean Busbey commented on HADOOP-13298:
--
that only masks the problem in git. it doesn't impact that maven tooling will
presume something is amiss, since the build is not supposed to alter the source
directories.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/browser
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345578#comment-15345578
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
Got the point, thanks for your explanation.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/browser
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372395#comment-15372395
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
[~busbey] [~ajisakaa] [~xiaochen] I tested following points with the latest
patch: 1. hadoop-build-tools/src/main/resources/META-INF is not created, 2.
tar.gz includes LICENSE.txt and NOTICE.txt. Could you check it?
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/browser
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372643#comment-15372643
]
Hadoop QA commented on HADOOP-13298:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
54s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
1s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 9m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
2s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 96m 7s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}168m 5s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hdfs.TestRenameWhileOpen |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12817361/HADOOP-13298.002.patch
|
| JIRA Issue | HADOOP-13298 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux 4f4e4c0d4ecb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 819224d |
| Default Java | 1.8.0_91 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9966/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9966/testReport/ |
| modules | C: hadoop-build-tools . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9966/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373692#comment-15373692
]
Xiao Chen commented on HADOOP-13298:
Hi [~ozawa],
Thanks for working on this!
Unfortunately, this is what I did when hearing from Sean in the email
discussion, and it didn't work.
bq. 2. tar.gz includes LICENSE.txt and NOTICE.txt.
What we need is to include the L&N in the jars (META-INF sections in
particular). This can be verified by running the following script in
hadoop-dist dir after mvn package.
{code}
#!/bin/sh
for f in $(find ./target -name "hadoop*SNAPSHOT.jar"); do
jar -tf $f | grep "LICENSE" > /dev/null
RET1=$?
jar -tf $f | grep "NOTICE" > /dev/null
RET2=$?
if [ $RET1 -ne 0 -a $RET2 -ne 0 ]; then
echo $f "missing LICENSE and NOTICE!";
elif [ $RET1 -ne 0 ]; then
echo $f "missing LICENSE!";
elif [ $RET2 -ne 0 ]; then
echo $f "missing NOTICE!";
else
echo $f "is ok";
fi
done
{code}
The L&Ns are no longer copied into the jar with this change. :(
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374498#comment-15374498
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
I also used your script to confirm :-) It's very useful. IIUC, it should be
included in dev-support dir. Do you mind filing it as issue and creating a
patch?
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374592#comment-15374592
]
Hadoop QA commented on HADOOP-13298:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
26s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
6s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
26s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 6m
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 9m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
46s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 10m 58s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 78m 56s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.net.TestDNS |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12817608/HADOOP-13298.003.patch
|
| JIRA Issue | HADOOP-13298 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux be997f05f90f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 438b7c5 |
| Default Java | 1.8.0_91 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9978/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9978/testReport/ |
| modules | C: hadoop-build-tools . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/9978/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Pr
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15375652#comment-15375652
]
Xiao Chen commented on HADOOP-13298:
Thanks [~ozawa], Nice catch on the {{resourcesDirectory}}!
I created HADOOP-13374 for the script inclusion, and used that to verify patch
3 here works. +1 (non-binding).
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376110#comment-15376110
]
Akira Ajisaka commented on HADOOP-13298:
The latest patch does not work for me. I ran the followings:
{noformat}
$ git clean -d -f
$ dev-support/bin/smart-apply-patch HADOOP-13298
$ mvn clean
$ mvn install -DskipTests
{noformat}
That way I cannot see any LICENSE and NOTICE in all the jars. Maybe are the
LICENSE and NOTICE still in your main/resources/META-INF/?
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376120#comment-15376120
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
[~ajisakaa] I hit same issue yesterday, so could you check following things?
* Please confirm that you'er online: plugin must be downloaded.
* Please rebase it on trunk: I didn't take a look deeper, but it doesn't work
on code base.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376127#comment-15376127
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
{quote}
$ mvn install -DskipTests
{quote}
How to confirm is as follows:
{quote}
* mvn package -Pdist -DskipTests
{quote}
I think {{mvn install}} is not enough.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376141#comment-15376141
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
{quote}
I think mvn install is not enough.
{quote}
hmm, I'm wrong. Let me check...
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376619#comment-15376619
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
[~busbey] [~ajisakaa] [~xiaochen] could you try the v4 patch?
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376725#comment-15376725
]
Hadoop QA commented on HADOOP-13298:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
23s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m
8s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
17s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 9m
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
53s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 9m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 11m 40s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
19s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 75m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.metrics2.impl.TestGangliaMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12817608/HADOOP-13298.003.patch
|
| JIRA Issue | HADOOP-13298 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux dcf9dad0344a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / dbe97aa |
| Default Java | 1.8.0_91 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build//artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build//testReport/ |
| modules | C: hadoop-build-tools . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build//console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean B
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378328#comment-15378328
]
Akira Ajisaka commented on HADOOP-13298:
Thank you for the reply. I was online and the code base was latest.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378342#comment-15378342
]
Xiao Chen commented on HADOOP-13298:
Thanks for the new rev, [~ozawa].
My apologies to let patch 3 slip, my guess is I somehow verified in a wrong
dir..
I built using patch 4 (by {{mvn package}}), but the jar still seem to have no
L&N. I used the exact scripts in HADOOP-13374, and also manually spot checked a
jar.
BTW, I made this change to pass compilation locally. Not sure why jenkins
didn't complain about it.
{code:xml}
../
LICENSE.txt,NOTICE.txt
{code}
to
{code:xml}
../
NOTICE.txt
LICENSE.txt
{code}
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378788#comment-15378788
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
Thanks for the feedback, [~xiaochen] and [~ajisakaa].
I found an interesting result based on your feedbacks:
* v3 patch only works on Ubuntu.
* v4 patch only works on my Mac.
Anyway, I will try to create a patch work on both of them.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378795#comment-15378795
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
Or, my cleaning before trying is not enough. Let me check again.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15378833#comment-15378833
]
Xiao Chen commented on HADOOP-13298:
I tested v4 on Mac, but did {{mvn clean}} first and made sure no modified files
except the patch before compiling.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379156#comment-15379156
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
[~xiaochen] [~ajisakaa] thanks for the feedback. I found that that was my
mistake - there were old {{main/src/resources/META-INF}}, and
maven-remote-resource plugin picked up it. I'm sorry that I confuse you.
Updating a patch to fix:
* Adding {{resource}} section for remote-resources plugin's being able to
understand the location of L&N files.
* Adding {{resourcesDirectory}} to add entries for L&N files to
remote-resources.xml in jar file.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch, HADOOP-13298.005.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379377#comment-15379377
]
Hadoop QA commented on HADOOP-13298:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
48s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
43s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
35s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
6s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
3s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}144m 21s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
24s{color} | {color:red} The patch generated 2 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black}211m 15s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.yarn.server.TestMiniYarnClusterNodeUtilization |
| | hadoop.yarn.server.TestContainerManagerSecurity |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12818133/HADOOP-13298.005.patch
|
| JIRA Issue | HADOOP-13298 |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit xml |
| uname | Linux b4b7d49b4426 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed
Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / b5ee7db |
| Default Java | 1.8.0_91 |
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10008/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10008/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10008/artifact/patchprocess/patch-asflicense-problems.txt
|
| modules | C: hadoop-build-tools . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/10008/console |
| Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
>
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379682#comment-15379682
]
Xiao Chen commented on HADOOP-13298:
Thanks [~ozawa] for the new rev! I've verified it to work nicely. This is
definitely a better way to do it than the initial HADOOP-12893. :)
Failures seem unrelated to this patch, +1 (non-binding).
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch, HADOOP-13298.005.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379861#comment-15379861
]
Andrew Wang commented on HADOOP-13298:
--
I did a build and ran my earlier script, it just shows the hadoop-project-dist
JARs like before.
+1, thanks for working on this everyone!
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch, HADOOP-13298.005.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379866#comment-15379866
]
Akira Ajisaka commented on HADOOP-13298:
Thank [~ozawa] for updating the patch. +1, the patch works well except for
hadoop-project-dist module.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch, HADOOP-13298.005.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13298) Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
[
https://issues.apache.org/jira/browse/HADOOP-13298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15380272#comment-15380272
]
Tsuyoshi Ozawa commented on HADOOP-13298:
-
Thank you for the reviews! Checking this in.
hadoop-project-dist module doesn't include L&N files before the patch, so it's
OK.
> Fix the leftover L&N files in hadoop-build-tools/src/main/resources/META-INF/
> -
>
> Key: HADOOP-13298
> URL: https://issues.apache.org/jira/browse/HADOOP-13298
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha1
>Reporter: Xiao Chen
>Assignee: Sean Busbey
>Priority: Minor
> Attachments: HADOOP-13298.001.patch, HADOOP-13298.002.patch,
> HADOOP-13298.003.patch, HADOOP-13298.004.patch, HADOOP-13298.005.patch
>
>
> After HADOOP-12893, an extra copy of LICENSE.txt and NOTICE.txt exists in
> {{hadoop-build-tools/src/main/resources/META-INF/}} after build. We should
> remove it and do it the maven way.
> Details in
> https://mail-archives.apache.org/mod_mbox/hadoop-common-dev/201606.mbox/%3CCAFS=wjwx8nmqj6fzxuzzbwraeoggfr+_ywl_mkfp4lnuxpg...@mail.gmail.com%3E
> Thanks [~ste...@apache.org] for raising the issue and [~busbey] for offering
> the help!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
