[jira] [Commented] (HADOOP-13963) /bin/bash is hard coded in some of the scripts
[ https://issues.apache.org/jira/browse/HADOOP-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109218#comment-16109218 ] Ajay Yadav commented on HADOOP-13963: - [~miklos.szeg...@cloudera.com] I have made the changes. Please review the patch. > /bin/bash is hard coded in some of the scripts > -- > > Key: HADOOP-13963 > URL: https://issues.apache.org/jira/browse/HADOOP-13963 > Project: Hadoop Common > Issue Type: Bug >Reporter: Miklos Szegedi > Attachments: HADOOP-13963.01.patch > > > /bin/bash is hard coded in some of the scripts. We should consider using > #!/usr/bin/env bash at the beginning instead. > Candidates: > hadoop-functions_test_helper.bash > start-build-env.sh > findHangingTest.sh > verify-xml.sh > hadoop_env_checks.sh -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13963) /bin/bash is hard coded in some of the scripts
[ https://issues.apache.org/jira/browse/HADOOP-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109433#comment-16109433 ] Miklos Szegedi commented on HADOOP-13963: - LGTM (non-binding). Thank you for the patch [~ajayydv]. [~aw] do you have time to take a look? > /bin/bash is hard coded in some of the scripts > -- > > Key: HADOOP-13963 > URL: https://issues.apache.org/jira/browse/HADOOP-13963 > Project: Hadoop Common > Issue Type: Bug >Reporter: Miklos Szegedi >Assignee: Ajay Yadav > Attachments: HADOOP-13963.01.patch > > > /bin/bash is hard coded in some of the scripts. We should consider using > #!/usr/bin/env bash at the beginning instead. > Candidates: > hadoop-functions_test_helper.bash > start-build-env.sh > findHangingTest.sh > verify-xml.sh > hadoop_env_checks.sh -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13963) /bin/bash is hard coded in some of the scripts
[
https://issues.apache.org/jira/browse/HADOOP-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109461#comment-16109461
]
Hadoop QA commented on HADOOP-13963:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
30s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m
0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
26s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 10m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
1s{color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
10s{color} | {color:green} There were no new shelldocs issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 16m
43s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
35s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 54m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-13963 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12879871/HADOOP-13963.01.patch
|
| Optional Tests | asflicense mvnsite unit shellcheck shelldocs |
| uname | Linux 16b7b92faff4 3.13.0-119-generic #166-Ubuntu SMP Wed May 3
12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 91f120f |
| shellcheck | v0.4.6 |
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12916/testReport/ |
| modules | C: hadoop-common-project/hadoop-common . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12916/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> /bin/bash is hard coded in some of the scripts
> --
>
> Key: HADOOP-13963
> URL: https://issues.apache.org/jira/browse/HADOOP-13963
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Miklos Szegedi
>Assignee: Ajay Yadav
> Attachments: HADOOP-13963.01.patch
>
>
> /bin/bash is hard coded in some of the scripts. We should consider using
> #!/usr/bin/env bash at the beginning instead.
> Candidates:
> hadoop-functions_test_helper.bash
> start-build-env.sh
> findHangingTest.sh
> verify-xml.sh
> hadoop_env_checks.sh
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13963) /bin/bash is hard coded in some of the scripts
[ https://issues.apache.org/jira/browse/HADOOP-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114695#comment-16114695 ] Arpit Agarwal commented on HADOOP-13963: +1 lgtm. I will commit this shortly. > /bin/bash is hard coded in some of the scripts > -- > > Key: HADOOP-13963 > URL: https://issues.apache.org/jira/browse/HADOOP-13963 > Project: Hadoop Common > Issue Type: Bug >Reporter: Miklos Szegedi >Assignee: Ajay Yadav > Attachments: HADOOP-13963.01.patch > > > /bin/bash is hard coded in some of the scripts. We should consider using > #!/usr/bin/env bash at the beginning instead. > Candidates: > hadoop-functions_test_helper.bash > start-build-env.sh > findHangingTest.sh > verify-xml.sh > hadoop_env_checks.sh -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13963) /bin/bash is hard coded in some of the scripts
[ https://issues.apache.org/jira/browse/HADOOP-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114753#comment-16114753 ] Hudson commented on HADOOP-13963: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12119 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/12119/]) HADOOP-13963. /bin/bash is hard coded in some of the scripts. (arp: rev a6fdeb8a872d413c76257a32914ade1d0e944583) * (edit) dev-support/verify-xml.sh * (edit) dev-support/findHangingTest.sh * (edit) hadoop-common-project/hadoop-common/src/test/scripts/hadoop-functions_test_helper.bash * (edit) dev-support/docker/hadoop_env_checks.sh * (edit) start-build-env.sh > /bin/bash is hard coded in some of the scripts > -- > > Key: HADOOP-13963 > URL: https://issues.apache.org/jira/browse/HADOOP-13963 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Miklos Szegedi >Assignee: Ajay Yadav > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-13963.01.patch > > > /bin/bash is hard coded in some of the scripts. We should consider using > #!/usr/bin/env bash at the beginning instead. > Candidates: > hadoop-functions_test_helper.bash > start-build-env.sh > findHangingTest.sh > verify-xml.sh > hadoop_env_checks.sh -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13963) /bin/bash is hard coded in some of the scripts
[ https://issues.apache.org/jira/browse/HADOOP-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114902#comment-16114902 ] Ajay Yadav commented on HADOOP-13963: - Thanks Arpit! > /bin/bash is hard coded in some of the scripts > -- > > Key: HADOOP-13963 > URL: https://issues.apache.org/jira/browse/HADOOP-13963 > Project: Hadoop Common > Issue Type: Bug > Components: scripts >Reporter: Miklos Szegedi >Assignee: Ajay Yadav > Fix For: 3.0.0-beta1 > > Attachments: HADOOP-13963.01.patch > > > /bin/bash is hard coded in some of the scripts. We should consider using > #!/usr/bin/env bash at the beginning instead. > Candidates: > hadoop-functions_test_helper.bash > start-build-env.sh > findHangingTest.sh > verify-xml.sh > hadoop_env_checks.sh -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-13963) /bin/bash is hard coded in some of the scripts
[ https://issues.apache.org/jira/browse/HADOOP-13963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15812696#comment-15812696 ] Miklos Szegedi commented on HADOOP-13963: - This bug was opened based on the discussion with [~aw] in YARN-6060. > /bin/bash is hard coded in some of the scripts > -- > > Key: HADOOP-13963 > URL: https://issues.apache.org/jira/browse/HADOOP-13963 > Project: Hadoop Common > Issue Type: Bug >Reporter: Miklos Szegedi > > /bin/bash is hard coded in some of the scripts. We should consider using > #!/usr/bin/env bash at the beginning instead. > Candidates: > hadoop-functions_test_helper.bash > start-build-env.sh > findHangingTest.sh > verify-xml.sh > hadoop_env_checks.sh -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
