[jira] [Commented] (HADOOP-14309) PowerShellFencer
[
https://issues.apache.org/jira/browse/HADOOP-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982227#comment-15982227
]
Inigo Goiri commented on HADOOP-14309:
--
Thanks [~chris.douglas] for the review.
The filter is kind of tricky because it should parse the whole class name which
is passed to java.exe to start.
In this case, I'm leaving the option for the administrator to set whatever in
the CommandLine filter.
The current SSH bases it on the port number.
I'll fix the findbugs and the {{deleteOnExit}}.
> PowerShellFencer
>
>
> Key: HADOOP-14309
> URL: https://issues.apache.org/jira/browse/HADOOP-14309
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ha
>Affects Versions: 2.8.0
>Reporter: Inigo Goiri
>Assignee: Inigo Goiri
>Priority: Minor
> Attachments: HADOOP-14309-000.patch
>
>
> Fencer implementation that uses PowerShell to fence a remote component.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14309) PowerShellFencer
[
https://issues.apache.org/jira/browse/HADOOP-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982109#comment-15982109
]
Chris Douglas commented on HADOOP-14309:
Looks reasonable, given my rudimentary PowerShell. Does the commandline include
some unique string? Should this fail if this matches more than one process at
the remote host?
+1 if the findbugs warning is fixed. This could also call {{deleteOnExit}} on
the temp file instance.
> PowerShellFencer
>
>
> Key: HADOOP-14309
> URL: https://issues.apache.org/jira/browse/HADOOP-14309
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ha
>Affects Versions: 2.8.0
>Reporter: Inigo Goiri
>Assignee: Inigo Goiri
>Priority: Minor
> Attachments: HADOOP-14309-000.patch
>
>
> Fencer implementation that uses PowerShell to fence a remote component.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14309) PowerShellFencer
[
https://issues.apache.org/jira/browse/HADOOP-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969626#comment-15969626
]
Hadoop QA commented on HADOOP-14309:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
15s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 13m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
38s{color} | {color:red} hadoop-common-project/hadoop-common generated 1 new +
0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 8m 4s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
34s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 63m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Found reliance on default encoding in
org.apache.hadoop.ha.PowerShellFencer.buildPSScript(String, String):in
org.apache.hadoop.ha.PowerShellFencer.buildPSScript(String, String): new
java.io.FileWriter(File) At PowerShellFencer.java:[line 109] |
| Failed junit tests | hadoop.security.TestKDiag |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:612578f |
| JIRA Issue | HADOOP-14309 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12863504/HADOOP-14309-000.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 3145e4a5d21a 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / a41f8dd |
| Default Java | 1.8.0_121 |
| findbugs | v3.0.0 |
| findbugs |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12105/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12105/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12105/testReport/ |
| modules | C: hadoop-common-p
[jira] [Commented] (HADOOP-14309) PowerShellFencer
[
https://issues.apache.org/jira/browse/HADOOP-14309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969552#comment-15969552
]
Inigo Goiri commented on HADOOP-14309:
--
To enable the fencing mechanism for HDFS HA, one could set:
{code}
dfs.ha.fencing.methods
powershell(NameNode)
{code}
> PowerShellFencer
>
>
> Key: HADOOP-14309
> URL: https://issues.apache.org/jira/browse/HADOOP-14309
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ha
>Affects Versions: 2.8.0
>Reporter: Inigo Goiri
>Assignee: Inigo Goiri
>Priority: Minor
> Attachments: HADOOP-14309-000.patch
>
>
> Fencer implementation that uses PowerShell to fence a remote component.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
