[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038067#comment-16038067
]
Brahma Reddy Battula commented on HADOOP-14431:
---
Looks, it's not pushed.. I push it..
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Hongyuan Li
>Assignee: Hongyuan Li
> Fix For: 2.9.0, 3.0.0-alpha4
>
> Attachments: HADOOP-14431-001.patch, HADOOP-14431-002.patch
>
>
> {{getFileStatus(ChannelSftp channel, LsEntry sftpFile, Path parentPath)}}
> get FileStatus as code below:
> {code}
> private FileStatus getFileStatus(ChannelSftp channel, LsEntry sftpFile,
> Path parentPath) throws IOException {
> SftpATTRS attr = sftpFile.getAttrs();
>……
> long modTime = attr.getMTime() * 1000; // convert to milliseconds
>……
> }
> {code}
> ,which {{attr.getMTime}} return int, which meansthe modTime is wrong
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038044#comment-16038044
]
Hongyuan Li commented on HADOOP-14431:
--
[~brahmareddy] on trunk and branch-2long modTime = attr.getMTime() * 1000;
// convert to milliseconds is still wring, what happend?
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Hongyuan Li
>Assignee: Hongyuan Li
> Fix For: 2.9.0, 3.0.0-alpha4
>
> Attachments: HADOOP-14431-001.patch, HADOOP-14431-002.patch
>
>
> {{getFileStatus(ChannelSftp channel, LsEntry sftpFile, Path parentPath)}}
> get FileStatus as code below:
> {code}
> private FileStatus getFileStatus(ChannelSftp channel, LsEntry sftpFile,
> Path parentPath) throws IOException {
> SftpATTRS attr = sftpFile.getAttrs();
>……
> long modTime = attr.getMTime() * 1000; // convert to milliseconds
>……
> }
> {code}
> ,which {{attr.getMTime}} return int, which meansthe modTime is wrong
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026310#comment-16026310
]
Hongyuan Li commented on HADOOP-14431:
--
[~ste...@apache.org] [~brahmareddy] None of the findbugs/unit test warnings
seem to be related to the change.
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Hongyuan Li
>Assignee: Hongyuan Li
> Attachments: HADOOP-14431-001.patch, HADOOP-14431-002.patch
>
>
> {{getFileStatus(ChannelSftp channel, LsEntry sftpFile, Path parentPath)}}
> get FileStatus as code below:
> {code}
> private FileStatus getFileStatus(ChannelSftp channel, LsEntry sftpFile,
> Path parentPath) throws IOException {
> SftpATTRS attr = sftpFile.getAttrs();
>……
> long modTime = attr.getMTime() * 1000; // convert to milliseconds
>……
> }
> {code}
> ,which {{attr.getMTime}} return int, which meansthe modTime is wrong
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026265#comment-16026265
]
Hadoop QA commented on HADOOP-14431:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 15m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 17m
4s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
21s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
57s{color} | {color:red} hadoop-common-project/hadoop-common in trunk has 19
extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 16m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m
32s{color} | {color:green} hadoop-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
53s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 72m 59s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14431 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12870047/HADOOP-14431-002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 7be74a57071d 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20
09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / 47474ff |
| Default Java | 1.8.0_131 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12398/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12398/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/12398/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>
[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026191#comment-16026191
]
Hongyuan Li commented on HADOOP-14431:
--
Oh,that's ok.
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Hongyuan Li
>Assignee: Hongyuan Li
> Attachments: HADOOP-14431-001.patch, HADOOP-14431-002.patch
>
>
> {{getFileStatus(ChannelSftp channel, LsEntry sftpFile, Path parentPath)}}
> get FileStatus as code below:
> {code}
> private FileStatus getFileStatus(ChannelSftp channel, LsEntry sftpFile,
> Path parentPath) throws IOException {
> SftpATTRS attr = sftpFile.getAttrs();
>……
> long modTime = attr.getMTime() * 1000; // convert to milliseconds
>……
> }
> {code}
> ,which {{attr.getMTime}} return int, which meansthe modTime is wrong
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026186#comment-16026186
]
Brahma Reddy Battula commented on HADOOP-14431:
---
[~Hongyuan Li] Nice finding.. +1 on latest patch.. Sorry,for delayed response..
Pending for jenkins..
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Hongyuan Li
>Assignee: Hongyuan Li
> Attachments: HADOOP-14431-001.patch, HADOOP-14431-002.patch
>
>
> {{getFileStatus(ChannelSftp channel, LsEntry sftpFile, Path parentPath)}}
> get FileStatus as code below:
> {code}
> private FileStatus getFileStatus(ChannelSftp channel, LsEntry sftpFile,
> Path parentPath) throws IOException {
> SftpATTRS attr = sftpFile.getAttrs();
>……
> long modTime = attr.getMTime() * 1000; // convert to milliseconds
>……
> }
> {code}
> ,which {{attr.getMTime}} return int, which meansthe modTime is wrong
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026141#comment-16026141
]
Hongyuan Li commented on HADOOP-14431:
--
ok
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Hongyuan Li
>Assignee: Hongyuan Li
> Attachments: HADOOP-14431-001.patch
>
>
> {{getFileStatus(ChannelSftp channel, LsEntry sftpFile, Path parentPath)}}
> get FileStatus as code below:
> {code}
> private FileStatus getFileStatus(ChannelSftp channel, LsEntry sftpFile,
> Path parentPath) throws IOException {
> SftpATTRS attr = sftpFile.getAttrs();
>……
> long modTime = attr.getMTime() * 1000; // convert to milliseconds
>……
> }
> {code}
> ,which {{attr.getMTime}} return int, which meansthe modTime is wrong
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026065#comment-16026065
]
Steve Loughran commented on HADOOP-14431:
-
Code looks good, but you're going to have to resubmit a patch which works with
the current code; there's merge conflict now your other patch has gone in
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Hongyuan Li
>Assignee: Hongyuan Li
> Attachments: HADOOP-14431-001.patch
>
>
> {{getFileStatus(ChannelSftp channel, LsEntry sftpFile, Path parentPath)}}
> get FileStatus as code below:
> {code}
> private FileStatus getFileStatus(ChannelSftp channel, LsEntry sftpFile,
> Path parentPath) throws IOException {
> SftpATTRS attr = sftpFile.getAttrs();
>……
> long modTime = attr.getMTime() * 1000; // convert to milliseconds
>……
> }
> {code}
> ,which {{attr.getMTime}} return int, which meansthe modTime is wrong
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-14431) the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus method is wrong
[
https://issues.apache.org/jira/browse/HADOOP-14431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025672#comment-16025672
]
Hongyuan Li commented on HADOOP-14431:
--
[~ste...@apache.org] Could you give me a code review?
> the modifyTime of FileStatus returned by SFTPFileSystem's getFileStatus
> method is wrong
> ---
>
> Key: HADOOP-14431
> URL: https://issues.apache.org/jira/browse/HADOOP-14431
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
>Reporter: Hongyuan Li
>Assignee: Hongyuan Li
> Attachments: HADOOP-14431-001.patch
>
>
> {{getFileStatus(ChannelSftp channel, LsEntry sftpFile, Path parentPath)}}
> get FileStatus as code below:
> {code}
> private FileStatus getFileStatus(ChannelSftp channel, LsEntry sftpFile,
> Path parentPath) throws IOException {
> SftpATTRS attr = sftpFile.getAttrs();
>……
> long modTime = attr.getMTime() * 1000; // convert to milliseconds
>……
> }
> {code}
> ,which {{attr.getMTime}} return int, which meansthe modTime is wrong
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
