[jira] [Commented] (HADOOP-15173) Possible dead code in CombineFileInputFormat

2018-01-15 Thread Lior Regev (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326802#comment-16326802
 ] 

Lior Regev commented on HADOOP-15173:
-

I forgot to mention in the issue but creating OneFileInfo is performing a 
side-effect of fetching file infos, which, in cases where one is accessing a 
remote service (s3 for example) might actually give a performance hit

> Possible dead code in CombineFileInputFormat
> 
>
> Key: HADOOP-15173
> URL: https://issues.apache.org/jira/browse/HADOOP-15173
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Lior Regev
>Priority: Minor
>  Labels: newbie
>
> I found that in the file:
> hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/CombineFileInputFormat.java:280
> There's a generation of OneFileInfo[] without using that array ever again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15173) Possible dead code in CombineFileInputFormat

2018-01-15 Thread Akira Ajisaka (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326801#comment-16326801
 ] 

Akira Ajisaka commented on HADOOP-15173:


Yes, we don't need to create the array.

> Possible dead code in CombineFileInputFormat
> 
>
> Key: HADOOP-15173
> URL: https://issues.apache.org/jira/browse/HADOOP-15173
> Project: Hadoop Common
>  Issue Type: Bug
>Reporter: Lior Regev
>Priority: Minor
>  Labels: newbie
>
> I found that in the file:
> hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/CombineFileInputFormat.java:280
> There's a generation of OneFileInfo[] without using that array ever again.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org