[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-28 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417755#comment-16417755
 ] 

Íñigo Goiri commented on HADOOP-15345:
--

[^HADOOP-15345-branch-2.7.001.patch] already took care of the conflicts.
Committed to branch-2.7.
Thanks [~hexiaoqiao] for working on this and [~ajayydv], [~shahrs87] for the 
review.

> Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient 
> adding/getting/removing nodes
> ---
>
> Key: HADOOP-15345
> URL: https://issues.apache.org/jira/browse/HADOOP-15345
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: He Xiaoqiao
>Priority: Major
> Attachments: HADOOP-15345-branch-2.7.001.patch
>
>
> As per discussion in HADOOP-15343 backport HADOOP-12185 to branch-2.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-28 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417744#comment-16417744
 ] 

Íñigo Goiri commented on HADOOP-15345:
--

+1.
Let me try to commit the attached patch.
Otherwise, I'll post the compatible patch.

> Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient 
> adding/getting/removing nodes
> ---
>
> Key: HADOOP-15345
> URL: https://issues.apache.org/jira/browse/HADOOP-15345
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: He Xiaoqiao
>Priority: Major
> Attachments: HADOOP-15345-branch-2.7.001.patch
>
>
> As per discussion in HADOOP-15343 backport HADOOP-12185 to branch-2.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-28 Thread Rushabh S Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417384#comment-16417384
 ] 

Rushabh S Shah commented on HADOOP-15345:
-

bq. And the conflict part is all about package import.
Then I am +1 non-binding.

> Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient 
> adding/getting/removing nodes
> ---
>
> Key: HADOOP-15345
> URL: https://issues.apache.org/jira/browse/HADOOP-15345
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: He Xiaoqiao
>Priority: Major
> Attachments: HADOOP-15345-branch-2.7.001.patch
>
>
> As per discussion in HADOOP-15343 backport HADOOP-12185 to branch-2.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-28 Thread Rushabh S Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417382#comment-16417382
 ] 

Rushabh S Shah commented on HADOOP-15345:
-

bq. I have resolved the conflict after cherry-pick
Can you paste the conflict ?

> Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient 
> adding/getting/removing nodes
> ---
>
> Key: HADOOP-15345
> URL: https://issues.apache.org/jira/browse/HADOOP-15345
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: He Xiaoqiao
>Priority: Major
> Attachments: HADOOP-15345-branch-2.7.001.patch
>
>
> As per discussion in HADOOP-15343 backport HADOOP-12185 to branch-2.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-28 Thread He Xiaoqiao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417379#comment-16417379
 ] 

He Xiaoqiao commented on HADOOP-15345:
--

Thanks [~shahrs87] for your review.
I have resolved the conflict after cherry-pick the patch from branch-2.8.

> Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient 
> adding/getting/removing nodes
> ---
>
> Key: HADOOP-15345
> URL: https://issues.apache.org/jira/browse/HADOOP-15345
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: He Xiaoqiao
>Priority: Major
> Attachments: HADOOP-15345-branch-2.7.001.patch
>
>
> As per discussion in HADOOP-15343 backport HADOOP-12185 to branch-2.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-28 Thread Rushabh S Shah (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16417335#comment-16417335
 ] 

Rushabh S Shah commented on HADOOP-15345:
-

[~hexiaoqiao]: thanks for the patch.
Was the backport without any conflict  ? 
If yes, then I am +1 (non-binding).
If no, please post the diff and then I can review.

> Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient 
> adding/getting/removing nodes
> ---
>
> Key: HADOOP-15345
> URL: https://issues.apache.org/jira/browse/HADOOP-15345
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: He Xiaoqiao
>Priority: Major
> Attachments: HADOOP-15345-branch-2.7.001.patch
>
>
> As per discussion in HADOOP-15343 backport HADOOP-12185 to branch-2.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-27 Thread He Xiaoqiao (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416844#comment-16416844
 ] 

He Xiaoqiao commented on HADOOP-15345:
--

Thanks [~ajayydv] for your comments.
ping [~elgoiri],[~shahrs87], any suggestions for this issue?

> Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient 
> adding/getting/removing nodes
> ---
>
> Key: HADOOP-15345
> URL: https://issues.apache.org/jira/browse/HADOOP-15345
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: He Xiaoqiao
>Priority: Major
> Attachments: HADOOP-15345-branch-2.7.001.patch
>
>
> As per discussion in HADOOP-15343 backport HADOOP-12185 to branch-2.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-27 Thread Ajay Kumar (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416347#comment-16416347
 ] 

Ajay Kumar commented on HADOOP-15345:
-

+1

> Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient 
> adding/getting/removing nodes
> ---
>
> Key: HADOOP-15345
> URL: https://issues.apache.org/jira/browse/HADOOP-15345
> Project: Hadoop Common
>  Issue Type: Improvement
>Affects Versions: 2.7.6
>Reporter: He Xiaoqiao
>Priority: Major
> Attachments: HADOOP-15345-branch-2.7.001.patch
>
>
> As per discussion in HADOOP-15343 backport HADOOP-12185 to branch-2.7



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

[jira] [Commented] (HADOOP-15345) Backport HADOOP-12185 to branch-2.7: NetworkTopology is not efficient adding/getting/removing nodes

2018-03-27 Thread genericqa (JIRA) 

[ 
https://issues.apache.org/jira/browse/HADOOP-15345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16415136#comment-16415136
 ] 

genericqa commented on HADOOP-15345:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 11m  
4s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} branch-2.7 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
10s{color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
33s{color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
55s{color} | {color:green} branch-2.7 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} branch-2.7 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  6m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  6m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
21s{color} | {color:green} hadoop-common-project/hadoop-common: The patch 
generated 0 new + 64 unchanged - 1 fixed = 64 total (was 65) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
47s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
0s{color} | {color:red} The patch has 65 line(s) that end in whitespace. Use 
git apply --whitespace=fix <>. Refer 
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m  1s{color} 
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
23s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 58m 24s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ha.TestZKFailoverControllerStress |
|   | hadoop.util.bloom.TestBloomFilters |
|   | hadoop.ipc.TestCallQueueManager |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:06eafee |
| JIRA Issue | HADOOP-15345 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12916342/HADOOP-15345-branch-2.7.001.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  shadedclient  findbugs  checkstyle  |
| uname | Linux 90933f24cd54 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | branch-2.7 / 94bb6fa |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.7.0_151 |
| whitespace | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/14393/artifact/out/whitespace-eol.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/14393/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/14393/testReport/ |
| Max. process+thread count | 482 (vs. ulimit of 1) |
| modules | C: hadoop-common-project/hadoop-common U: 
hadoop-common-project/hadoop-common |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/14393/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Backport HADOOP-12185