[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942107#comment-16942107 ] Wei-Chiu Chuang commented on HADOOP-15418: -- Commit still applies in branch-3.1 and branch-3.2 I'll cherry pick it to these two branches. > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > Fix For: 3.3.0 > > Attachments: HADOOP-15418.1.patch, HADOOP-15418.2.patch, > HADOOP-15418.3.patch > > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656469#comment-16656469 ] lqjacklee commented on HADOOP-15418: [~suma.shivaprasad] [~jojochuang] sorry update too late. > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > Fix For: 3.3.0 > > Attachments: HADOOP-15418.1.patch, HADOOP-15418.2.patch, > HADOOP-15418.3.patch > > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656126#comment-16656126 ] Hudson commented on HADOOP-15418: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15264 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/15264/]) HADOOP-15418. Hadoop KMSAuthenticationFilter needs to use (weichiu: rev cd2158456db8c89eeea64b72654a736ea8607e23) * (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSAuthenticationFilter.java * (add) hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMSAuthenticationFilter.java > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > Fix For: 3.3.0 > > Attachments: HADOOP-15418.1.patch, HADOOP-15418.2.patch, > HADOOP-15418.3.patch > > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656081#comment-16656081 ] Wei-Chiu Chuang commented on HADOOP-15418: -- +1. HADOOP-15411 made Configuration.getPropsWithPrefix() thread-safe, so use that API instead to avoid ConcurrentModificationException. (Although I don't think this is a problem in the context of KMS server). Patch rev 002 has a trivial checkstyle warning. I can fix that and post a rev003 for posterity. > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > Attachments: HADOOP-15418.1.patch, HADOOP-15418.2.patch > > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655885#comment-16655885 ] Hadoop QA commented on HADOOP-15418: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 16s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 1s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 16m 0s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 34s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 12m 43s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 36s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 27s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 14m 44s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 24s{color} | {color:orange} hadoop-common-project/hadoop-kms: The patch generated 1 new + 4 unchanged - 0 fixed = 5 total (was 4) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 34s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 19s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 8s{color} | {color:green} hadoop-kms in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 40s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 85m 11s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 | | JIRA Issue | HADOOP-15418 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12944612/HADOOP-15418.2.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 9736582c0338 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / beb850d | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/15390/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-kms.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/15390/testReport/ | | Max. process+thread count | 307 (vs. ulimit of 1) | | modules | C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/15390/console | | Powered by | Apache Yetus 0.8.0
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655800#comment-16655800 ] Suma Shivaprasad commented on HADOOP-15418: --- Fixed Checkstyle and ASF License. > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > Attachments: HADOOP-15418.1.patch, HADOOP-15418.2.patch > > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655734#comment-16655734 ] Hadoop QA commented on HADOOP-15418: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 21m 3s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 22m 57s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 39s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 14m 4s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 49s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 35s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 20m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 20m 51s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 32s{color} | {color:orange} hadoop-common-project/hadoop-kms: The patch generated 10 new + 4 unchanged - 0 fixed = 14 total (was 4) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 13m 5s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m 35s{color} | {color:green} hadoop-kms in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 58s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}104m 50s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 | | JIRA Issue | HADOOP-15418 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12944579/HADOOP-15418.1.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux b554b964c342 3.13.0-144-generic #193-Ubuntu SMP Thu Mar 15 17:03:53 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / ba7e816 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/15389/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-kms.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/15389/testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-HADOOP-Build/15389/artifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 308 (vs. ulimit of 1) | | modules | C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms | | Console output |
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654537#comment-16654537 ] Suma Shivaprasad commented on HADOOP-15418: --- @lqjack I am planning to provide a patch with UTs added and a few other minor changes if you are not planning to work on this. > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476482#comment-16476482 ] Suma Shivaprasad commented on HADOOP-15418: --- @lqjack Can you pls add a UT for the patch else do you mind if I take it to completion? > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457181#comment-16457181 ] Suma Shivaprasad commented on HADOOP-15418: --- [~lqjack] Thanks for the patch . Can you add a UT to test this change. > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456840#comment-16456840 ] lqjack commented on HADOOP-15418: - https://github.com/apache/hadoop/pull/369 > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15418) Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of iterator to avoid ConcurrentModificationException
[ https://issues.apache.org/jira/browse/HADOOP-15418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456838#comment-16456838 ] ASF GitHub Bot commented on HADOOP-15418: - GitHub user lqjack opened a pull request: https://github.com/apache/hadoop/pull/369 HADOOP-15418 fix ConcurrentModifyException You can merge this pull request into a Git repository by running: $ git pull https://github.com/lqjack/hadoop HADOOP-15418 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/369.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #369 commit 22b095f90e349eabc41ba3177d8c1b6e094dcc42 Author: lqjacleeDate: 2018-04-27T17:55:18Z HADOOP-15418 fix ConcurrentModifyException > Hadoop KMSAuthenticationFilter needs to use getPropsByPrefix instead of > iterator to avoid ConcurrentModificationException > - > > Key: HADOOP-15418 > URL: https://issues.apache.org/jira/browse/HADOOP-15418 > Project: Hadoop Common > Issue Type: Bug > Components: common >Reporter: Suma Shivaprasad >Assignee: Suma Shivaprasad >Priority: Major > > The issue is similar to what was fixed in HADOOP-15411. Fixing this in > KMSAuthenticationFilter as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org