[jira] [Commented] (HADOOP-15802) start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} file entry
[ https://issues.apache.org/jira/browse/HADOOP-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648900#comment-16648900 ] Jon Boone commented on HADOOP-15802: My first thought was to add the '-e' option to the echo command being called in line 64: ??RUN echo "${USER_NAME}\tALL=NOPASSWD: ALL" > "/etc/sudoers.d/hadoop-build-${USER_ID}"?? as this command is running inside a docker container which is running Linux. > start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} > file entry > --- > > Key: HADOOP-15802 > URL: https://issues.apache.org/jira/browse/HADOOP-15802 > Project: Hadoop Common > Issue Type: Bug > Components: common > Environment: Ubuntu 18.04 x86_64 running in a VM with 4 CPUs / 8 GBs > RAM / 128 GB disk. >Reporter: Jon Boone >Priority: Minor > > In my Ubuntu 18.04 dev VM, I cloned the hadoop repo and ran the > start-build-env.sh script. Once the docker build was completed and the > container running, I tried to sudo and it failed. Upon investigation, I > discovered that it was creating an entry in > /etc/sudoers.d/hadoop-build-${USER_ID} that contained the characters '\t' > rather than a tab. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15802) start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} file entry
[ https://issues.apache.org/jira/browse/HADOOP-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649224#comment-16649224 ] Hadoop QA commented on HADOOP-15802: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 26s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m 52s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 13m 18s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 53s{color} | {color:green} branch has no errors when building and testing our client artifacts. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 19m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 11m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 0s{color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m 13s{color} | {color:green} There were no new shelldocs issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 11m 33s{color} | {color:green} patch has no errors when building and testing our client artifacts. {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 17m 49s{color} | {color:green} root in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 46s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}110m 57s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:4b8c2b1 | | JIRA Issue | HADOOP-15802 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12943802/HADOOP-15802.001.patch | | Optional Tests | dupname asflicense mvnsite unit shellcheck shelldocs | | uname | Linux 0cfca0b23943 3.13.0-144-generic #193-Ubuntu SMP Thu Mar 15 17:03:53 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 5209c75 | | maven | version: Apache Maven 3.3.9 | | shellcheck | v0.4.6 | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/15363/testReport/ | | Max. process+thread count | 316 (vs. ulimit of 1) | | modules | C: . U: . | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/15363/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} > file entry > --- > > Key: HADOOP-15802 > URL: https://issues.apache.org/jira/browse/HADOOP-15802 > Project: Hadoop Common > Issue Type: Bug > Components: common > Environment: Ubuntu 18.04 x86_64 running in a VM with 4 CPUs / 8 GBs > RAM / 128 GB disk. >Reporter: Jon Boone >Priority: Minor > Attachments: HADOOP-15802.001.patch > > > In my Ubuntu 18.04 dev VM, I cloned the hadoop repo and ran the > start-build-env.sh script. Once the docker build was completed and the > container running, I tried to sudo and it failed. Upon investigation, I > discovered that it was creating an entry in > /etc/sudoers.d/hadoop-build-${USER_ID} that contained the characters '\t' > rather than a tab. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --
[jira] [Commented] (HADOOP-15802) start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} file entry
[ https://issues.apache.org/jira/browse/HADOOP-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649226#comment-16649226 ] Jon Boone commented on HADOOP-15802: It doesn't appear that there are any tests for _start-build-env.sh_, so I didn't modify or add any. > start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} > file entry > --- > > Key: HADOOP-15802 > URL: https://issues.apache.org/jira/browse/HADOOP-15802 > Project: Hadoop Common > Issue Type: Bug > Components: common > Environment: Ubuntu 18.04 x86_64 running in a VM with 4 CPUs / 8 GBs > RAM / 128 GB disk. >Reporter: Jon Boone >Priority: Minor > Attachments: HADOOP-15802.001.patch > > > In my Ubuntu 18.04 dev VM, I cloned the hadoop repo and ran the > start-build-env.sh script. Once the docker build was completed and the > container running, I tried to sudo and it failed. Upon investigation, I > discovered that it was creating an entry in > /etc/sudoers.d/hadoop-build-${USER_ID} that contained the characters '\t' > rather than a tab. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15802) start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} file entry
[ https://issues.apache.org/jira/browse/HADOOP-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652778#comment-16652778 ] Akira Ajisaka commented on HADOOP-15802: +1, nice catch! > start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} > file entry > --- > > Key: HADOOP-15802 > URL: https://issues.apache.org/jira/browse/HADOOP-15802 > Project: Hadoop Common > Issue Type: Bug > Components: common > Environment: Ubuntu 18.04 x86_64 running in a VM with 4 CPUs / 8 GBs > RAM / 128 GB disk. >Reporter: Jon Boone >Priority: Minor > Attachments: HADOOP-15802.001.patch > > > In my Ubuntu 18.04 dev VM, I cloned the hadoop repo and ran the > start-build-env.sh script. Once the docker build was completed and the > container running, I tried to sudo and it failed. Upon investigation, I > discovered that it was creating an entry in > /etc/sudoers.d/hadoop-build-${USER_ID} that contained the characters '\t' > rather than a tab. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15802) start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} file entry
[ https://issues.apache.org/jira/browse/HADOOP-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652813#comment-16652813 ] Hudson commented on HADOOP-15802: - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15236 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/15236/]) HADOOP-15802. start-build-env.sh creates an invalid (aajisaka: rev e3342a1abaff71823ebd952baf24a6143e711b99) * (edit) start-build-env.sh > start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} > file entry > --- > > Key: HADOOP-15802 > URL: https://issues.apache.org/jira/browse/HADOOP-15802 > Project: Hadoop Common > Issue Type: Bug > Components: common > Environment: Ubuntu 18.04 x86_64 running in a VM with 4 CPUs / 8 GBs > RAM / 128 GB disk. >Reporter: Jon Boone >Assignee: Jon Boone >Priority: Minor > Fix For: 3.2.0, 3.1.2 > > Attachments: HADOOP-15802.001.patch > > > In my Ubuntu 18.04 dev VM, I cloned the hadoop repo and ran the > start-build-env.sh script. Once the docker build was completed and the > container running, I tried to sudo and it failed. Upon investigation, I > discovered that it was creating an entry in > /etc/sudoers.d/hadoop-build-${USER_ID} that contained the characters '\t' > rather than a tab. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15802) start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} file entry
[ https://issues.apache.org/jira/browse/HADOOP-15802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679323#comment-16679323 ] Akira Ajisaka commented on HADOOP-15802: I found this fix is not correct. Please see HADOOP-15912 for the detail. > start-build-env.sh creates an invalid /etc/sudoers.d/hadoop-build-${USER_ID} > file entry > --- > > Key: HADOOP-15802 > URL: https://issues.apache.org/jira/browse/HADOOP-15802 > Project: Hadoop Common > Issue Type: Bug > Components: common > Environment: Ubuntu 18.04 x86_64 running in a VM with 4 CPUs / 8 GBs > RAM / 128 GB disk. >Reporter: Jon Boone >Assignee: Jon Boone >Priority: Minor > Fix For: 3.2.0, 3.1.2 > > Attachments: HADOOP-15802.001.patch > > > In my Ubuntu 18.04 dev VM, I cloned the hadoop repo and ran the > start-build-env.sh script. Once the docker build was completed and the > container running, I tried to sudo and it failed. Upon investigation, I > discovered that it was creating an entry in > /etc/sudoers.d/hadoop-build-${USER_ID} that contained the characters '\t' > rather than a tab. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org