[jira] [Commented] (HADOOP-16096) HADOOP-15281/distcp -Xdirect needs to use commons-logging on 3.1
[
https://issues.apache.org/jira/browse/HADOOP-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765116#comment-16765116
]
Steve Loughran commented on HADOOP-16096:
-
thx for committing this Eric. sorry I broke things. Moral: more due diligence
on distcp before committing
> HADOOP-15281/distcp -Xdirect needs to use commons-logging on 3.1
>
>
> Key: HADOOP-16096
> URL: https://issues.apache.org/jira/browse/HADOOP-16096
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 3.1.3
>Reporter: Eric Payne
>Assignee: Steve Loughran
>Priority: Critical
> Fix For: 3.1.3
>
> Attachments: HADOOP-15281-branch-3.1-001.patch
>
>
> HADOOP-15281 breaks the branch-3.1 build when building with java 1.8.
> {code:title="RetriableFileCopyCommand.java"}
> LOG.info("Copying {} to {}", source.getPath(), target);
> {code}
> Multiple lines have this error:
> {panel:title="Build Failure"}
> [ERROR]
> hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java:[121,8]
> no suitable method found for
> info(java.lang.String,org.apache.hadoop.fs.Path,org.apache.hadoop.fs.Path)
> [ERROR] method org.apache.commons.logging.Log.info(java.lang.Object) is
> not applicable
> [ERROR] (actual and formal argument lists differ in length)
> [ERROR] method
> org.apache.commons.logging.Log.info(java.lang.Object,java.lang.Throwable) is
> not applicable
> [ERROR] (actual and formal argument lists differ in length)
> {panel}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16096) HADOOP-15281/distcp -Xdirect needs to use commons-logging on 3.1
[
https://issues.apache.org/jira/browse/HADOOP-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763164#comment-16763164
]
Eric Payne commented on HADOOP-16096:
-
+1
Will commit shortly
> HADOOP-15281/distcp -Xdirect needs to use commons-logging on 3.1
>
>
> Key: HADOOP-16096
> URL: https://issues.apache.org/jira/browse/HADOOP-16096
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 3.1.3
>Reporter: Eric Payne
>Assignee: Steve Loughran
>Priority: Critical
> Attachments: HADOOP-15281-branch-3.1-001.patch
>
>
> HADOOP-15281 breaks the branch-3.1 build when building with java 1.8.
> {code:title="RetriableFileCopyCommand.java"}
> LOG.info("Copying {} to {}", source.getPath(), target);
> {code}
> Multiple lines have this error:
> {panel:title="Build Failure"}
> [ERROR]
> hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java:[121,8]
> no suitable method found for
> info(java.lang.String,org.apache.hadoop.fs.Path,org.apache.hadoop.fs.Path)
> [ERROR] method org.apache.commons.logging.Log.info(java.lang.Object) is
> not applicable
> [ERROR] (actual and formal argument lists differ in length)
> [ERROR] method
> org.apache.commons.logging.Log.info(java.lang.Object,java.lang.Throwable) is
> not applicable
> [ERROR] (actual and formal argument lists differ in length)
> {panel}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-16096) HADOOP-15281/distcp -Xdirect needs to use commons-logging on 3.1
[
https://issues.apache.org/jira/browse/HADOOP-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763162#comment-16763162
]
Hadoop QA commented on HADOOP-16096:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
26s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
|| || || || {color:brown} branch-3.1 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
10s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 24m
34s{color} | {color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
9s{color} | {color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
8s{color} | {color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
14m 4s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
19s{color} | {color:green} branch-3.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} branch-3.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
36s{color} | {color:green} hadoop-tools: The patch generated 0 new + 66
unchanged - 2 fixed = 66 total (was 68) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 1 line(s) that end in whitespace. Use git
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 8s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m
39s{color} | {color:green} hadoop-distcp in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 4m
29s{color} | {color:green} hadoop-aws in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
24s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 83m 48s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:080e9d0 |
| JIRA Issue | HADOOP-16096 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12957966/HADOOP-15281-branch-3.1-001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 2513e6c92d7d 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct
5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | branch-3.1 / 834a862 |
| maven | version: Apache Maven 3.
[jira] [Commented] (HADOOP-16096) HADOOP-15281/distcp -Xdirect needs to use commons-logging on 3.1
[
https://issues.apache.org/jira/browse/HADOOP-16096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763136#comment-16763136
]
Eric Payne commented on HADOOP-16096:
-
Thanks a lot [~ste...@apache.org] for the quick turn around on the updated
patch!
I will wait for the pre-commit build, but this patch builds on 3.1 and the
changes look good to me. Is there someone else you would like to look at if?
> HADOOP-15281/distcp -Xdirect needs to use commons-logging on 3.1
>
>
> Key: HADOOP-16096
> URL: https://issues.apache.org/jira/browse/HADOOP-16096
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 3.1.3
>Reporter: Eric Payne
>Assignee: Steve Loughran
>Priority: Critical
> Attachments: HADOOP-15281-branch-3.1-001.patch
>
>
> HADOOP-15281 breaks the branch-3.1 build when building with java 1.8.
> {code:title="RetriableFileCopyCommand.java"}
> LOG.info("Copying {} to {}", source.getPath(), target);
> {code}
> Multiple lines have this error:
> {panel:title="Build Failure"}
> [ERROR]
> hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/mapred/RetriableFileCopyCommand.java:[121,8]
> no suitable method found for
> info(java.lang.String,org.apache.hadoop.fs.Path,org.apache.hadoop.fs.Path)
> [ERROR] method org.apache.commons.logging.Log.info(java.lang.Object) is
> not applicable
> [ERROR] (actual and formal argument lists differ in length)
> [ERROR] method
> org.apache.commons.logging.Log.info(java.lang.Object,java.lang.Throwable) is
> not applicable
> [ERROR] (actual and formal argument lists differ in length)
> {panel}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
