[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902886#comment-14902886 ] Kengo Seki commented on HADOOP-4258: Sorry [~jagadesh.kiran], I'm on vacation until Sep. 27th. I'll review your patch next Monday. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, > HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch, > HADOOP-4258.HADOOP-12111.02.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903830#comment-14903830 ] Allen Wittenauer commented on HADOOP-4258: -- This doesn't work on OS X. uniq -d and uniq -c cannot be used simultaneously. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, > HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch, > HADOOP-4258.HADOOP-12111.02.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14790952#comment-14790952 ] Hadoop QA commented on HADOOP-4258: --- (!) A patch to the files used for the QA process has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/7670/console in case of problems. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, > HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch, > HADOOP-4258.HADOOP-12111.02.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746778#comment-14746778
]
Kengo Seki commented on HADOOP-4258:
Thanks [~jagadesh.kiran], some comments:
* Shortening only the filename is not sufficient. We must shorten
"duplicatednames" in the file, because the arguement of add_test is used as the
plugin name. See [Yetus precommit document about plugin
name|https://github.com/apache/hadoop/blob/HADOOP-12111/dev-support/docs/precommit-advanced.md#common-plug-in-functions].
* The following is probably different from what Allen originally meant. This
just sorts changed_files, while {{uniq -id}} outputs only duplicated lines
ignoring case.
{code}
IFS=$'\n' changed_files=($(sort --ignore-case <<<"${CHANGED_FILES[*]}"))
{code}
* The following line will fail because the closing brace is missing.
{code}
for ((j=i+1; j < ${#changed_files[@]; j++)) {
{code}
* Address shellcheck and whitespace warnings.
To make sure, the comments which are not addressed in this patch, except for
mentioned above:
bq. the problem that Owen O'Malley is actually talking about is a problem where
a new file was added because it conflicted with a pre-existing file in the
source tree. This patch would miss that situation.
bq. $a and $b should be changed, like "$first_lower", "$second_lower".
bq. if HADOOP-12257 gets committed, this should use _precheck instead of
_postcheckout.
> the test patch script should check for filenames that differ only in case
> -
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
>Reporter: Owen O'Malley
>Assignee: Jagadesh Kiran N
> Labels: test-patch
> Attachments: HADOOP-4258.001.patch,
> HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746812#comment-14746812
]
Jagadesh Kiran N commented on HADOOP-4258:
--
Thanks [~sekikn] for your review, i will update the same, require some
clarification on the approach for New File addition ,
My solution for this is to make duplicate as separate function like {code}
function checkifduplicate {} {code}, so that the function can be used when file
is added or modified. Please let me know if this approach is correct .
> the test patch script should check for filenames that differ only in case
> -
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
>Reporter: Owen O'Malley
>Assignee: Jagadesh Kiran N
> Labels: test-patch
> Attachments: HADOOP-4258.001.patch,
> HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745866#comment-14745866 ] Jagadesh Kiran N commented on HADOOP-4258: -- [~sekikn] ,[~aw] please review, > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, > HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746029#comment-14746029
]
Hadoop QA commented on HADOOP-4258:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:red}-1{color} | {color:red} shellcheck {color} | {color:red} 0m 7s
{color} | {color:red} The applied patch generated 3 new shellcheck issues
(total was 20, now 23). {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s
{color} | {color:red} The patch has 5 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
25s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 38s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12756048/HADOOP-4258.HADOOP-12111.01.patch
|
| JIRA Issue | HADOOP-4258 |
| git revision | HADOOP-12111 / 0a6e5d1 |
| Optional Tests | asflicense unit shellcheck |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/dev-support-test/personality/hadoop.sh
|
| Default Java | 1.7.0_55 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/home/jenkins/tools/java/jdk1.7.0_55:1.7.0_55 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider
upgrading.) |
| shellcheck |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7664/artifact/patchprocess/diff-patch-shellcheck.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7664/artifact/patchprocess/whitespace-tabs.txt
|
| JDK v1.7.0_55 Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7664/testReport/ |
| Max memory used | 48MB |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7664/console |
This message was automatically generated.
> the test patch script should check for filenames that differ only in case
> -
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
>Reporter: Owen O'Malley
>Assignee: Jagadesh Kiran N
> Labels: test-patch
> Attachments: HADOOP-4258.001.patch,
> HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746028#comment-14746028 ] Hadoop QA commented on HADOOP-4258: --- (!) A patch to the files used for the QA process has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/7664/console in case of problems. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, > HADOOP-4258.HADOOP-12111.00.patch, HADOOP-4258.HADOOP-12111.01.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735345#comment-14735345 ] Allen Wittenauer commented on HADOOP-4258: -- Just a heads up that if HADOOP-12257 gets committed, this should use _precheck instead of _postcheckout. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14732415#comment-14732415
]
Kengo Seki commented on HADOOP-4258:
Thanks [~jagadesh.kiran], some comments:
* K and L are not so readable too. How about "$first", "$second" or something?
Also, $a and $b should be changed, like "$first_lower", "$second_lower".
* Address other Allen's comments. About test-patch plugin hooks such as
postcheckout or preapply, see [yetus precommit
document|https://github.com/apache/hadoop/blob/HADOOP-12111/dev-support/docs/precommit-advanced.md#test-plug-ins].
* This code
{code}
34 declare -a changed_files
35 i=0
36 # shellcheck disable=SC2153
37 while read line; do
38 changed_files[${i}]="${line}"
39 ((i=i+1))
40 done < <(echo "${CHANGED_FILES}")
{code}
is intended to store newline-separated strings in an array, but very verbose
(sorry, my fault). Instead,
{code}
declare -a changed_files
changed_files=(${CHANGED_FILES})
{code}
should work.
* And, please don't forget to shorten the plugin name. ;)
> the test patch script should check for filenames that differ only in case
> -
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
>Reporter: Owen O'Malley
>Assignee: Jagadesh Kiran N
> Labels: test-patch
> Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731898#comment-14731898 ] Hadoop QA commented on HADOOP-4258: --- (!) A patch to the files used for the QA process has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/7608/console in case of problems. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731899#comment-14731899
]
Hadoop QA commented on HADOOP-4258:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
6s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 39s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12754322/HADOOP-4258.HADOOP-12111.00.patch
|
| JIRA Issue | HADOOP-4258 |
| git revision | HADOOP-12111 / 8bb8584 |
| Optional Tests | asflicense unit shellcheck |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/dev-support-test/personality/hadoop.sh
|
| Default Java | 1.7.0_55 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/home/jenkins/tools/java/jdk1.7.0_55:1.7.0_55 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider
upgrading.) |
| JDK v1.7.0_55 Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7608/testReport/ |
| Max memory used | 48MB |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7608/console |
This message was automatically generated.
> the test patch script should check for filenames that differ only in case
> -
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
>Reporter: Owen O'Malley
>Assignee: Jagadesh Kiran N
> Labels: test-patch
> Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731937#comment-14731937 ] Jagadesh Kiran N commented on HADOOP-4258: -- As the changes done on script ,no test cases included > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14732047#comment-14732047 ] Allen Wittenauer commented on HADOOP-4258: -- The latest patch doesn't appear to address any of the other feedback... > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: test-patch > Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14732068#comment-14732068
]
Jagadesh Kiran N commented on HADOOP-4258:
--
Thanks [~aw] , i will address these three issues ,further any changes please
suggest me
{code}
reapply is too late. This should be in postcheckout. Doing that also simplifies
the code since returning 1 for failure will trigger all the cleanup, etc., so
that wouldn't have to be done in the plugin.
I suspect the problem that Owen O'Malley is actually talking about is a problem
where a new file was added because it conflicted with a pre-existing file in
the source tree. This patch would miss that situation
This seems like it would be very expensive on large patches due to the number
of calls to tr. Off the top of my head, it looks like it could be optimized to
use uniq -id first to limit the set of files that need to looked be at for at
least one of the loops (outer would likely be better, given point 2 above
should be handled prior to even running the inner loop!) {code}
> the test patch script should check for filenames that differ only in case
> -
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
>Reporter: Owen O'Malley
>Assignee: Jagadesh Kiran N
> Labels: test-patch
> Attachments: HADOOP-4258.001.patch, HADOOP-4258.HADOOP-12111.00.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731124#comment-14731124 ] Kengo Seki commented on HADOOP-4258: Thanks [~jagadesh.kiran], that's very helpful! When you update the patch, could you change its plugin name to something like "dupname"? The current name "duplicatednames" is too long as a plugin name. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley > Labels: newbie, test-patch > Attachments: HADOOP-4258.001.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14731482#comment-14731482 ] Allen Wittenauer commented on HADOOP-4258: -- * This likely won't be getting committed to trunk given that all development on test-patch there has stopped. So please change this to use the HADOOP-12111 branch. * preapply is too late. This should be in postcheckout. Doing that also simplifies the code since returning 1 for failure will trigger all the cleanup, etc., so that wouldn't have to be done in the plugin. * I suspect the problem that [~owen.omalley] is actually talking about is a problem where a new file was added because it conflicted with a pre-existing file in the source tree. This patch would miss that situation. * This seems like it would be very expensive on large patches due to the number of calls to tr. Off the top of my head, it looks like it could be optimized to use uniq -id first to limit the set of files that need to looked be at for at least one of the loops (outer would likely be better, given point 2 above should be handled prior to even running the inner loop!) * Totally not a fan of having A and a and B and b as var names. I get the why's but it makes it really hard to read at a glance! :D Thanks! > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley >Assignee: Jagadesh Kiran N > Labels: newbie, test-patch > Attachments: HADOOP-4258.001.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729310#comment-14729310 ] Kengo Seki commented on HADOOP-4258: This feature is not yet incorporated in Yetus, so I'll make it a subtask of HADOOP-12111 for now. Thanks [~ozawa] for your reminder! > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Test > Components: build, test >Reporter: Owen O'Malley >Assignee: Kengo Seki > Labels: newbie, test-patch > Attachments: HADOOP-4258.001.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729317#comment-14729317 ] Kengo Seki commented on HADOOP-4258: Cancelled patch because the current one is not for the HADOOP-12111 branch. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley > Labels: newbie, test-patch > Attachments: HADOOP-4258.001.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729955#comment-14729955 ] Jagadesh Kiran N commented on HADOOP-4258: -- @kengo seki ,i am interested in changing the patch to current branch, if you dont have any issues i will assign and update new patch for the same in HADOOP-12111 branch. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Sub-task > Components: build, test >Reporter: Owen O'Malley > Labels: newbie, test-patch > Attachments: HADOOP-4258.001.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729006#comment-14729006 ] Tsuyoshi Ozawa commented on HADOOP-4258: [~sekikn] This jira looks to be deprecated since Yetus is coming. Can we close this issue as deprecated one? > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Test > Components: build, test >Reporter: Owen O'Malley >Assignee: Kengo Seki > Labels: newbie, test-patch > Attachments: HADOOP-4258.001.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729029#comment-14729029 ] Hadoop QA commented on HADOOP-4258: --- (!) A patch to the files used for the QA process has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/7588/console in case of problems. > the test patch script should check for filenames that differ only in case > - > > Key: HADOOP-4258 > URL: https://issues.apache.org/jira/browse/HADOOP-4258 > Project: Hadoop Common > Issue Type: Test > Components: build, test >Reporter: Owen O'Malley >Assignee: Kengo Seki > Labels: newbie, test-patch > Attachments: HADOOP-4258.001.patch > > > It would be nice if the test patch script warned about filenames that differ > only in case. We recently had a patch committed that had a pair of colliding > filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14729031#comment-14729031
]
Hadoop QA commented on HADOOP-4258:
---
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 0m 0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:blue}0{color} | @author | 0m 0s | Skipping @author checks as
test-patch has been patched. |
| {color:green}+1{color} | duplicated | 0m 0s | The patch has no duplicated
filenames that differ only in case. |
| {color:green}+1{color} | release audit | 0m 14s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 6s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| | | 0m 23s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12736085/HADOOP-4258.001.patch |
| Optional Tests | shellcheck |
| git revision | trunk / b469ac5 |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7588/console |
This message was automatically generated.
> the test patch script should check for filenames that differ only in case
> -
>
> Key: HADOOP-4258
> URL: https://issues.apache.org/jira/browse/HADOOP-4258
> Project: Hadoop Common
> Issue Type: Test
> Components: build, test
>Reporter: Owen O'Malley
>Assignee: Kengo Seki
> Labels: newbie, test-patch
> Attachments: HADOOP-4258.001.patch
>
>
> It would be nice if the test patch script warned about filenames that differ
> only in case. We recently had a patch committed that had a pair of colliding
> filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[
https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564424#comment-14564424
]
Hadoop QA commented on HADOOP-4258:
---
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | reexec | 0m 0s | dev-support patch detected. |
| {color:blue}0{color} | pre-patch | 0m 0s | Pre-patch trunk compilation is
healthy. |
| {color:blue}0{color} | @author | 0m 0s | Skipping @author checks as
test-patch has been patched. |
| {color:green}+1{color} | duplicated | 0m 0s | The patch has no duplicated
filenames that differ only in case. |
| {color:green}+1{color} | release audit | 0m 18s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | shellcheck | 0m 5s | There were no new shellcheck
(v0.3.3) issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| | | 0m 26s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12736085/HADOOP-4258.001.patch |
| Optional Tests | shellcheck |
| git revision | trunk / d725dd8 |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6868/console |
This message was automatically generated.
the test patch script should check for filenames that differ only in case
-
Key: HADOOP-4258
URL: https://issues.apache.org/jira/browse/HADOOP-4258
Project: Hadoop Common
Issue Type: Test
Components: build, test
Reporter: Owen O'Malley
Assignee: Kengo Seki
Labels: newbie, test-patch
Attachments: HADOOP-4258.001.patch
It would be nice if the test patch script warned about filenames that differ
only in case. We recently had a patch committed that had a pair of colliding
filenames and subversion broke badly on my Mac.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-4258) the test patch script should check for filenames that differ only in case
[ https://issues.apache.org/jira/browse/HADOOP-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564423#comment-14564423 ] Hadoop QA commented on HADOOP-4258: --- (!) A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6868/console in case of problems. the test patch script should check for filenames that differ only in case - Key: HADOOP-4258 URL: https://issues.apache.org/jira/browse/HADOOP-4258 Project: Hadoop Common Issue Type: Test Components: build, test Reporter: Owen O'Malley Assignee: Kengo Seki Labels: newbie, test-patch Attachments: HADOOP-4258.001.patch It would be nice if the test patch script warned about filenames that differ only in case. We recently had a patch committed that had a pair of colliding filenames and subversion broke badly on my Mac. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
