[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498808#comment-13498808
]
Hudson commented on HADOOP-6607:
Integrated in Hadoop-Mapreduce-trunk #1259 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1259/])
HADOOP-6607. Add different variants of non caching HTTP headers. (tucu)
(Revision 1409921)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409921
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/NoCacheFilter.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, HADOOP-6607.patch,
> NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498792#comment-13498792
]
Hudson commented on HADOOP-6607:
Integrated in Hadoop-Hdfs-trunk #1228 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1228/])
HADOOP-6607. Add different variants of non caching HTTP headers. (tucu)
(Revision 1409921)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409921
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/NoCacheFilter.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, HADOOP-6607.patch,
> NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498719#comment-13498719
]
Hudson commented on HADOOP-6607:
Integrated in Hadoop-Yarn-trunk #38 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/38/])
HADOOP-6607. Add different variants of non caching HTTP headers. (tucu)
(Revision 1409921)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409921
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/NoCacheFilter.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, HADOOP-6607.patch,
> NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498243#comment-13498243
]
Hudson commented on HADOOP-6607:
Integrated in Hadoop-trunk-Commit #3027 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/3027/])
HADOOP-6607. Add different variants of non caching HTTP headers. (tucu)
(Revision 1409921)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1409921
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/NoCacheFilter.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, HADOOP-6607.patch,
> NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13498193#comment-13498193
]
Eli Collins commented on HADOOP-6607:
-
+1 lgtm as well
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, HADOOP-6607.patch,
> NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497929#comment-13497929
]
Steve Loughran commented on HADOOP-6607:
+1, looks good. It'll probably still break against some random Netscape 3.x
proxy or MS Windows Proxy somewhere in the field, but that's why nobody should
be using them.
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, HADOOP-6607.patch,
> NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497531#comment-13497531
]
Hadoop QA commented on HADOOP-6607:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553567/HADOOP-6607.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1747//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1747//console
This message is automatically generated.
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, HADOOP-6607.patch,
> NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497304#comment-13497304
]
Eli Collins commented on HADOOP-6607:
-
Per the RFC (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html) shouldn't
we use the date header rather than System#currentTimeMillis?
{quote}
To mark a response as "already expired," an origin server sends an Expires date
that is equal to the Date header value.
{quote}
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-6607) Add different variants of non caching HTTP headers
[
https://issues.apache.org/jira/browse/HADOOP-6607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497231#comment-13497231
]
Hadoop QA commented on HADOOP-6607:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12553507/HADOOP-6607.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1743//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1743//console
This message is automatically generated.
> Add different variants of non caching HTTP headers
> --
>
> Key: HADOOP-6607
> URL: https://issues.apache.org/jira/browse/HADOOP-6607
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
>Affects Versions: 0.22.0
>Reporter: Steve Loughran
>Assignee: Alejandro Abdelnur
>Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: HADOOP-6607.patch, NoCachingFilter.java
>
>
> I'm suffering from proxy servers that are caching some of the HttpResponses
> that Hadoop generates in servlets/JSP pages. While the web ui is up to date,
> some of my build files are failing to pull stuff down because that is going
> via proxy -it sees an error page rather than the data
> # Every servlet should set a short expires header and disable caching,
> especially in proxies.
> # JSP pages should do it to
> # It's essential that error responses do it.
> Maybe this could be done in a filter. Otherwise something like
> {code}
> /**
> * Turn off caching and say that the response expires now
> * @param response the response
> */
> protected void disableCaching(HttpServletResponse response) {
> response.addDateHeader("Expires", System.currentTimeMillis());
> response.addHeader("Cache-Control", "no-cache");
> response.addHeader("Pragma", "no-cache");
> }
> {code}
> Before anyone rushes to do this, we should consult some HTTP experts in
> Yahoo! or Facebook to get the options right. It may be best to have, say, a
> 1s lifespan on everything.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
