[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225831#comment-13225831
]
Eli Collins commented on HADOOP-7806:
-
Test failure is unrelated, filed HADOOP-8157 for it.
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
> Fix For: 0.24.0
>
> Attachments: HADOOP-7806.patch, HADOOP-7806.patch, hadoop-7806.txt
>
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225828#comment-13225828
]
Hadoop QA commented on HADOOP-7806:
---
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12517601/hadoop-7806.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.ipc.TestRPCCallBenchmark
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/693//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/693//console
This message is automatically generated.
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
> Fix For: 0.24.0
>
> Attachments: HADOOP-7806.patch, HADOOP-7806.patch, hadoop-7806.txt
>
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225768#comment-13225768
]
Todd Lipcon commented on HADOOP-7806:
-
+1 pending results on new patch
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
> Fix For: 0.24.0
>
> Attachments: HADOOP-7806.patch, HADOOP-7806.patch, hadoop-7806.txt
>
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156560#comment-13156560
]
Harsh J commented on HADOOP-7806:
-
Findbugs warnings are unrelated to this patch. Similar for javadocs, which this
does not touch at all.
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
> Fix For: 0.24.0
>
> Attachments: HADOOP-7806.patch, HADOOP-7806.patch
>
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152764#comment-13152764
]
Hadoop QA commented on HADOOP-7806:
---
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504186/HADOOP-7806.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/384//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/384//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/384//console
This message is automatically generated.
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
> Fix For: 0.24.0
>
> Attachments: HADOOP-7806.patch, HADOOP-7806.patch
>
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152722#comment-13152722
]
Sho Shimauchi commented on HADOOP-7806:
---
nested ifs would be better, remove else clause.
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
> Fix For: 0.24.0
>
> Attachments: HADOOP-7806.patch
>
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152704#comment-13152704
]
Harsh J commented on HADOOP-7806:
-
There were no existing tests for this. Unsure how I can add some tests for
subinterfaces, even with mockito. Any ideas?
But I've tested the patch manually on a machine where I had "eth0:1" available,
and the specific IP got returned for binding.
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
> Fix For: 0.24.0
>
> Attachments: HADOOP-7806.patch
>
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152678#comment-13152678
]
Hadoop QA commented on HADOOP-7806:
---
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504175/HADOOP-7806.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/383//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/383//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/383//console
This message is automatically generated.
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
> Fix For: 0.24.0
>
> Attachments: HADOOP-7806.patch
>
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7806) [DNS] Support binding to sub-interfaces
[
https://issues.apache.org/jira/browse/HADOOP-7806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152169#comment-13152169
]
Harsh J commented on HADOOP-7806:
-
I do wish that there were a naming standard for these NIF names. Impl. could be
as easy as a string split and search :)
> [DNS] Support binding to sub-interfaces
> ---
>
> Key: HADOOP-7806
> URL: https://issues.apache.org/jira/browse/HADOOP-7806
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
>Affects Versions: 0.24.0
>Reporter: Harsh J
>Assignee: Harsh J
>
> Right now, with the {{DNS}} class, we can look up IPs of provided interface
> names ({{eth0}}, {{vm1}}, etc.). However, it would be useful if the I/F -> IP
> lookup also took a look at subinterfaces ({{eth0:1}}, etc.) and allowed
> binding to only a specified subinterface / virtual interface.
> This should be fairly easy to add, by matching against all available
> interfaces' subinterfaces via Java.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
