[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955055#comment-16955055 ] Lisheng Sun commented on HADOOP-8159: - I open Jira HADOOP-16662 to tackle this. Thank you. [~elgoiri] > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin McCabe >Assignee: Colin McCabe >Priority: Major > Fix For: 1.1.0, 2.0.0-alpha > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954810#comment-16954810 ] Íñigo Goiri commented on HADOOP-8159: - [~leosun08], that makes sense, it looks redundant. Please open a separate JIRA to tackle this. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin McCabe >Assignee: Colin McCabe >Priority: Major > Fix For: 1.1.0, 2.0.0-alpha > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[
https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16954214#comment-16954214
]
Lisheng Sun commented on HADOOP-8159:
-
hi [~cmccabe] [~weichiu] [~elgoiri] [~ayushtkn]
the method of NetworkTopology#add
{code:java}
/** Add a leaf node
* Update node counter & rack counter if necessary
* @param node node to be added; can be null
* @exception IllegalArgumentException if add a node to a leave
or node to be added is not a leaf
*/
public void add(Node node) {
if (node==null) return;
int newDepth = NodeBase.locationToDepth(node.getNetworkLocation()) + 1;
netlock.writeLock().lock();
try {
if( node instanceof InnerNode ) {
throw new IllegalArgumentException(
"Not allow to add an inner node: "+NodeBase.getPath(node));
}
if (clusterMap.add(node)) {
LOG.info("Adding a new node: "+NodeBase.getPath(node));
if (rack == null) {
incrementRacks();
}
if (!(node instanceof InnerNode)) {
if (depthOfAllLeaves == -1) {
depthOfAllLeaves = node.getLevel();
}
}
}
LOG.debug("NetworkTopology became:\n{}", this);
} finally {
netlock.writeLock().unlock();
}
}
if (!(node instanceof InnerNode)) {
if (depthOfAllLeaves == -1) {
depthOfAllLeaves = node.getLevel();
}
}
if (!(node instanceof InnerNode)) is invalid，since there is already a judgement
before as follow:
if( node instanceof InnerNode ) {
throw new IllegalArgumentException(
"Not allow to add an inner node: "+NodeBase.getPath(node));
}
{code}
so i think if (!(node instanceof InnerNode)) should be removed. Please correct
me if i was wrong. Thank you.
> NetworkTopology: getLeaf should check for invalid topologies
>
>
> Key: HADOOP-8159
> URL: https://issues.apache.org/jira/browse/HADOOP-8159
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Colin McCabe
>Assignee: Colin McCabe
>Priority: Major
> Fix For: 1.1.0, 2.0.0-alpha
>
> Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch,
> HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch,
> HADOOP-8159.008.patch, HADOOP-8159.009.patch
>
>
> Currently, in NetworkTopology, getLeaf doesn't do too much validation on the
> InnerNode object itself. This results in us getting ClassCastException
> sometimes when the network topology is invalid. We should have a less
> confusing exception message for this case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236603#comment-13236603 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Mapreduce-trunk #1028 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1028/]) HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236575#comment-13236575 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Mapreduce-0.23-Build #234 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/234/]) HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : * /hadoop/common/branches/branch-0.23 * /hadoop/common/branches/branch-0.23/hadoop-common-project * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job * /hadoop/common/branches/branch-0.23/hadoop-project * /hadoop/common/branches/branch-0.23/hadoop-project/src/site > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236568#comment-13236568 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Hdfs-0.23-Build #206 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/206/]) HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : * /hadoop/common/branches/branch-0.23 * /hadoop/common/branches/branch-0.23/hadoop-common-project * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job * /hadoop/common/branches/branch-0.23/hadoop-project * /hadoop/common/branches/branch-0.23/hadoop-project/src/site > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This mes
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236561#comment-13236561 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Hdfs-trunk #993 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/993/]) HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = FAILURE eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236193#comment-13236193 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Mapreduce-trunk-Commit #1927 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1927/]) HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236196#comment-13236196 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Mapreduce-0.23-Commit #725 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/725/]) HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119) Result = ABORTED eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : * /hadoop/common/branches/branch-0.23 * /hadoop/common/branches/branch-0.23/hadoop-common-project * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job * /hadoop/common/branches/branch-0.23/hadoop-project * /hadoop/common/branches/branch-0.23/hadoop-project/src/site > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case.
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236169#comment-13236169 ] Hadoop QA commented on HADOOP-8159: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519537/HADOOP-8159-b1.007.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/752//console This message is automatically generated. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236157#comment-13236157 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Common-0.23-Commit #717 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/717/]) HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : * /hadoop/common/branches/branch-0.23 * /hadoop/common/branches/branch-0.23/hadoop-common-project * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job * /hadoop/common/branches/branch-0.23/hadoop-project * /hadoop/common/branches/branch-0.23/hadoop-project/src/site > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- Th
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236154#comment-13236154 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Common-trunk-Commit #1918 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1918/]) HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159-b1.007.patch, > HADOOP-8159.005.patch, HADOOP-8159.006.patch, HADOOP-8159.007.patch, > HADOOP-8159.008.patch, HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236145#comment-13236145 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Hdfs-0.23-Commit #708 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/708/]) HADOOP-8159. svn merge -c 1304118 from trunk (Revision 1304119) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304119 Files : * /hadoop/common/branches/branch-0.23 * /hadoop/common/branches/branch-0.23/hadoop-common-project * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-auth * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/docs * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java * /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/core * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/native * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/datanode * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/secondary * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/bin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/conf * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/c++ * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/block_forensics * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build-contrib.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/build.xml * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/data_join * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/index * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/vaidya * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/examples * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/java * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/fs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/hdfs * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/test/mapred/org/apache/hadoop/ipc * /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/webapps/job * /hadoop/common/branches/branch-0.23/hadoop-project * /hadoop/common/branches/branch-0.23/hadoop-project/src/site > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch, HADOOP-8159.008.patch, > HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically ge
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236141#comment-13236141 ] Hudson commented on HADOOP-8159: Integrated in Hadoop-Hdfs-trunk-Commit #1992 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1992/]) HADOOP-8159. NetworkTopology: getLeaf should check for invalid topologies. Contributed by Colin Patrick McCabe (Revision 1304118) Result = SUCCESS eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1304118 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/net/NetworkTopology.java > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 0.23.3 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch, HADOOP-8159.008.patch, > HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236090#comment-13236090 ] Hadoop QA commented on HADOOP-8159: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519513/HADOOP-8159.009.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.fs.viewfs.TestViewFsTrash +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/749//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/749//console This message is automatically generated. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch, HADOOP-8159.008.patch, > HADOOP-8159.009.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236064#comment-13236064 ] Colin Patrick McCabe commented on HADOOP-8159: -- Filed HDFS-3129 for the test-- will split that out of this patch. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch, HADOOP-8159.008.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236030#comment-13236030 ] Eli Collins commented on HADOOP-8159: - Ah, I missed that the test was in HDFS, Colin, mind filing an HDFS jira for the test and we'll check this one it w/o the test and then do the HDFS jira with test? > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch, HADOOP-8159.008.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236008#comment-13236008 ] Hadoop QA commented on HADOOP-8159: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519495/HADOOP-8159.008.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/748//console This message is automatically generated. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch, HADOOP-8159.008.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235993#comment-13235993 ] Aaron T. Myers commented on HADOOP-8159: bq. Not sure what's up with Jenkins. It claims "The patch does not appear to apply with p0 to p2" but the patch applies cleanly for me on trunk on the latest rev. The patch is cross-project, which test-patch can't handle. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch, HADOOP-8159.008.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235945#comment-13235945 ] Hadoop QA commented on HADOOP-8159: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519127/HADOOP-8159.007.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/747//console This message is automatically generated. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235900#comment-13235900 ] Eli Collins commented on HADOOP-8159: - Not sure what's up with Jenkins. It claims "The patch does not appear to apply with p0 to p2" but the patch applies cleanly for me on trunk on the latest rev. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235872#comment-13235872 ] Hadoop QA commented on HADOOP-8159: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519127/HADOOP-8159.007.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/746//console This message is automatically generated. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch, HADOOP-8159.007.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233620#comment-13233620 ] Eli Collins commented on HADOOP-8159: - The 1st, 3rd, and 4th bullets still need addressing, otherwise looks great. > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 1.0.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 1.0.0 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch, > HADOOP-8159.006.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229662#comment-13229662 ] Eli Collins commented on HADOOP-8159: - - Why report the entire topology as json in the message? This string is likely to be very big on a real cluster right? Probably better to make that accessible via the NN web UI (can punt to a separate change) - An error message like "Invalid network location for Datanode: Datanode given rack-level network location can not be at rack-level" is probably more clear than referencing class names not visible to the user - In testCreateInvalidTopology in the catch clause let's assert the contents of e.getMessage, ie that it indicates that h3 is the bad node - How about adding test cases for other invalid toplogies (eg 3 or 4 level deep topology, null, empty string) - Nit: bracket for catch InvalidTopologyException goes on the same line > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 1.0.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 1.0.0 > > Attachments: HADOOP-8159-b1.005.patch, HADOOP-8159.005.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8159) NetworkTopology: getLeaf should check for invalid topologies
[ https://issues.apache.org/jira/browse/HADOOP-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226696#comment-13226696 ] Eli Collins commented on HADOOP-8159: - Patch for trunk and test case in TestNetworkTopology? > NetworkTopology: getLeaf should check for invalid topologies > > > Key: HADOOP-8159 > URL: https://issues.apache.org/jira/browse/HADOOP-8159 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 1.0.0 >Reporter: Colin Patrick McCabe >Assignee: Colin Patrick McCabe > Fix For: 1.0.0 > > Attachments: HADOOP-8159.002.patch > > > Currently, in NetworkTopology, getLeaf doesn't do too much validation on the > InnerNode object itself. This results in us getting ClassCastException > sometimes when the network topology is invalid. We should have a less > confusing exception message for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
