[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558770#comment-14558770 ] Akira AJISAKA commented on HADOOP-8751: --- +1, committing this. NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Reporter: Vlad Rozov Assignee: kanaka kumar avvaru Priority: Minor Labels: BB2015-05-TBR Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch, HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558778#comment-14558778 ] Hudson commented on HADOOP-8751: FAILURE: Integrated in Hadoop-trunk-Commit #7900 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7900/]) HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Reporter: Vlad Rozov Assignee: kanaka kumar avvaru Priority: Minor Fix For: 2.8.0 Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch, HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559004#comment-14559004 ] Hudson commented on HADOOP-8751: FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #208 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/208/]) HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java * hadoop-common-project/hadoop-common/CHANGES.txt NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Reporter: Vlad Rozov Assignee: kanaka kumar avvaru Priority: Minor Fix For: 2.8.0 Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch, HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559018#comment-14559018 ] Hudson commented on HADOOP-8751: SUCCESS: Integrated in Hadoop-Yarn-trunk #939 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/939/]) HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java * hadoop-common-project/hadoop-common/CHANGES.txt NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Reporter: Vlad Rozov Assignee: kanaka kumar avvaru Priority: Minor Fix For: 2.8.0 Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch, HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559261#comment-14559261 ] Hudson commented on HADOOP-8751: SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2155 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2155/]) HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java * hadoop-common-project/hadoop-common/CHANGES.txt NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Reporter: Vlad Rozov Assignee: kanaka kumar avvaru Priority: Minor Fix For: 2.8.0 Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch, HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559226#comment-14559226 ] Hudson commented on HADOOP-8751: SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #207 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/207/]) HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java * hadoop-common-project/hadoop-common/CHANGES.txt NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Reporter: Vlad Rozov Assignee: kanaka kumar avvaru Priority: Minor Fix For: 2.8.0 Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch, HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559151#comment-14559151 ] Hudson commented on HADOOP-8751: FAILURE: Integrated in Hadoop-Hdfs-trunk #2137 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2137/]) HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Reporter: Vlad Rozov Assignee: kanaka kumar avvaru Priority: Minor Fix For: 2.8.0 Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch, HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14559170#comment-14559170 ] Hudson commented on HADOOP-8751: FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #197 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/197/]) HADOOP-8751. NPE in Token.toString() when Token is constructed using null identifier. Contributed by kanaka kumar avvaru. (aajisaka: rev 56996a685e6201cb186cea866d22418289174574) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/Token.java NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Reporter: Vlad Rozov Assignee: kanaka kumar avvaru Priority: Minor Fix For: 2.8.0 Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch, HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[
https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558237#comment-14558237
]
Hadoop QA commented on HADOOP-8751:
---
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 40s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 34s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 7s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 37s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 40s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 22m 20s | Tests passed in
hadoop-common. |
| | | 59m 25s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12735153/HADOOP-8751-03.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ada233b |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6819/console |
This message was automatically generated.
NPE in Token.toString() when Token is constructed using null identifier
---
Key: HADOOP-8751
URL: https://issues.apache.org/jira/browse/HADOOP-8751
Project: Hadoop Common
Issue Type: Bug
Components: security
Reporter: Vlad Rozov
Assignee: kanaka kumar avvaru
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch,
HADOOP-8751-02.patch, HADOOP-8751-03.patch, HADOOP-8751.patch
Token constructor allows null to be passed leading to NPE in
Token.toString(). Simple fix is to check for null in constructor and use
empty byte arrays.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[
https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553806#comment-14553806
]
Akira AJISAKA commented on HADOOP-8751:
---
Thanks [~kanaka] for taking this issue. Mostly looks good to me. Two comments:
1. For Token.addBinaryBuffer, we can drop null check for {{bytes}} since the
variable is guaranteed to be non null.
{code}
+assertEquals(token1, token2);
+assertEquals(token1.toString(), token2.toString());
+assertEquals(token1.encodeToUrlString(), token2.encodeToUrlString());
{code}
2. I'm thinking comparing {{Token.toString()}} is redundant and can be removed.
NPE in Token.toString() when Token is constructed using null identifier
---
Key: HADOOP-8751
URL: https://issues.apache.org/jira/browse/HADOOP-8751
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.0.0-alpha
Reporter: Vlad Rozov
Assignee: kanaka kumar avvaru
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch,
HADOOP-8751-02.patch, HADOOP-8751.patch
Token constructor allows null to be passed leading to NPE in
Token.toString(). Simple fix is to check for null in constructor and use
empty byte arrays.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[
https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539498#comment-14539498
]
Hadoop QA commented on HADOOP-8751:
---
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 15m 6s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 38s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 49s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 6s | The applied patch generated 1
new checkstyle issues (total was 10, now 11). |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 2 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 40s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 57s | Tests passed in
hadoop-common. |
| | | 60m 48s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12732172/HADOOP-8751-01.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 987abc9 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6647/console |
This message was automatically generated.
NPE in Token.toString() when Token is constructed using null identifier
---
Key: HADOOP-8751
URL: https://issues.apache.org/jira/browse/HADOOP-8751
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.0.0-alpha
Reporter: Vlad Rozov
Assignee: kanaka kumar avvaru
Priority: Minor
Labels: BB2015-05-RFC
Fix For: 2.0.0-alpha
Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch,
HADOOP-8751.patch
Token constructor allows null to be passed leading to NPE in
Token.toString(). Simple fix is to check for null in constructor and use
empty byte arrays.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[
https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539647#comment-14539647
]
Hadoop QA commented on HADOOP-8751:
---
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 38s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 30s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 5s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 39s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 26s | Tests passed in
hadoop-common. |
| | | 59m 25s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12732202/HADOOP-8751-02.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 360dff5 |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6651/console |
This message was automatically generated.
NPE in Token.toString() when Token is constructed using null identifier
---
Key: HADOOP-8751
URL: https://issues.apache.org/jira/browse/HADOOP-8751
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.0.0-alpha
Reporter: Vlad Rozov
Assignee: kanaka kumar avvaru
Priority: Minor
Labels: BB2015-05-RFC
Fix For: 2.0.0-alpha
Attachments: HADOOP-8751-01.patch, HADOOP-8751-01.patch,
HADOOP-8751-02.patch, HADOOP-8751.patch
Token constructor allows null to be passed leading to NPE in
Token.toString(). Simple fix is to check for null in constructor and use
empty byte arrays.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[
https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525080#comment-14525080
]
Hadoop QA commented on HADOOP-8751:
---
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 35s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 30s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 39s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 4s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 39s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 38s | Tests passed in
hadoop-common. |
| | | 59m 35s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6379/console |
This message was automatically generated.
NPE in Token.toString() when Token is constructed using null identifier
---
Key: HADOOP-8751
URL: https://issues.apache.org/jira/browse/HADOOP-8751
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.0.0-alpha
Reporter: Vlad Rozov
Assignee: Vlad Rozov
Priority: Minor
Fix For: 2.0.0-alpha
Attachments: HADOOP-8751.patch
Token constructor allows null to be passed leading to NPE in
Token.toString(). Simple fix is to check for null in constructor and use
empty byte arrays.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[
https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525149#comment-14525149
]
Hadoop QA commented on HADOOP-8751:
---
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 35s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 29s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 5s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 40s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 15s | Tests passed in
hadoop-common. |
| | | 59m 11s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6385/console |
This message was automatically generated.
NPE in Token.toString() when Token is constructed using null identifier
---
Key: HADOOP-8751
URL: https://issues.apache.org/jira/browse/HADOOP-8751
Project: Hadoop Common
Issue Type: Bug
Components: security
Affects Versions: 2.0.0-alpha
Reporter: Vlad Rozov
Assignee: Vlad Rozov
Priority: Minor
Fix For: 2.0.0-alpha
Attachments: HADOOP-8751.patch
Token constructor allows null to be passed leading to NPE in
Token.toString(). Simple fix is to check for null in constructor and use
empty byte arrays.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13446349#comment-13446349 ] Daryn Sharp commented on HADOOP-8751: - I'm not sure that we should prevent nulls for the various fields. Although I'm fine with handling a null identifier even though that's really an invalid use case. NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Vlad Rozov Assignee: Vlad Rozov Priority: Minor Fix For: 2.0.0-alpha Attachments: HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13446420#comment-13446420 ] Vlad Rozov commented on HADOOP-8751: I don't think it is important to distinguish between null and empty fields in the Token class. Default constructor initializes to empty fields. For consistency and to avoid checks for nullness, IMHO it is easier to prevent fields to be null altogether. In the TestHftpDelegationToken test case both null and empty byte arrays are used to initialize identifier and password. NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Vlad Rozov Assignee: Vlad Rozov Priority: Minor Fix For: 2.0.0-alpha Attachments: HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445691#comment-13445691 ] Hadoop QA commented on HADOOP-8751: --- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12543226/HADOOP-8751.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverController +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1391//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1391//console This message is automatically generated. NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Vlad Rozov Assignee: Vlad Rozov Priority: Minor Fix For: 2.0.0-alpha Attachments: HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8751) NPE in Token.toString() when Token is constructed using null identifier
[ https://issues.apache.org/jira/browse/HADOOP-8751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13445696#comment-13445696 ] Vlad Rozov commented on HADOOP-8751: Failure in TestZKFailoverController is caused HADOOP-8591. NPE in Token.toString() when Token is constructed using null identifier --- Key: HADOOP-8751 URL: https://issues.apache.org/jira/browse/HADOOP-8751 Project: Hadoop Common Issue Type: Bug Components: security Affects Versions: 2.0.0-alpha Reporter: Vlad Rozov Assignee: Vlad Rozov Priority: Minor Fix For: 2.0.0-alpha Attachments: HADOOP-8751.patch Token constructor allows null to be passed leading to NPE in Token.toString(). Simple fix is to check for null in constructor and use empty byte arrays. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
