[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604261#comment-13604261
]
Hudson commented on HADOOP-9318:
Integrated in Hadoop-Mapreduce-trunk #1374 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1374/])
HADOOP-9318. When exiting on a signal, print the signal name first.
Contributed by Colin Patrick McCabe. (Revision 1457122)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457122
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SignalLogger.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestSignalLogger.java
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.5-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.5-beta
>
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604239#comment-13604239
]
Hudson commented on HADOOP-9318:
Integrated in Hadoop-Hdfs-trunk #1346 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1346/])
HADOOP-9318. When exiting on a signal, print the signal name first.
Contributed by Colin Patrick McCabe. (Revision 1457122)
Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457122
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SignalLogger.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestSignalLogger.java
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.5-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.5-beta
>
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604201#comment-13604201
]
Hudson commented on HADOOP-9318:
Integrated in Hadoop-Yarn-trunk #157 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/157/])
HADOOP-9318. When exiting on a signal, print the signal name first.
Contributed by Colin Patrick McCabe. (Revision 1457122)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457122
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SignalLogger.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestSignalLogger.java
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.5-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.5-beta
>
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603871#comment-13603871
]
Hudson commented on HADOOP-9318:
Integrated in Hadoop-trunk-Commit #3483 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/3483/])
HADOOP-9318. When exiting on a signal, print the signal name first.
Contributed by Colin Patrick McCabe. (Revision 1457122)
Result = SUCCESS
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1457122
Files :
* /hadoop/common/trunk/dev-support/test-patch.sh
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/SignalLogger.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/StringUtils.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/util/TestSignalLogger.java
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.5-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Fix For: 2.0.5-beta
>
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13603858#comment-13603858
]
Aaron T. Myers commented on HADOOP-9318:
Thanks for commenting, Suresh. Colin's explanation makes sense to me.
+1, the latest patch looks good to me. I'm going to commit this momentarily.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.5-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601384#comment-13601384
]
Colin Patrick McCabe commented on HADOOP-9318:
--
bq. unless different actions need to be taken for each signal
at the end of our signal handler, we have to call the previous signal handler
for that signal. This will be different for each signal.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.5-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600796#comment-13600796
]
Suresh Srinivas commented on HADOOP-9318:
-
Aaron, thanks for checking.
bq. Each instance of Handler handles a different signal. Keep in mind that
prevHandler will be different for each signal, so if we combined them all into
one, we'd have to have some kind of Map or something to be able to call the
correct prevHandler. So I think it's easier to leave them separate.
Perhaps I do not understand the code correctly. Given that all a handler is
doing is just printing a log, using a single instance of handler should be
sufficient and need for separate instance does not seem necessary, unless
different actions need to be taken for each signal. Again, this is not a big
deal.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.5-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600759#comment-13600759
]
Aaron T. Myers commented on HADOOP-9318:
Suresh, does the latest patch look OK to you? It seems fine to me, but want to
check with you first.
I think the javac/javadoc warnings are unavoidable.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.5-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584920#comment-13584920
]
Hadoop QA commented on HADOOP-9318:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570575/HADOOP-9318.003.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 tests included appear to have a timeout.{color}
{color:red}-1 javac{color}. The applied patch generated 1363 javac
compiler warnings (more than the trunk's current 1356 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 5
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2221//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2221//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2221//console
This message is automatically generated.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.4-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch,
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584823#comment-13584823
]
Hadoop QA commented on HADOOP-9318:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570552/HADOOP-9318.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 tests included appear to have a timeout.{color}
{color:red}-1 javac{color}. The applied patch generated 1363 javac
compiler warnings (more than the trunk's current 1356 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 5
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2220//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2220//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2220//console
This message is automatically generated.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.4-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584790#comment-13584790
]
Colin Patrick McCabe commented on HADOOP-9318:
--
I added a bunch of javadoc.
bq. Minor nits - in register() method, create StringBuilder after the first
check that throws exception. Optionally, is it better to throw
IllegalStateException instead RTE?
Yeah.
bq. Given the way Handler code is, you just need only a single instance of
Handler. It can be registered in the register method itself using
signal.handle() call right?
Each instance of Handler handles a different signal. Keep in mind that
prevHandler will be different for each signal, so if we combined them all into
one, we'd have to have some kind of Map or something to be able to call the
correct prevHandler. So I think it's easier to leave them separate.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.4-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583563#comment-13583563
]
Suresh Srinivas commented on HADOOP-9318:
-
Also it may be a good idea to write a simple unit test to see if multiple
register calls indeed results in exception.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.4-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583562#comment-13583562
]
Suresh Srinivas commented on HADOOP-9318:
-
This is a useful functionality.
Comments:
# Please add javadoc to the methods
# Minor nits - in register() method, create StringBuilder after the first check
that throws exception. Optionally, is it better to throw IllegalStateException
instead RTE?
# Given the way Handler code is, you just need only a single instance of
Handler. It can be registered in the register method itself using
{{signal.handle()}} call right?
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.4-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581663#comment-13581663
]
Chris Nauroth commented on HADOOP-9318:
---
+1 for the patch.
Thanks for providing the additional diagnostics. I applied the patch to trunk,
built a distro, and tried various ways of stopping namenode. I did this on
Mac, Ubuntu with OpenJDK, and Windows. Everything worked fine.
I was hoping to test on a JVM that didn't have those sun.misc classes, but the
classes are present on all of my environments. I fully expect the catch clause
would handle it fine though by catching {{ExceptionInInitializerError}}.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.4-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9318) when exiting on a signal, print the signal name first
[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13581610#comment-13581610
]
Hadoop QA commented on HADOOP-9318:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12569984/HADOOP-9318.001.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color}. The applied patch generated 1363 javac
compiler warnings (more than the trunk's current 1356 warnings).
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 5
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2205//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2205//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2205//console
This message is automatically generated.
> when exiting on a signal, print the signal name first
> -
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 2.0.4-beta
>Reporter: Colin Patrick McCabe
>Assignee: Colin Patrick McCabe
>Priority: Minor
> Attachments: HADOOP-9318.001.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
