[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[ https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13664301#comment-13664301 ] Suresh Srinivas commented on HADOOP-9425: - Sanjay, after merging a change to branch-2, please update the trunk CHANGES.txt and move the jira description to appropriate 2.x section. I have made these changes for your recent changes. Add error codes to rpc-response --- Key: HADOOP-9425 URL: https://issues.apache.org/jira/browse/HADOOP-9425 Project: Hadoop Common Issue Type: Sub-task Components: ipc Reporter: Sanjay Radia Assignee: Sanjay Radia Fix For: 2.0.5-beta Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch, HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch, HADOOP-9425-6.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[ https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650699#comment-13650699 ] Hudson commented on HADOOP-9425: Integrated in Hadoop-Yarn-trunk #202 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/202/]) HADOOP-9425 Add error codes to rpc-response (sanjay Radia) (Revision 1479143) Result = SUCCESS sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1479143 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcNoSuchMethodException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcNoSuchProtocolException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtobufRpcEngine.proto * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java Add error codes to rpc-response --- Key: HADOOP-9425 URL: https://issues.apache.org/jira/browse/HADOOP-9425 Project: Hadoop Common Issue Type: Sub-task Reporter: Sanjay Radia Assignee: Sanjay Radia Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch, HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch, HADOOP-9425-6.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[ https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650792#comment-13650792 ] Hudson commented on HADOOP-9425: Integrated in Hadoop-Hdfs-trunk #1391 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1391/]) HADOOP-9425 Add error codes to rpc-response (sanjay Radia) (Revision 1479143) Result = FAILURE sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1479143 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcNoSuchMethodException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcNoSuchProtocolException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtobufRpcEngine.proto * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java Add error codes to rpc-response --- Key: HADOOP-9425 URL: https://issues.apache.org/jira/browse/HADOOP-9425 Project: Hadoop Common Issue Type: Sub-task Reporter: Sanjay Radia Assignee: Sanjay Radia Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch, HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch, HADOOP-9425-6.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[ https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650847#comment-13650847 ] Hudson commented on HADOOP-9425: Integrated in Hadoop-Mapreduce-trunk #1418 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1418/]) HADOOP-9425 Add error codes to rpc-response (sanjay Radia) (Revision 1479143) Result = SUCCESS sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1479143 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcNoSuchMethodException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcNoSuchProtocolException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtobufRpcEngine.proto * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java Add error codes to rpc-response --- Key: HADOOP-9425 URL: https://issues.apache.org/jira/browse/HADOOP-9425 Project: Hadoop Common Issue Type: Sub-task Reporter: Sanjay Radia Assignee: Sanjay Radia Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch, HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch, HADOOP-9425-6.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[ https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650335#comment-13650335 ] Hudson commented on HADOOP-9425: Integrated in Hadoop-trunk-Commit #3712 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/3712/]) HADOOP-9425 Add error codes to rpc-response (sanjay Radia) (Revision 1479143) Result = SUCCESS sradia : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1479143 Files : * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcNoSuchMethodException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcNoSuchProtocolException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/WritableRpcEngine.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/ProtobufRpcEngine.proto * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/proto/RpcHeader.proto * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPCCompatibility.java Add error codes to rpc-response --- Key: HADOOP-9425 URL: https://issues.apache.org/jira/browse/HADOOP-9425 Project: Hadoop Common Issue Type: Sub-task Reporter: Sanjay Radia Assignee: Sanjay Radia Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch, HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch, HADOOP-9425-6.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[
https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13649116#comment-13649116
]
Hadoop QA commented on HADOOP-9425:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12581610/HADOOP-9425-6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2510//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2510//console
This message is automatically generated.
Add error codes to rpc-response
---
Key: HADOOP-9425
URL: https://issues.apache.org/jira/browse/HADOOP-9425
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch,
HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch,
HADOOP-9425-6.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[
https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13641307#comment-13641307
]
Tsz Wo (Nicholas), SZE commented on HADOOP-9425:
Patch looks good. Some suggestions:
- add the following methods to RpcServerException and override them in the
subclasses.
{code}
public RpcStatusProto getRpcStatusProto() {
return RpcStatusProto.ERROR;
}
public RpcErrorCodeProto getRpcErrorCodeProto() {
return RpcErrorCodeProto.ERROR_APP;
}
{code}
Then, use them in Server.Handler.run()
{code}
if (e instanceof RpcServerException) {
RpcServerException rse = ((RpcServerException)e);
returnStatus = rse.getRpcStatusProto();
detailedErr = rse.getRpcErrorCodeProto();
} else {
returnStatus = RpcStatusProto.ERROR;
detailedErr = RpcErrorCodeProto.ERROR_APP;
}
{code}
- Suggestion on the names in RpcErrorCodeProto:
-* ERROR_APP = ERROR_APPLICATION
-* ERROR_RPC_ERROR_SERIALIZING_RESPONSE = ERROR_SERIALIZING_RESPONSE
-* FATAL_UNK = FATAL_UNKNOWN
-* FATAL_IPC_SERIALIZATION = FATAL_UNSUPPORTED_SERIALIZATION
-* FATAL_DESERIALIZE_REQUEST = FATAL_DESERIALIZING_REQUEST
-* FATAL_AUTH_FAILED = FATAL_UNAUTHORIZED
Add error codes to rpc-response
---
Key: HADOOP-9425
URL: https://issues.apache.org/jira/browse/HADOOP-9425
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch,
HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[
https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13625908#comment-13625908
]
Hadoop QA commented on HADOOP-9425:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12577633/HADOOP-9425-5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2428//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2428//console
This message is automatically generated.
Add error codes to rpc-response
---
Key: HADOOP-9425
URL: https://issues.apache.org/jira/browse/HADOOP-9425
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch,
HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[ https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626072#comment-13626072 ] Sanjay Radia commented on HADOOP-9425: -- Updated patch: * error code is now exposed via remoteException on client side (note in earlier patch it was in the Call object which is not very accessible. * extended a couple of tests to check the return code * minor bug fix in writableRcpEngine - it was catching some of the rpc exceptions and re-throwing as IOException (note writableRpcEngine is still used for many of our rpc tests) Add error codes to rpc-response --- Key: HADOOP-9425 URL: https://issues.apache.org/jira/browse/HADOOP-9425 Project: Hadoop Common Issue Type: Sub-task Reporter: Sanjay Radia Assignee: Sanjay Radia Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch, HADOOP-9425-3.patch, HADOOP-9425-4.patch, HADOOP-9425-5.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[
https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624162#comment-13624162
]
Hadoop QA commented on HADOOP-9425:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12577305/HADOOP-9425-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2424//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2424//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2424//console
This message is automatically generated.
Add error codes to rpc-response
---
Key: HADOOP-9425
URL: https://issues.apache.org/jira/browse/HADOOP-9425
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch,
HADOOP-9425-3.patch, HADOOP-9425-4.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[ https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13618426#comment-13618426 ] Luke Lu commented on HADOOP-9425: - # It'd be more consistent if we rename the errorDetail field to errorCode. # Would appreciate a unit test, since it's a new feature. Add error codes to rpc-response --- Key: HADOOP-9425 URL: https://issues.apache.org/jira/browse/HADOOP-9425 Project: Hadoop Common Issue Type: Sub-task Reporter: Sanjay Radia Assignee: Sanjay Radia Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch, HADOOP-9425-3.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[
https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617753#comment-13617753
]
Hadoop QA commented on HADOOP-9425:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12576162/HADOOP-9425-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2383//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2383//console
This message is automatically generated.
Add error codes to rpc-response
---
Key: HADOOP-9425
URL: https://issues.apache.org/jira/browse/HADOOP-9425
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch,
HADOOP-9425-3.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[
https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617773#comment-13617773
]
Hadoop QA commented on HADOOP-9425:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12576168/HADOOP-9425-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2384//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2384//console
This message is automatically generated.
Add error codes to rpc-response
---
Key: HADOOP-9425
URL: https://issues.apache.org/jira/browse/HADOOP-9425
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch,
HADOOP-9425-3.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[ https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616152#comment-13616152 ] Luke Lu commented on HADOOP-9425: - A well defined set of error codes make sense. Couple of nits: # RpcDetailErrorProto might be better named as simply RpcErrorCodeProto. # Add a getter for the errorCode for a unit test, which would obviate the need of findbug suppression. Add error codes to rpc-response --- Key: HADOOP-9425 URL: https://issues.apache.org/jira/browse/HADOOP-9425 Project: Hadoop Common Issue Type: Sub-task Reporter: Sanjay Radia Assignee: Sanjay Radia Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[
https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13611106#comment-13611106
]
Hadoop QA commented on HADOOP-9425:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12575067/HADOOP-9425-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2355//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2355//console
This message is automatically generated.
Add error codes to rpc-response
---
Key: HADOOP-9425
URL: https://issues.apache.org/jira/browse/HADOOP-9425
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: HADOOP-9425-1.patch, HADOOP-9425-2.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9425) Add error codes to rpc-response
[
https://issues.apache.org/jira/browse/HADOOP-9425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609751#comment-13609751
]
Hadoop QA commented on HADOOP-9425:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12574923/HADOOP-9425-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 2
release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2353//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2353//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2353//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2353//console
This message is automatically generated.
Add error codes to rpc-response
---
Key: HADOOP-9425
URL: https://issues.apache.org/jira/browse/HADOOP-9425
Project: Hadoop Common
Issue Type: Sub-task
Reporter: Sanjay Radia
Assignee: Sanjay Radia
Attachments: HADOOP-9425-1.patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
