[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-04-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627670#comment-13627670
 ] 

Hudson commented on HADOOP-9437:


Integrated in Hadoop-Yarn-trunk #179 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/179/])
HADOOP-9437. TestNativeIO#testRenameTo fails on Windows due to assumption 
that POSIX errno is embedded in NativeIOException. Contributed by Chris 
Nauroth. (Revision 1466306)

 Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1466306
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java


 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Fix For: 3.0.0

 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch, 
 HADOOP-9437.3.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-04-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627759#comment-13627759
 ] 

Hudson commented on HADOOP-9437:


Integrated in Hadoop-Hdfs-trunk #1368 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1368/])
HADOOP-9437. TestNativeIO#testRenameTo fails on Windows due to assumption 
that POSIX errno is embedded in NativeIOException. Contributed by Chris 
Nauroth. (Revision 1466306)

 Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1466306
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java


 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Fix For: 3.0.0

 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch, 
 HADOOP-9437.3.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-04-10 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627814#comment-13627814
 ] 

Hudson commented on HADOOP-9437:


Integrated in Hadoop-Mapreduce-trunk #1395 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1395/])
HADOOP-9437. TestNativeIO#testRenameTo fails on Windows due to assumption 
that POSIX errno is embedded in NativeIOException. Contributed by Chris 
Nauroth. (Revision 1466306)

 Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1466306
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java


 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Fix For: 3.0.0

 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch, 
 HADOOP-9437.3.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-04-09 Thread Suresh Srinivas (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627317#comment-13627317
 ] 

Suresh Srinivas commented on HADOOP-9437:
-

+1 for the patch.

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch, 
 HADOOP-9437.3.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-04-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627324#comment-13627324
 ] 

Hudson commented on HADOOP-9437:


Integrated in Hadoop-trunk-Commit #3587 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/3587/])
HADOOP-9437. TestNativeIO#testRenameTo fails on Windows due to assumption 
that POSIX errno is embedded in NativeIOException. Contributed by Chris 
Nauroth. (Revision 1466306)

 Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1466306
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/nativeio/TestNativeIO.java


 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Fix For: 3.0.0

 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch, 
 HADOOP-9437.3.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-04-01 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619230#comment-13619230
 ] 

Hadoop QA commented on HADOOP-9437:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12576437/HADOOP-9437.3.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2391//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2391//console

This message is automatically generated.

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch, 
 HADOOP-9437.3.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-04-01 Thread Ivan Mitic (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13619476#comment-13619476
 ] 

Ivan Mitic commented on HADOOP-9437:


Thanks Chris, patch looks good, +1

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch, 
 HADOOP-9437.3.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-29 Thread Ivan Mitic (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617131#comment-13617131
 ] 

Ivan Mitic commented on HADOOP-9437:


I see, thanks for double checking Chris!

OK, I have one more minor comment since we're changing the native code anyways. 
To be semantically correct, we cannot assume that last error is properly set 
when we call the CRT rename API (its undocumented). Can we instead call 
[MoveFile|http://msdn.microsoft.com/en-us/library/windows/desktop/aa365239(v=vs.85).aspx]
 on Windows? (this is what rename does internally) Feel free to comment back 
with your take.

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-29 Thread Chris Nauroth (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617420#comment-13617420
 ] 

Chris Nauroth commented on HADOOP-9437:
---

{quote}
Can we instead call MoveFile on Windows?
{quote}

Sure, we can do that.  At this point, we already need conditional compilation, 
so we're not gaining much simplicity by trying to stick rigidly to CRT rename.  
I'll work on a new patch.

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-29 Thread Chuan Liu (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617578#comment-13617578
 ] 

Chuan Liu commented on HADOOP-9437:
---

I am also +1 on using native calls over CRT functions. The behaviors of CRT 
functions are more unpredictable in my experience.

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-29 Thread Chris Nauroth (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617602#comment-13617602
 ] 

Chris Nauroth commented on HADOOP-9437:
---

{quote}
The behaviors of CRT functions are more unpredictable in my experience.
{quote}

That's good to know.  Thanks, Chuan and Ivan!

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-28 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616946#comment-13616946
 ] 

Hadoop QA commented on HADOOP-9437:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12575807/HADOOP-9437.2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2374//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2374//console

This message is automatically generated.

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-27 Thread Ivan Mitic (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13614981#comment-13614981
 ] 

Ivan Mitic commented on HADOOP-9437:


Thanks Chris for the patch.

One comment on the patch. If I'm seeing things correctly, nativeio 
implementation for rename0 uses CRT#rename which returns errno code. On the 
other hand, Windows implementation for throw_ioe assumes winerror code. Can you 
please check if the two are compatible? 


 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-26 Thread Chris Nauroth (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13614292#comment-13614292
 ] 

Chris Nauroth commented on HADOOP-9437:
---

On Windows, most of the native code calls use a Windows API, which sets an 
error code visible by calling {{GetLastError}}.  These error codes are not 
guaranteed to match the POSIX errno values, so in general, it wouldn't make 
sense to perform the errno mapping on Windows.  However, we can still preserve 
the intent of HDFS-4428 and provide a detailed error message on Windows.  The 
Windows native implementation already maps the value of {{GetLastError}} to a 
detailed message by calling {{FormatMessage}}.  This becomes the message for 
the {{NativeIOException}}.  We just need to update the test assertions to check 
for these messages instead of the errno values on Windows.


 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth

 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-26 Thread Arpit Agarwal (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13614428#comment-13614428
 ] 

Arpit Agarwal commented on HADOOP-9437:
---

+1

Confirmed that users of NativeIO.renameTo do not care about the error code 
(outside of tests).

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-26 Thread Chris Nauroth (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13614430#comment-13614430
 ] 

Chris Nauroth commented on HADOOP-9437:
---

Thank you, Arpit.

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HADOOP-9437) TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno is embedded in NativeIOException

2013-03-26 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13614431#comment-13614431
 ] 

Hadoop QA commented on HADOOP-9437:
---

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12575554/HADOOP-9437.1.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2366//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2366//console

This message is automatically generated.

 TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
 is embedded in NativeIOException
 --

 Key: HADOOP-9437
 URL: https://issues.apache.org/jira/browse/HADOOP-9437
 Project: Hadoop Common
  Issue Type: Bug
  Components: test
Affects Versions: 3.0.0
Reporter: Chris Nauroth
Assignee: Chris Nauroth
 Attachments: HADOOP-9437.1.patch


 HDFS-4428 added a detailed error message for failures to rename files by 
 embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
 mapping of errno is not performed, so the errno enum value will not be 
 present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira