[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670231#comment-13670231
]
Hudson commented on HADOOP-9574:
Integrated in Hadoop-Yarn-trunk #225 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/225/])
HADOOP-9574. Fix for timing issues in the original patch's test-case.
(Revision 1487722)
HADOOP-9574. Added new methods in AbstractDelegationTokenSecretManager for
helping YARN ResourceManager to reuse code for RM restart. Contributed by Jian
He. (Revision 1487692)
Result = SUCCESS
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1487722
Files :
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1487692
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Fix For: 2.0.5-beta
Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch,
HADOOP-9574.fixtest.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670321#comment-13670321
]
Hudson commented on HADOOP-9574:
Integrated in Hadoop-Hdfs-trunk #1415 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1415/])
HADOOP-9574. Fix for timing issues in the original patch's test-case.
(Revision 1487722)
HADOOP-9574. Added new methods in AbstractDelegationTokenSecretManager for
helping YARN ResourceManager to reuse code for RM restart. Contributed by Jian
He. (Revision 1487692)
Result = FAILURE
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1487722
Files :
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1487692
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Fix For: 2.0.5-beta
Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch,
HADOOP-9574.fixtest.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670353#comment-13670353
]
Hudson commented on HADOOP-9574:
Integrated in Hadoop-Mapreduce-trunk #1441 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1441/])
HADOOP-9574. Fix for timing issues in the original patch's test-case.
(Revision 1487722)
HADOOP-9574. Added new methods in AbstractDelegationTokenSecretManager for
helping YARN ResourceManager to reuse code for RM restart. Contributed by Jian
He. (Revision 1487692)
Result = SUCCESS
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1487722
Files :
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1487692
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Fix For: 2.0.5-beta
Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch,
HADOOP-9574.fixtest.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669543#comment-13669543
]
Hadoop QA commented on HADOOP-9574:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12585265/HADOOP-9574.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2577//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2577//console
This message is automatically generated.
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669930#comment-13669930
]
Vinod Kumar Vavilapalli commented on HADOOP-9574:
-
Looks good, +1. Checking this in.
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669940#comment-13669940
]
Hudson commented on HADOOP-9574:
Integrated in Hadoop-trunk-Commit #3804 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/3804/])
HADOOP-9574. Added new methods in AbstractDelegationTokenSecretManager for
helping YARN ResourceManager to reuse code for RM restart. Contributed by Jian
He. (Revision 1487692)
Result = SUCCESS
vinodkv :
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1487692
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/DelegationKey.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Fix For: 2.0.5-beta
Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1366#comment-1366
]
Jian He commented on HADOOP-9574:
-
The jeckin link of the possible test failure
https://issues.apache.org/jira/browse/MAPREDUCE-5261?focusedCommentId=13669981page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13669981
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Fix For: 2.0.5-beta
Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch,
HADOOP-9574.fixtest.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13670017#comment-13670017
]
Hadoop QA commented on HADOOP-9574:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12585356/HADOOP-9574.fixtest.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2585//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2585//console
This message is automatically generated.
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Fix For: 2.0.5-beta
Attachments: HADOOP-9574.1.patch, HADOOP-9574.2.patch,
HADOOP-9574.fixtest.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13666867#comment-13666867
]
Vinod Kumar Vavilapalli commented on HADOOP-9574:
-
Want to move forward with this for the sake of YARN-638.
Mostly looks good to me. Can you add tests to make sure these new APIs are
correctly called? You can modify TestDelegationTokenSecretManager.
Also, a couple of simple tests for DelegationKey changes will be great.
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Attachments: HADOOP-9574.1.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662334#comment-13662334
]
Hadoop QA commented on HADOOP-9574:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12583877/HADOOP-9574.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2551//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2551//console
This message is automatically generated.
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Attachments: HADOOP-9574.1.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9574) Add new methods in AbstractDelegationTokenSecretManager for restoring RMDelegationTokens on RMRestart
[
https://issues.apache.org/jira/browse/HADOOP-9574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13662347#comment-13662347
]
Jian He commented on HADOOP-9574:
-
This patch simply adds several empty methods in
AbstractDelegationTokenSecretManager, and add them in corresponding places
where create/remove tokens/keys occur.
Also, implement hashCode and equals method in DelegationKey.
And copy hdfsDelegationTokenSecretManager.addPersistedDelegationToken to
AbstractDelegationTokenSecretManager
Add new methods in AbstractDelegationTokenSecretManager for restoring
RMDelegationTokens on RMRestart
-
Key: HADOOP-9574
URL: https://issues.apache.org/jira/browse/HADOOP-9574
Project: Hadoop Common
Issue Type: Bug
Reporter: Jian He
Assignee: Jian He
Attachments: HADOOP-9574.1.patch
we're considering to add the following methods in
AbstractDelegationTokenSecretManager for restoring RMDelegationTokens, these
methods can also possibly be reused by hdfsDelegationTokenSecretManager, see
YARN-638
protected void storeNewMasterKey(DelegationKey key) throws IOException {
return;
}
protected void removeStoredMasterKey(DelegationKey key) {
return;
}
protected void storeNewToken(TokenIdent ident, long renewDate) {
return;
}
protected void removeStoredToken(TokenIdent ident) throws IOException {
}
protected void updateStoredToken(TokenIdent ident, long renewDate) {
return;
}
Also move addPersistedDelegationToken in hdfs.DelegationTokenSecretManager,
to AbstractDelegationTokenSecretManager
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
