[jira] [Commented] (HADOOP-9651) Filesystems to throw FileAlreadyExistsException in createFile(path, overwrite=false) when the file exists
[
https://issues.apache.org/jira/browse/HADOOP-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13701916#comment-13701916
]
Steve Loughran commented on HADOOP-9651:
Core patch looks good, though you need to make sure that your IDE isn't turning
imports into .* imports -having them leave all imports alone is the best way to
avoid gratuitous diff/merge problems.
I'll add common contract tests for this then merge in the exception
modifications
Filesystems to throw FileAlreadyExistsException in createFile(path,
overwrite=false) when the file exists
-
Key: HADOOP-9651
URL: https://issues.apache.org/jira/browse/HADOOP-9651
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 2.1.0-beta
Reporter: Steve Loughran
Priority: Minor
Attachments: HADOOP-9651.patch
While HDFS and other filesystems throw a {{FileAlreadyExistsException}} if
you try to create a file that exists and you have set {{overwrite=false}},
{{RawLocalFileSystem}} throws a plain {{IOException}}. This makes it
impossible to distinguish a create operation failing from a fixable problem
(the file is there) and something more fundamental.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9651) Filesystems to throw FileAlreadyExistsException in createFile(path, overwrite=false) when the file exists
[
https://issues.apache.org/jira/browse/HADOOP-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13689033#comment-13689033
]
Hadoop QA commented on HADOOP-9651:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12588785/HADOOP-9651.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2683//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2683//console
This message is automatically generated.
Filesystems to throw FileAlreadyExistsException in createFile(path,
overwrite=false) when the file exists
-
Key: HADOOP-9651
URL: https://issues.apache.org/jira/browse/HADOOP-9651
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 2.1.0-beta
Reporter: Steve Loughran
Priority: Minor
Attachments: HADOOP-9651.patch
While HDFS and other filesystems throw a {{FileAlreadyExistsException}} if
you try to create a file that exists and you have set {{overwrite=false}},
{{RawLocalFileSystem}} throws a plain {{IOException}}. This makes it
impossible to distinguish a create operation failing from a fixable problem
(the file is there) and something more fundamental.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9651) Filesystems to throw FileAlreadyExistsException in createFile(path, overwrite=false) when the file exists
[
https://issues.apache.org/jira/browse/HADOOP-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686763#comment-13686763
]
Steve Loughran commented on HADOOP-9651:
Here I propose
# saying MUST throw {{FileAlreadyExistsException}}
# fixing all the hadoop filesystems to do this where they do not today.
# making sure the FS tests check for this.
HDFS already has the correct behaviour, as do the blobstore(s).
Filesystems to throw FileAlreadyExistsException in createFile(path,
overwrite=false) when the file exists
-
Key: HADOOP-9651
URL: https://issues.apache.org/jira/browse/HADOOP-9651
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 2.1.0-beta
Reporter: Steve Loughran
Priority: Minor
While HDFS and other filesystems throw a {{FileAlreadyExistsException}} if
you try to create a file that exists and you have set {{overwrite=false}},
{{RawLocalFileSystem}} throws a plain {{IOException}}. This makes it
impossible to distinguish a create operation failing from a fixable problem
(the file is there) and something more fundamental.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9651) Filesystems to throw FileAlreadyExistsException in createFile(path, overwrite=false) when the file exists
[
https://issues.apache.org/jira/browse/HADOOP-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686765#comment-13686765
]
Steve Loughran commented on HADOOP-9651:
stack
{code}
ava.io.IOException: File already exists: file:/Users/stevel/tmp/buffer.json
at
org.apache.hadoop.fs.RawLocalFileSystem.create(RawLocalFileSystem.java:276)
at
org.apache.hadoop.fs.RawLocalFileSystem.create(RawLocalFileSystem.java:269)
at
org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSOutputSummer.init(ChecksumFileSystem.java:382)
at
org.apache.hadoop.fs.ChecksumFileSystem.create(ChecksumFileSystem.java:430)
at
org.apache.hadoop.fs.ChecksumFileSystem.create(ChecksumFileSystem.java:411)
at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:888)
at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:869)
at org.apache.hadoop.fs.FileSystem.create(FileSystem.java:768)
{code}
Filesystems to throw FileAlreadyExistsException in createFile(path,
overwrite=false) when the file exists
-
Key: HADOOP-9651
URL: https://issues.apache.org/jira/browse/HADOOP-9651
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 2.1.0-beta
Reporter: Steve Loughran
Priority: Minor
While HDFS and other filesystems throw a {{FileAlreadyExistsException}} if
you try to create a file that exists and you have set {{overwrite=false}},
{{RawLocalFileSystem}} throws a plain {{IOException}}. This makes it
impossible to distinguish a create operation failing from a fixable problem
(the file is there) and something more fundamental.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9651) Filesystems to throw FileAlreadyExistsException in createFile(path, overwrite=false) when the file exists
[
https://issues.apache.org/jira/browse/HADOOP-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687119#comment-13687119
]
Jean-Baptiste Onofré commented on HADOOP-9651:
--
I'm reviewing the other filesystems to see if some updates are required to
correctly throw FileAlreadyExistsException.
Filesystems to throw FileAlreadyExistsException in createFile(path,
overwrite=false) when the file exists
-
Key: HADOOP-9651
URL: https://issues.apache.org/jira/browse/HADOOP-9651
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 2.1.0-beta
Reporter: Steve Loughran
Priority: Minor
Attachments: HADOOP-9651.patch
While HDFS and other filesystems throw a {{FileAlreadyExistsException}} if
you try to create a file that exists and you have set {{overwrite=false}},
{{RawLocalFileSystem}} throws a plain {{IOException}}. This makes it
impossible to distinguish a create operation failing from a fixable problem
(the file is there) and something more fundamental.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9651) Filesystems to throw FileAlreadyExistsException in createFile(path, overwrite=false) when the file exists
[
https://issues.apache.org/jira/browse/HADOOP-9651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13687153#comment-13687153
]
Hadoop QA commented on HADOOP-9651:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12588436/HADOOP-9651.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2664//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2664//console
This message is automatically generated.
Filesystems to throw FileAlreadyExistsException in createFile(path,
overwrite=false) when the file exists
-
Key: HADOOP-9651
URL: https://issues.apache.org/jira/browse/HADOOP-9651
Project: Hadoop Common
Issue Type: Sub-task
Components: fs
Affects Versions: 2.1.0-beta
Reporter: Steve Loughran
Priority: Minor
Attachments: HADOOP-9651.patch
While HDFS and other filesystems throw a {{FileAlreadyExistsException}} if
you try to create a file that exists and you have set {{overwrite=false}},
{{RawLocalFileSystem}} throws a plain {{IOException}}. This makes it
impossible to distinguish a create operation failing from a fixable problem
(the file is there) and something more fundamental.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
