[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016232#comment-14016232 ] Ravi Prakash commented on HADOOP-9704: -- Ok! The failure percentage of the test is practically the same on my computer with or without the patch. Committing. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016175#comment-14016175 ] Ravi Prakash commented on HADOOP-9704: -- Hmmm... Changed my mind. Will wait up. I'm going to queue in running the test a 100 times on unpatched trunk to see if that sees intermittent failures too. The nature of the tests might mean an increase in EXTRA_TIMEOUT_SECS is in order, but that's probably a seperate JIRA and I want to understand the reasons why this patch might increase that time. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016170#comment-14016170 ] Ravi Prakash commented on HADOOP-9704: -- I was able to get {{TestZKFailoverControllerStress}} to pass as well fail intermittently with the patch applied. https://issues.apache.org/jira/browse/HADOOP-9555 seems to be tracking the issue. I'll check this in momentarily > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015930#comment-14015930 ] Hadoop QA commented on HADOOP-9704: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647689/HADOOP-9704.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverControllerStress {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3996//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3996//console This message is automatically generated. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015760#comment-14015760 ] Ravi Prakash commented on HADOOP-9704: -- Ok. Patch lgtm. If I hear no objections, I'll check it in EOD > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013912#comment-14013912 ] Babak Behzad commented on HADOOP-9704: -- Thanks both Ravi and Luke. I fixed the tabs and the formatting and attached a new patch. Hopefully it is correct and sorry about that. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011743#comment-14011743 ] Luke Lu commented on HADOOP-9704: - The patch looks good overall. Thanks [~babakbehzad]! Please remove the tabs in the source and format according to https://wiki.apache.org/hadoop/CodeReviewChecklist > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011733#comment-14011733 ] Luke Lu commented on HADOOP-9704: - [~raviprak]: Exceptions in sink impls won't bring down the daemon. The metrics system is designed to be resilient to transient back-end errors. It'll do retries according to config as well. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011689#comment-14011689 ] Ravi Prakash commented on HADOOP-9704: -- Thanks Babak! Also, I noticed you are rethrowing a MetricsException whenever you catch an exception. Is this going to bring down the entire daemon? That would be bad. [~vicaya] I noticed GraphiteSink30.java also does the same thing. Is that bad too? > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011294#comment-14011294 ] Babak Behzad commented on HADOOP-9704: -- Thanks Ravi. So, in order to enable this one has to put the following three lines in etc/hadoop-metrics2.properties for each of the contexts (namenode, datanode, resource manager, etc): namenode.sink.graphite.server_host=localhost namenode.sink.graphite.server_port=2003 namenode.sink.graphite.metrics_prefix=test.namenode Looking at the logs and source code, the socket connection is only created once in the init() function for each of these contexts that you enable them, so at most 5 new connections are created. This is exactly the same as other sinks such as FileSink and GangliaSink and I don't think it is an issue. Regarding a slow Graphite server, that's a good point. We will be able to test this soon, but again looking at the current Hadoop code, Ganglia's sink is using DatagramSocket instead of Socket. I am not sure if we need to do that later if we see problems with the current code. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010122#comment-14010122 ] Ravi Prakash commented on HADOOP-9704: -- Also, would I open a new connection to the same graphite server for each metric? > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010098#comment-14010098 ] Ravi Prakash commented on HADOOP-9704: -- What would happen if the Graphite server at the end of the socket was slow? BTW, we see this all the time. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009963#comment-14009963 ] Alex Newman commented on HADOOP-9704: - +1 > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009925#comment-14009925 ] Babak Behzad commented on HADOOP-9704: -- We need this feature in our company and I got the patch and used it. There was a small bug which caused Graphite to ignore a lot of metrics (some of the metrics have space in their name and Graphite do not handle them). I fixed that and I also fixed all the three feedbacks that [~vicaya] mentioned in the above comment. Can someone please review this patch before I submit it? > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch, Hadoop-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781494#comment-13781494 ] Luke Lu commented on HADOOP-9704: - Thanks for the patch, Alex and Chu! Both of you will be credited :) Feedback for the latest patch: # There is no need to do context filtering in a sink implemention, as metrics filtering is provided by framework itself for any sinks. Though currently, context filtering is either all or a particular context, though individual record and metrics can handle glob patterns. File another JIRA for support context globbing (simple to implement) if that's what you want. # Use StringBuilder instead of StringBuffer as the buffer is not shared across threads, hence no need to pay the synchronized penalty. # ArgumentCaptor should work with a mockito mock writer (use #getAllValues to access values from multiple invocations). There is no need to do manual capture. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781481#comment-13781481 ] Hadoop QA commented on HADOOP-9704: --- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12605820/HADOOP-9704.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3144//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3144//console This message is automatically generated. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch, HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780658#comment-13780658 ] Hadoop QA commented on HADOOP-9704: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12605623/0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3140//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3140//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3140//console This message is automatically generated. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: > 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch, > HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13780636#comment-13780636 ] Hadoop QA commented on HADOOP-9704: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12605615/HADOOP-9704.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3139//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/3139//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3139//console This message is automatically generated. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > Attachments: HADOOP-9704.patch > > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736187#comment-13736187 ] Chu Tong commented on HADOOP-9704: -- Hi Alex, Sorry for the delay. Actually, I have done the code and will post it soon. I took a look at your code and they look somewhat similar to mine. Why do not we wait for me to post my version and let's see how it goes from there? > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724659#comment-13724659 ] Alex Newman commented on HADOOP-9704: - Feel free to assign to me. > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13724657#comment-13724657 ] Alex Newman commented on HADOOP-9704: - I did this recently: https://github.com/posix4e/GraphiteContext v1 metrics https://github.com/posix4e/GraphiteMetrics2 v2 metrics > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9704) Write metrics sink plugin for Hadoop/Graphite
[ https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701534#comment-13701534 ] Nikhil Mulley commented on HADOOP-9704: --- I was just thinking of this, it looks very much desired for Ops. Would be great to see this developed, voting for it. Nikhil > Write metrics sink plugin for Hadoop/Graphite > - > > Key: HADOOP-9704 > URL: https://issues.apache.org/jira/browse/HADOOP-9704 > Project: Hadoop Common > Issue Type: New Feature >Affects Versions: 2.0.3-alpha >Reporter: Chu Tong > > Write a metrics sink plugin for Hadoop to send metrics directly to Graphite > in additional to the current ganglia and file ones. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira