[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536397#comment-14536397 ] Hudson commented on HADOOP-9729: SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/]) HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java * hadoop-common-project/hadoop-common/CHANGES.txt The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Assignee: hellojinjie Fix For: 2.8.0 Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536446#comment-14536446 ] Hudson commented on HADOOP-9729: SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/922/]) HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Assignee: hellojinjie Fix For: 2.8.0 Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536699#comment-14536699 ] Hudson commented on HADOOP-9729: SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/]) HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java * hadoop-common-project/hadoop-common/CHANGES.txt The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Assignee: hellojinjie Fix For: 2.8.0 Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536541#comment-14536541 ] Hudson commented on HADOOP-9729: FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/]) HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Assignee: hellojinjie Fix For: 2.8.0 Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536592#comment-14536592 ] Hudson commented on HADOOP-9729: FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/]) HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java * hadoop-common-project/hadoop-common/CHANGES.txt The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Assignee: hellojinjie Fix For: 2.8.0 Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536652#comment-14536652 ] Hudson commented on HADOOP-9729: SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/]) HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java * hadoop-common-project/hadoop-common/CHANGES.txt The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Assignee: hellojinjie Fix For: 2.8.0 Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534357#comment-14534357 ] nijel commented on HADOOP-9729: --- patch looks good +1 The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Labels: BB-2015-05-RFC Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535581#comment-14535581 ] Jason Lowe commented on HADOOP-9729: +1 lgtm. Committing this. The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Assignee: hellojinjie Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14535742#comment-14535742 ] Hudson commented on HADOOP-9729: FAILURE: Integrated in Hadoop-trunk-Commit #7779 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7779/]) HADOOP-9729. The example code of org.apache.hadoop.util.Tool is incorrect. Contributed by hellojinjie (jlowe: rev ec2748dedbc500bd554aa62ca76ccab593129966) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/Tool.java The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Assignee: hellojinjie Fix For: 2.8.0 Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[
https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525382#comment-14525382
]
Hadoop QA commented on HADOOP-9729:
---
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 34s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 27s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 4s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 32s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 38s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 3s | Tests passed in
hadoop-common. |
| | | 59m 54s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12598170/HADOOP-9729.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 57d9a97 |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6398/console |
This message was automatically generated.
The example code of org.apache.hadoop.util.Tool is incorrect
Key: HADOOP-9729
URL: https://issues.apache.org/jira/browse/HADOOP-9729
Project: Hadoop Common
Issue Type: Bug
Components: util
Affects Versions: 1.1.2
Reporter: hellojinjie
Attachments: HADOOP-9729.patch
Original Estimate: 1h
Remaining Estimate: 1h
see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html
function public int run(String[] args) has no return value in the example
code
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[
https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13740841#comment-13740841
]
Hadoop QA commented on HADOOP-9729:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12598170/HADOOP-9729.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2986//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2986//console
This message is automatically generated.
The example code of org.apache.hadoop.util.Tool is incorrect
Key: HADOOP-9729
URL: https://issues.apache.org/jira/browse/HADOOP-9729
Project: Hadoop Common
Issue Type: Bug
Components: util
Affects Versions: 1.1.2
Reporter: hellojinjie
Attachments: HADOOP-9729.patch
Original Estimate: 1h
Remaining Estimate: 1h
see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html
function public int run(String[] args) has no return value in the example
code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13740850#comment-13740850 ] hellojinjie commented on HADOOP-9729: - I just modify the comment, so, it's no need to add tests or modify tests. The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Attachments: HADOOP-9729.patch Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708259#comment-13708259 ] Harsh J commented on HADOOP-9729: - Good point, I suppose that can be fixed. Would you like to submit a docs patch for this? The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708265#comment-13708265 ] hellojinjie commented on HADOOP-9729: - [~qwertymaniac] OK, I will submit a patch later.. h, It seems that I have to learn how to submit a patch ...hehe The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[ https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708243#comment-13708243 ] Harsh J commented on HADOOP-9729: - This was fixed in trunk and current versions (2.x): http://hadoop.apache.org/docs/current/api/org/apache/hadoop/util/Tool.html The example code of org.apache.hadoop.util.Tool is incorrect Key: HADOOP-9729 URL: https://issues.apache.org/jira/browse/HADOOP-9729 Project: Hadoop Common Issue Type: Bug Components: util Affects Versions: 1.1.2 Reporter: hellojinjie Original Estimate: 1h Remaining Estimate: 1h see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html function public int run(String[] args) has no return value in the example code -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9729) The example code of org.apache.hadoop.util.Tool is incorrect
[
https://issues.apache.org/jira/browse/HADOOP-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708253#comment-13708253
]
hellojinjie commented on HADOOP-9729:
-
[~qwertymaniac] why always return 0, regardless of the job status?
RunningJob runningJob = JobClient.runJob(job);
if (runningJob.isSuccessful()) {
return 0;
} else {
return -1;
}
The example code of org.apache.hadoop.util.Tool is incorrect
Key: HADOOP-9729
URL: https://issues.apache.org/jira/browse/HADOOP-9729
Project: Hadoop Common
Issue Type: Bug
Components: util
Affects Versions: 1.1.2
Reporter: hellojinjie
Original Estimate: 1h
Remaining Estimate: 1h
see http://hadoop.apache.org/docs/stable/api/org/apache/hadoop/util/Tool.html
function public int run(String[] args) has no return value in the example
code
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
