[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022880#comment-15022880
]
Hadoop QA commented on HADOOP-9822:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
24s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 41s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 45s
{color} | {color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 4s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
16s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 16s
{color} | {color:red} hadoop-common-project/hadoop-common in trunk has 1 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s
{color} | {color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
42s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 50s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 50s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 34s
{color} | {color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 34s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 0s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
58s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 4s
{color} | {color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 6m 59s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 19s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.7.0_85. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 68m 50s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests | hadoop.fs.permission.TestFsPermission |
| | hadoop.io.compress.TestCompressorDecompressor |
| JDK v1.8.0_66 Timed out junit tests |
org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor |
| JDK v1.7.0_85 Failed junit tests | hadoop.fs.permission.TestFsPermission |
| | hadoop.http.TestHttpServer |
| | hadoop.security.ssl.TestReloadingX509TrustManager |
| | hadoop.io.compress.TestCompressorDecompressor |
| JDK v1.7.0_85 Timed out
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023218#comment-15023218 ] Hudson commented on HADOOP-9822: FAILURE: Integrated in Hadoop-Mapreduce-trunk #2647 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2647/]) HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in > RetryCache constructor > --- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.3.0 >Reporter: Tsuyoshi Ozawa >Assignee: Tsuyoshi Ozawa >Priority: Minor > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, > HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding > magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023252#comment-15023252 ] Hudson commented on HADOOP-9822: FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #707 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/707/]) HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in > RetryCache constructor > --- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.3.0 >Reporter: Tsuyoshi Ozawa >Assignee: Tsuyoshi Ozawa >Priority: Minor > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, > HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding > magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023797#comment-15023797 ] Hudson commented on HADOOP-9822: FAILURE: Integrated in Hadoop-Hdfs-trunk #2572 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/2572/]) HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in > RetryCache constructor > --- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.3.0 >Reporter: Tsuyoshi Ozawa >Assignee: Tsuyoshi Ozawa >Priority: Minor > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, > HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding > magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023486#comment-15023486 ] Hudson commented on HADOOP-9822: FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #633 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/633/]) HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in > RetryCache constructor > --- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.3.0 >Reporter: Tsuyoshi Ozawa >Assignee: Tsuyoshi Ozawa >Priority: Minor > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, > HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding > magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023337#comment-15023337 ] Hudson commented on HADOOP-9822: FAILURE: Integrated in Hadoop-Yarn-trunk #1440 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/1440/]) HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java * hadoop-common-project/hadoop-common/CHANGES.txt > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in > RetryCache constructor > --- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.3.0 >Reporter: Tsuyoshi Ozawa >Assignee: Tsuyoshi Ozawa >Priority: Minor > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, > HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding > magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023374#comment-15023374 ] Hudson commented on HADOOP-9822: SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #717 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/717/]) HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in > RetryCache constructor > --- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.3.0 >Reporter: Tsuyoshi Ozawa >Assignee: Tsuyoshi Ozawa >Priority: Minor > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, > HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding > magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023096#comment-15023096 ] Haohui Mai commented on HADOOP-9822: +1 > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in > RetryCache constructor > --- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.3.0 >Reporter: Tsuyoshi Ozawa >Assignee: Tsuyoshi Ozawa >Priority: Minor > Labels: BB2015-05-TBR > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, > HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding > magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023146#comment-15023146 ] Hudson commented on HADOOP-9822: SUCCESS: Integrated in Hadoop-trunk-Commit #8865 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/8865/]) HADOOP-9822. create constant MAX_CAPACITY in RetryCache rather than (wheat9: rev 5f269a0ad81bb6abc5242bf628f028ae6812f6b3) * hadoop-common-project/hadoop-common/CHANGES.txt * hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RetryCache.java > create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in > RetryCache constructor > --- > > Key: HADOOP-9822 > URL: https://issues.apache.org/jira/browse/HADOOP-9822 > Project: Hadoop Common > Issue Type: Bug >Affects Versions: 2.3.0 >Reporter: Tsuyoshi Ozawa >Assignee: Tsuyoshi Ozawa >Priority: Minor > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, > HADOOP-9822.3.patch, HADOOP-9822.4.patch > > > The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding > magic number "16" is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021432#comment-15021432
]
Hadoop QA commented on HADOOP-9822:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s
{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
46s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 6s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 30s
{color} | {color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s {color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 1s
{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} trunk passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 47s
{color} | {color:red} hadoop-common-project/hadoop-common in trunk has 1 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} trunk passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s
{color} | {color:green} trunk passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
46s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 43s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 7m 43s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 29s
{color} | {color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 29s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 15s
{color} | {color:red} Patch generated 1 new checkstyle issues in
hadoop-common-project/hadoop-common (total was 15, now 16). {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 0s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
56s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s
{color} | {color:green} the patch passed with JDK v1.8.0_66 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s
{color} | {color:green} the patch passed with JDK v1.7.0_85 {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 6s {color} |
{color:red} hadoop-common in the patch failed with JDK v1.8.0_66. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 7m 18s {color}
| {color:red} hadoop-common in the patch failed with JDK v1.7.0_85. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
23s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 68m 53s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_66 Failed junit tests | hadoop.fs.permission.TestFsPermission |
| | hadoop.io.compress.TestCompressorDecompressor |
| JDK v1.8.0_66 Timed out junit tests |
org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor |
| JDK v1.7.0_85 Failed junit tests | hadoop.fs.permission.TestFsPermission |
| | hadoop.io.compress.TestCompressorDecompressor |
| JDK v1.7.0_85 Timed out junit tests |
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15021362#comment-15021362
]
Haohui Mai commented on HADOOP-9822:
Looks good to me overall.
{code}
private final int MAX_CAPACITY = 16;
{code}
Should be private static final.
> create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in
> RetryCache constructor
> ---
>
> Key: HADOOP-9822
> URL: https://issues.apache.org/jira/browse/HADOOP-9822
> Project: Hadoop Common
> Issue Type: Bug
>Affects Versions: 2.3.0
>Reporter: Tsuyoshi Ozawa
>Assignee: Tsuyoshi Ozawa
>Priority: Minor
> Labels: BB2015-05-TBR
> Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch,
> HADOOP-9822.3.patch
>
>
> The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding
> magic number "16" is a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14525611#comment-14525611
]
Hadoop QA commented on HADOOP-9822:
---
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 51s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 32s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 45s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 6s | The applied patch generated 1
new checkstyle issues (total was 14, now 15). |
| {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 42s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 23m 41s | Tests passed in
hadoop-common. |
| | | 61m 14s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6ae2a0d |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6443/console |
This message was automatically generated.
create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in
RetryCache constructor
---
Key: HADOOP-9822
URL: https://issues.apache.org/jira/browse/HADOOP-9822
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Tsuyoshi Ozawa
Assignee: Tsuyoshi Ozawa
Priority: Minor
Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch,
HADOOP-9822.3.patch
The magic number 16 is also used in ClientId.BYTE_LENGTH, so hard-coding
magic number 16 is a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[ https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14121221#comment-14121221 ] Tsuyoshi OZAWA commented on HADOOP-9822: [~cmccabe], do you mind taking a look? I think it's ready for review. create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor --- Key: HADOOP-9822 URL: https://issues.apache.org/jira/browse/HADOOP-9822 Project: Hadoop Common Issue Type: Bug Affects Versions: 2.3.0 Reporter: Tsuyoshi OZAWA Assignee: Tsuyoshi OZAWA Priority: Minor Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch, HADOOP-9822.3.patch The magic number 16 is also used in ClientId.BYTE_LENGTH, so hard-coding magic number 16 is a bit confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14121246#comment-14121246
]
Hadoop QA commented on HADOOP-9822:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch
against trunk revision 8f1a668.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4648//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4648//console
This message is automatically generated.
create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in
RetryCache constructor
---
Key: HADOOP-9822
URL: https://issues.apache.org/jira/browse/HADOOP-9822
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Tsuyoshi OZAWA
Assignee: Tsuyoshi OZAWA
Priority: Minor
Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch,
HADOOP-9822.3.patch
The magic number 16 is also used in ClientId.BYTE_LENGTH, so hard-coding
magic number 16 is a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13936166#comment-13936166
]
Hadoop QA commented on HADOOP-9822:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12634912/HADOOP-9822.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3676//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3676//console
This message is automatically generated.
create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in
RetryCache constructor
---
Key: HADOOP-9822
URL: https://issues.apache.org/jira/browse/HADOOP-9822
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 2.3.0
Reporter: Tsuyoshi OZAWA
Assignee: Tsuyoshi OZAWA
Priority: Minor
Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch,
HADOOP-9822.3.patch
The magic number 16 is also used in ClientId.BYTE_LENGTH, so hard-coding
magic number 16 is a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884960#comment-13884960
]
Hadoop QA commented on HADOOP-9822:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12596295/HADOOP-9822.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3495//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3495//console
This message is automatically generated.
create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in
RetryCache constructor
---
Key: HADOOP-9822
URL: https://issues.apache.org/jira/browse/HADOOP-9822
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 3.0.0, 2.1.1-beta, 2.3.0
Reporter: Tsuyoshi OZAWA
Assignee: Tsuyoshi OZAWA
Priority: Minor
Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch
The magic number 16 is also used in ClientId.BYTE_LENGTH, so hard-coding
magic number 16 is a bit confusing.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (HADOOP-9822) create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in RetryCache constructor
[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730558#comment-13730558
]
Hadoop QA commented on HADOOP-9822:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12596295/HADOOP-9822.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2931//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2931//console
This message is automatically generated.
create constant MAX_CAPACITY in RetryCache rather than hard-coding 16 in
RetryCache constructor
---
Key: HADOOP-9822
URL: https://issues.apache.org/jira/browse/HADOOP-9822
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 3.0.0, 2.3.0, 2.1.1-beta
Reporter: Tsuyoshi OZAWA
Assignee: Tsuyoshi OZAWA
Priority: Minor
Attachments: HADOOP-9822.1.patch, HADOOP-9822.2.patch
The magic number 16 is also used in ClientId.BYTE_LENGTH, so hard-coding
magic number 16 is a bit confusing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
