[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797782#comment-13797782
]
Hudson commented on HADOOP-9897:
SUCCESS: Integrated in Hadoop-Yarn-trunk #365 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/365/])
HADOOP-9897. Add method to get path start position without drive specifier in
o.a.h.fs.Path. Contributed by Binglin Chang. (cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1532880)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0, 2.3.0
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch,
HADOOP-9897.v5.patch, HADOOP-9897.v6.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797882#comment-13797882
]
Hudson commented on HADOOP-9897:
FAILURE: Integrated in Hadoop-Hdfs-trunk #1555 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1555/])
HADOOP-9897. Add method to get path start position without drive specifier in
o.a.h.fs.Path. Contributed by Binglin Chang. (cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1532880)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0, 2.3.0
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch,
HADOOP-9897.v5.patch, HADOOP-9897.v6.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797943#comment-13797943
]
Hudson commented on HADOOP-9897:
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1581 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1581/])
HADOOP-9897. Add method to get path start position without drive specifier in
o.a.h.fs.Path. Contributed by Binglin Chang. (cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1532880)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0, 2.3.0
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch,
HADOOP-9897.v5.patch, HADOOP-9897.v6.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796467#comment-13796467
]
Hadoop QA commented on HADOOP-9897:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12608662/HADOOP-9897.v6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3228//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3228//console
This message is automatically generated.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch,
HADOOP-9897.v5.patch, HADOOP-9897.v6.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797205#comment-13797205
]
Hudson commented on HADOOP-9897:
SUCCESS: Integrated in Hadoop-trunk-Commit #4614 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/4614/])
HADOOP-9897. Add method to get path start position without drive specifier in
o.a.h.fs.Path. Contributed by Binglin Chang. (cnauroth:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1532880)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestPath.java
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Fix For: 3.0.0, 2.3.0
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch,
HADOOP-9897.v5.patch, HADOOP-9897.v6.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795043#comment-13795043
]
Hadoop QA commented on HADOOP-9897:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12608461/HADOOP-9897.v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.TestPath
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3219//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3219//console
This message is automatically generated.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795214#comment-13795214
]
Hadoop QA commented on HADOOP-9897:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12608490/HADOOP-9897.v4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3220//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3220//console
This message is automatically generated.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795395#comment-13795395
]
Chris Nauroth commented on HADOOP-9897:
---
The most recent patch adds an unused import to {{TestPath}}. Aside from that,
it looks good. I'll take it for a full test run tonight.
Please disregard my earlier comment about adding new tests for
{{Path#getParent}}. I just realized that {{TestPath#testParent}} already
covers this.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796406#comment-13796406
]
Hadoop QA commented on HADOOP-9897:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12608647/HADOOP-9897.v5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3225//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3225//console
This message is automatically generated.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch,
HADOOP-9897.v5.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796449#comment-13796449
]
Chris Nauroth commented on HADOOP-9897:
---
It looks like the latest patch (v5) accidentally dropped
{{testIsWindowsAbsolutePath}}. I think we need v4, but with its unused import
removed.
The full test run was successful, so as soon as we upload a v6 patch and get +1
from Jenkins, I'll be ready to commit it. Thanks, Binglin!
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 3.0.0, 2.2.0
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch, HADOOP-9897.v3.patch, HADOOP-9897.v4.patch,
HADOOP-9897.v5.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794659#comment-13794659
]
Chris Nauroth commented on HADOOP-9897:
---
Hi, [~decster]. Thanks for the reminder. I think there are just a couple of
minor things left:
{code}
// Add path components explicitly, because simply contact two path string
// is not safe, for example:
{code}
I think contact was meant to be concatenating.
While reviewing this, I ended up writing some additional tests of
{{Path#isWindowsAbsolutePath}} to verify that they passed before and after the
patch. Could you please fold these into {{TestPath}} in your patch? We might
as well keep them around.
{code}
@Test
public void testIsWindowsAbsolutePath() {
if (!Shell.WINDOWS) return;
assertTrue(Path.isWindowsAbsolutePath(C:\\test, false));
assertTrue(Path.isWindowsAbsolutePath(C:/test, false));
assertTrue(Path.isWindowsAbsolutePath(/C:/test, true));
assertFalse(Path.isWindowsAbsolutePath(/test, false));
assertFalse(Path.isWindowsAbsolutePath(/test, true));
assertFalse(Path.isWindowsAbsolutePath(C:test, false));
assertFalse(Path.isWindowsAbsolutePath(/C:test, true));
}
{code}
Can we please also add similar tests covering {{Path#getParent}} when the path
has a Windows drive spec?
After that's done, I'll take the patch for a full test run across the whole
project tree on my Windows VM.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791328#comment-13791328
]
Binglin Chang commented on HADOOP-9897:
---
Hi [~cnauroth],
Could you help review the patch again and get this committed? Thanks.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749588#comment-13749588
]
Hadoop QA commented on HADOOP-9897:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12599776/HADOOP-9897.v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The following test timeouts occurred in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ipc.TestIPC
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3011//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3011//console
This message is automatically generated.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749639#comment-13749639
]
Binglin Chang commented on HADOOP-9897:
---
The failed test is probably due to timeout, it passed on my machine.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749688#comment-13749688
]
Hadoop QA commented on HADOOP-9897:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12599838/HADOOP-9897.v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3017//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3017//console
This message is automatically generated.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch, HADOOP-9897.v2.patch,
HADOOP-9897.v2.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9897) Add method to get path start position without drive specifier in o.a.h.fs.Path
[
https://issues.apache.org/jira/browse/HADOOP-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748911#comment-13748911
]
Chris Nauroth commented on HADOOP-9897:
---
It looks like this patch won't work now that HADOOP-9887 has been committed.
That patch added another call to {{Path#isWindowsAbsolutePath}}.
This is a public static method on a {{Public}} and {{Stable}} annotated class,
so changing this method signature would be backwards-incompatible. A safer
change would be to handle this just as an internal refactoring within {{Path}},
and keep the public method signatures the same.
Add method to get path start position without drive specifier in
o.a.h.fs.Path
Key: HADOOP-9897
URL: https://issues.apache.org/jira/browse/HADOOP-9897
Project: Hadoop Common
Issue Type: Improvement
Reporter: Binglin Chang
Assignee: Binglin Chang
Priority: Trivial
Attachments: HADOOP-9897.v1.patch
There are a lot of code in Path to get start position after skipping drive
specifier, like:
{code}
int start = hasWindowsDrive(uri.getPath()) ? 3 : 0;
{code}
Also there is a minor bug in mergePaths:
mergePath(/, /foo) will yield Path(//foo) which will be parsed as uri
authority, not path.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
