[jira] [Commented] (HADOOP-9918) Add addIfService() to CompositeService
[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755479#comment-13755479
]
Hudson commented on HADOOP-9918:
SUCCESS: Integrated in Hadoop-Yarn-trunk #318 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/318/])
HADOOP-9918. Add addIfService to CompositeService (Karthik Kambatla via Sandy
Ryza) (sandy:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519129)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java
*
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
Add addIfService() to CompositeService
--
Key: HADOOP-9918
URL: https://issues.apache.org/jira/browse/HADOOP-9918
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Minor
Labels: service
Fix For: 2.1.1-beta
Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch,
hadoop-9918-3.patch
Some YARN and MR classes implement their own version of {{addIfService(Object
object)}} that adds the service to CompositeService if the object is a
service.
It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9918) Add addIfService() to CompositeService
[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755507#comment-13755507
]
Hudson commented on HADOOP-9918:
FAILURE: Integrated in Hadoop-Hdfs-trunk #1508 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1508/])
HADOOP-9918. Add addIfService to CompositeService (Karthik Kambatla via Sandy
Ryza) (sandy:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519129)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java
*
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
Add addIfService() to CompositeService
--
Key: HADOOP-9918
URL: https://issues.apache.org/jira/browse/HADOOP-9918
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Minor
Labels: service
Fix For: 2.1.1-beta
Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch,
hadoop-9918-3.patch
Some YARN and MR classes implement their own version of {{addIfService(Object
object)}} that adds the service to CompositeService if the object is a
service.
It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9918) Add addIfService() to CompositeService
[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755529#comment-13755529
]
Hudson commented on HADOOP-9918:
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1535 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1535/])
HADOOP-9918. Add addIfService to CompositeService (Karthik Kambatla via Sandy
Ryza) (sandy:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519129)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java
*
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
Add addIfService() to CompositeService
--
Key: HADOOP-9918
URL: https://issues.apache.org/jira/browse/HADOOP-9918
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Minor
Labels: service
Fix For: 2.1.1-beta
Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch,
hadoop-9918-3.patch
Some YARN and MR classes implement their own version of {{addIfService(Object
object)}} that adds the service to CompositeService if the object is a
service.
It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9918) Add addIfService() to CompositeService
[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755028#comment-13755028
]
Hadoop QA commented on HADOOP-9918:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600819/hadoop-9918-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3045//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3045//console
This message is automatically generated.
Add addIfService() to CompositeService
--
Key: HADOOP-9918
URL: https://issues.apache.org/jira/browse/HADOOP-9918
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Minor
Labels: service
Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch,
hadoop-9918-3.patch
Some YARN and MR classes implement their own version of {{addIfService(Object
object)}} that adds the service to CompositeService if the object is a
service.
It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9918) Add addIfService() to CompositeService
[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755366#comment-13755366
]
Hudson commented on HADOOP-9918:
SUCCESS: Integrated in Hadoop-trunk-Commit #4356 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/4356/])
HADOOP-9918. Add addIfService to CompositeService (Karthik Kambatla via Sandy
Ryza) (sandy:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1519129)
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/service/CompositeService.java
*
/hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/util/TestCompositeService.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ResourceManager.java
Add addIfService() to CompositeService
--
Key: HADOOP-9918
URL: https://issues.apache.org/jira/browse/HADOOP-9918
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Minor
Labels: service
Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch,
hadoop-9918-3.patch
Some YARN and MR classes implement their own version of {{addIfService(Object
object)}} that adds the service to CompositeService if the object is a
service.
It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9918) Add addIfService() to CompositeService
[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753964#comment-13753964
]
Hadoop QA commented on HADOOP-9918:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600630/hadoop-9918-1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3034//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3034//console
This message is automatically generated.
Add addIfService() to CompositeService
--
Key: HADOOP-9918
URL: https://issues.apache.org/jira/browse/HADOOP-9918
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Minor
Labels: service
Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch
Some YARN and MR classes implement their own version of {{addIfService(Object
object)}} that adds the service to CompositeService if the object is a
service.
It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9918) Add addIfService() to CompositeService
[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13753982#comment-13753982
]
Hadoop QA commented on HADOOP-9918:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600632/hadoop-9918-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3035//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3035//console
This message is automatically generated.
Add addIfService() to CompositeService
--
Key: HADOOP-9918
URL: https://issues.apache.org/jira/browse/HADOOP-9918
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Minor
Labels: service
Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch
Some YARN and MR classes implement their own version of {{addIfService(Object
object)}} that adds the service to CompositeService if the object is a
service.
It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-9918) Add addIfService() to CompositeService
[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754072#comment-13754072
]
Steve Loughran commented on HADOOP-9918:
seems good, though some javadocs on the method would be nice
Add addIfService() to CompositeService
--
Key: HADOOP-9918
URL: https://issues.apache.org/jira/browse/HADOOP-9918
Project: Hadoop Common
Issue Type: Improvement
Affects Versions: 2.1.0-beta
Reporter: Karthik Kambatla
Assignee: Karthik Kambatla
Priority: Minor
Labels: service
Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch
Some YARN and MR classes implement their own version of {{addIfService(Object
object)}} that adds the service to CompositeService if the object is a
service.
It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
