[jira] [Updated] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-11524:
---
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed this to trunk. The test warnings are unrelated to any changes in
the shell code. Allen, thank you for the code review.
> hadoop_do_classpath_subcommand throws a shellcheck warning
> --
>
> Key: HADOOP-11524
> URL: https://issues.apache.org/jira/browse/HADOOP-11524
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Assignee: Chris Nauroth
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HADOOP-11524.001.patch
>
>
> {code}
> CLASS=org.apache.hadoop.util.Classpath
> ^-- SC2034: CLASS appears unused. Verify it or export it.
> {code}
> We should probably use a local var here and return it or something, even
> though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-11524:
---
Attachment: HADOOP-11524.001.patch
This patch avoids the warning by asking the caller to pass in the output
variable name to receive the class and then eval'ing it. I tested it through
the {{hadoop}}, {{hdfs}}, {{yarn}} and {{mapred}} entry points. [~aw], how
does this look?
> hadoop_do_classpath_subcommand throws a shellcheck warning
> --
>
> Key: HADOOP-11524
> URL: https://issues.apache.org/jira/browse/HADOOP-11524
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Assignee: Chris Nauroth
>Priority: Minor
> Attachments: HADOOP-11524.001.patch
>
>
> {code}
> CLASS=org.apache.hadoop.util.Classpath
> ^-- SC2034: CLASS appears unused. Verify it or export it.
> {code}
> We should probably use a local var here and return it or something, even
> though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-11524:
---
Status: Patch Available (was: Open)
> hadoop_do_classpath_subcommand throws a shellcheck warning
> --
>
> Key: HADOOP-11524
> URL: https://issues.apache.org/jira/browse/HADOOP-11524
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Assignee: Chris Nauroth
>Priority: Minor
> Attachments: HADOOP-11524.001.patch
>
>
> {code}
> CLASS=org.apache.hadoop.util.Classpath
> ^-- SC2034: CLASS appears unused. Verify it or export it.
> {code}
> We should probably use a local var here and return it or something, even
> though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-11524:
---
Assignee: Chris Nauroth
This got by me in my last code review. I'll take this and clean it up.
> hadoop_do_classpath_subcommand throws a shellcheck warning
> --
>
> Key: HADOOP-11524
> URL: https://issues.apache.org/jira/browse/HADOOP-11524
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Assignee: Chris Nauroth
>Priority: Minor
>
> {code}
> CLASS=org.apache.hadoop.util.Classpath
> ^-- SC2034: CLASS appears unused. Verify it or export it.
> {code}
> We should probably use a local var here and return it or something, even
> though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated HADOOP-11524:
--
Affects Version/s: 3.0.0
> hadoop_do_classpath_subcommand throws a shellcheck warning
> --
>
> Key: HADOOP-11524
> URL: https://issues.apache.org/jira/browse/HADOOP-11524
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Priority: Minor
>
> {code}
> CLASS=org.apache.hadoop.util.Classpath
> ^-- SC2034: CLASS appears unused. Verify it or export it.
> {code}
> We should probably use a local var here and return it or something, even
> though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HADOOP-11524) hadoop_do_classpath_subcommand throws a shellcheck warning
[
https://issues.apache.org/jira/browse/HADOOP-11524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated HADOOP-11524:
--
Component/s: scripts
> hadoop_do_classpath_subcommand throws a shellcheck warning
> --
>
> Key: HADOOP-11524
> URL: https://issues.apache.org/jira/browse/HADOOP-11524
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
>Affects Versions: 3.0.0
>Reporter: Allen Wittenauer
>Priority: Minor
>
> {code}
> CLASS=org.apache.hadoop.util.Classpath
> ^-- SC2034: CLASS appears unused. Verify it or export it.
> {code}
> We should probably use a local var here and return it or something, even
> though CLASS is technically a global.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
