[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Resolution: Fixed Fix Version/s: HADOOP-12111 Status: Resolved (was: Patch Available) Thanks for the review! Committed. I'll write a release note later today. > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Fix For: HADOOP-12111 > > Attachments: HADOOP-12129.HADOOP-12111.00.patch, > HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch, > HADOOP-12129.HADOOP-12111.03.patch, HADOOP-12129.HADOOP-12111.04.patch, > HADOOP-12129.HADOOP-12111.05.patch, HADOOP-12129.HADOOP-12111.06.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Attachment: HADOOP-12129.HADOOP-12111.06.patch -06: * fix issue with --bugcomments default * add --linecomments to turn those on and off as well > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch, > HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch, > HADOOP-12129.HADOOP-12111.03.patch, HADOOP-12129.HADOOP-12111.04.patch, > HADOOP-12129.HADOOP-12111.05.patch, HADOOP-12129.HADOOP-12111.06.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Attachment: HADOOP-12129.HADOOP-12111.05.patch -05: * address [~busbey]'s comments > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch, > HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch, > HADOOP-12129.HADOOP-12111.03.patch, HADOOP-12129.HADOOP-12111.04.patch, > HADOOP-12129.HADOOP-12111.05.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Attachment: HADOOP-12129.HADOOP-12111.04.patch -04: * some doc fixes/additions/cleanup * fix some leaky variables * point personalities to their github equivalents and set more reasonable defaults * added some code comments * fixed a minor but with GH pull requests * force GH to use v3 API * reformat the REST conversion bits to be a bit cleaner * whitespace now writes line comments * fix a bug where if the JIRA issue that was given as input was also a branch name, we don't switch to that branch * if we can't write to a system because of creds, report it. * guess_patch_file would throw errors if the input file didn't exist. the new locate_patch code can trigger this condition whereas before it didn't. * bugysstem line comments now take a header so that plugins can report which plugin actually generated the message * renamed bugsystem_output to bugsystem_finalreport to better reflect reality * > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch, > HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch, > HADOOP-12129.HADOOP-12111.03.patch, HADOOP-12129.HADOOP-12111.04.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Attachment: HADOOP-12129.HADOOP-12111.03.patch -03: * many, many, many bug fixes * moar documentation! * jira<->github bridges work much better now and truly are bi * branch detection now done on a per-bug system basis * basic branch detection on github PRs * plugins can now write comments to bug systems that have review capabilities. shellcheck and github are only ones that currently support this * github pull request links on the command line is much smarter * better authentication done * a few more globals killed to clean things up more > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch, > HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch, > HADOOP-12129.HADOOP-12111.03.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Attachment: HADOOP-12129.HADOOP-12111.02.patch -02: * fix some bugs with curl's usage in smart-apply-patch * github support works! both basic and token for auth! * jira plugin now has some simple/basic support of switching to github when it detects a pull request in the comments * removed jira-cmd parse arg since we don't need it anymore * some hard-coded sed's moved to use the sed var * jira was forcing it's header into github comments > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch, > HADOOP-12129.HADOOP-12111.01.patch, HADOOP-12129.HADOOP-12111.02.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Attachment: HADOOP-12129.HADOOP-12111.01.patch -01: * switch from wget and jira cli to tools to curl + jira REST API * issue determination bugfix > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch, > HADOOP-12129.HADOOP-12111.01.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Hadoop Flags: Incompatible change > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Status: Patch Available (was: Open) > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Attachment: HADOOP-12129.HADOOP-12111.00.patch -00: * this is incomplete; many todo's * move the logic of patch downloading to a plugin * flesh out more of the github support * move the console output to a 'fake' bug system plugin * fix a few bugs here and there * change more local's to declare's * now run through *all* of the bug systems to allow posting comments to multiple systems at once. * break write_comment stability * change ISSUE_RE to JIRA_ISSUE_RE * we *might* support more than http URLs now, but I need to test it * fix a few offline bits that were missing * jira now uses username/pass much more than it did * jira should work on non-apache setups now (altho we really need to do more RESTy things rather than depending upon jira-cli.) * may have found a bug with shellcheck wrt declare -a... * removed a few dead vars > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Assignee: Allen Wittenauer >Priority: Blocker > Attachments: HADOOP-12129.HADOOP-12111.00.patch > > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Priority: Blocker (was: Major) > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer >Priority: Blocker > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HADOOP-12129) rework test-patch bug system support
[ https://issues.apache.org/jira/browse/HADOOP-12129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HADOOP-12129: -- Affects Version/s: HADOOP-12111 > rework test-patch bug system support > > > Key: HADOOP-12129 > URL: https://issues.apache.org/jira/browse/HADOOP-12129 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus >Affects Versions: HADOOP-12111 >Reporter: Allen Wittenauer > > WARNING: this is a fairly big project. > See first comment for a brain dump on the issues. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
